Skip to content

A lack of parts of implement of the papar #87

@AlvinAi96

Description

@AlvinAi96

Although the code looks nice, I found this code isn't intact. If someone is trying to use it, please be careful.

  1. maxlen: it shouldn't be the fixed-length as it defined as 15. In the paper, section 4.3 Training Proceduce, author uses the other method which is corresponding the homogeneous_data.py in the paper's code.
  2. Beam search: this code doesn't implement beam search.

So far, I only found out these things and I decide to use the paper's original code instead of this. Anyway, I still appreciate the tensorflow attempt. The code is clear and beautiful. Thanks for sharing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions