How to install?

[saveli]

When trying to build the Dockerfile, I run into this error:

user@overleaf:~/overleaf-cep/server-ce$ make build-community
cp .dockerignore ../
docker build \
  --build-arg BUILDKIT_INLINE_CACHE=1 \
  --build-arg OVERLEAF_BASE_TAG \
  --build-arg MONOREPO_REVISION \
  --cache-from sharelatex/sharelatex \
  --cache-from sharelatex/sharelatex:ldap-tc \
  --file Dockerfile \
  --tag sharelatex/sharelatex:ldap-tc-62023e69b3540e87d03550ad64fdab45aa324bf6 \
  --tag sharelatex/sharelatex:ldap-tc \
  ../
[+] Building 0.8s (3/3) FINISHED                                                                            docker:default
 => [internal] load build definition from Dockerfile                                                                  0.0s
 => => transferring dockerfile: 3.83kB                                                                                0.0s
 => [internal] load .dockerignore                                                                                     0.0s
 => => transferring context: 227B                                                                                     0.0s
 => ERROR [internal] load metadata for docker.io/sharelatex/sharelatex-base:ldap-tc-62023e69b3540e87d03550ad64fdab45  0.8s
------
 > [internal] load metadata for docker.io/sharelatex/sharelatex-base:ldap-tc-62023e69b3540e87d03550ad64fdab45aa324bf6:
------
Dockerfile:6
--------------------
   4 |     
   5 |     ARG OVERLEAF_BASE_TAG=sharelatex/sharelatex-base:latest
   6 | >>> FROM $OVERLEAF_BASE_TAG
   7 |     
   8 |     WORKDIR /overleaf
--------------------
ERROR: failed to solve: sharelatex/sharelatex-base:ldap-tc-62023e69b3540e87d03550ad64fdab45aa324bf6: docker.io/sharelatex/sharelatex-base:ldap-tc-62023e69b3540e87d03550ad64fdab45aa324bf6: not found
make: *** [Makefile:30: build-community] Error 1

@yu-i-i How to install?

[yu-i-i]

@saveli
It looks like you havent built base image. Run
make without agruments.

[saveli]

They don't:

admin@overleaf:~/toolkit$ bin/logs | grep user=
admin@overleaf:~/toolkit$ bin/logs | grep ldapUser=
admin@overleaf:~/toolkit$ 

[yu-i-i]

Is the LDAP authentication module enabled in the configuration? If you edit the code in a running container, you need to restart the 'node' process for your changes to take effect.

killall -9 node

If there is still nothing in the log, after this line:

overleaf-cep/services/web/app/src/Features/Authentication/AuthenticationController.js

Line 107 in 346ad50

async function (err, user, infoArray) {

output the values of 'err', 'user', and 'infoArray. Try to do this with both an LDAP user and a local user.

[saveli]

I did a git reset --hard and git pull, so ldap was enabled. I checked just now and yes, it is enabled, i.e. not commented out.
Also, I always checked with docker ps for running container and used bin/stop, bin/up respectively, when trying changes.

For local and ldap user:

web           | err= unexpected number of matches (41) for "<user>" username
web           | user= undefined
web           | infoArray= undefined

User name is irrelevant (email, no email, existing, non-existing), the number 41 doesn't change. I did remove /data beforehand.

[yu-i-i]

Could you please tell me the values of the variables OVERLEAF_LDAP_SEARCH_BASE and OVERLEAF_LDAP_SEARCH_FILTER? I suspect that the problem in them.

In the running container, you can find the following code in the file /overleaf/node_modules/ldapauth-fork/lib/ldapauth.js :

  switch (result.length) {
    case 0:
      return callback();
    case 1:
      return callback(null, result[0]);
    default:
      return callback(format(
        'unexpected number of matches (%s) for "%s" username',
        result.length, username));
  }

From this, we can see that the LDAP search in your case returns 41 results, but the result should be unique or empty. If it is not clear from OVERLEAF_LDAP_SEARCH_BASE and OVERLEAF_LDAP_SEARCH_FILTER, you might be able to determine why the search returns so many results by printing them to the log. Start a shell in the container, add console.log("results = ", results) before this code, and restart the node processes by running killall -9 node

[saveli]

Finally it works!

OVERLEAF_LDAP_SEARCH_FILTER was configured without the {{username}} literal, i.e. the way LDAP usually works - returning a set and then testing the credentials for set inclusion rather than exact match. This part could be highlighted in the readme.md.

Anyhow, many thanks!

[yu-i-i]

Sorry, I have no idea why it's not working as expected. I especially don't understand why this is happening:

I added back the docker override, and something with mongodb is different from upstream - now I receive above ECONNREFUSED which I did not as long as I only ran ldap-tc with data not removed in between.

If 'ldap-authentication' is commented out, the authentication code is from upstream. Just once more. Am I understand right: you create a user in Launchpad with upstream version, then you run ldap-tc version with commented out 'ldap-authentication', and you cannot authenticate?

[saveli]

Solved, see #2 (reply in thread)