Skip to content

Commit 5b8ae08

Browse files
dongjoon-hyunyhuang-db
authored andcommitted
[SPARK-52303][CORE] Promote ExternalCommandRunner to Stable
### What changes were proposed in this pull request? This PR aims to promote `ExternalCommandRunner` to `Stable` API in Apache Spark 4.1.0. ### Why are the changes needed? Since Apache Spark 3.0.0, `ExternalCommandRunner` has been serving without any change over five years. - apache#27199 https://github.com/apache/spark/blob/70cfe7d42f6092f2e44f80fdb4e7ac352c02f0ba/sql/catalyst/src/main/java/org/apache/spark/sql/connector/ExternalCommandRunner.java#L31-L34 Since Apache Spark 4.0.0, `Spark Connect` provides this as one of the defined protocols - apache#49774 https://github.com/apache/spark/blob/70cfe7d42f6092f2e44f80fdb4e7ac352c02f0ba/sql/connect/common/src/main/protobuf/spark/connect/commands.proto#L541-L543 Given the above situation, we had better make `interface ExternalCommandRunner` `Stable` because we cannot change this in a breaking way in Apache Spark 4.x in another five years although it's marked `Unstable` as of now. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#51015 from dongjoon-hyun/SPARK-52303. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
1 parent efd87c0 commit 5b8ae08

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sql/catalyst/src/main/java/org/apache/spark/sql/connector/ExternalCommandRunner.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
package org.apache.spark.sql.connector;
1919

20-
import org.apache.spark.annotation.Unstable;
20+
import org.apache.spark.annotation.Stable;
2121
import org.apache.spark.sql.util.CaseInsensitiveStringMap;
2222

2323
/**
@@ -30,7 +30,7 @@
3030
*
3131
* @since 3.0.0
3232
*/
33-
@Unstable
33+
@Stable
3434
public interface ExternalCommandRunner {
3535

3636
/**

0 commit comments

Comments
 (0)