Skip to content

Commit d958202

Browse files
authored
Update README.md
1 parent 21b0dd1 commit d958202

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

README.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,6 @@ There should be no build errors and we can open the framework in the browser:
100100

101101
Some frameworks like binding.scala or ember can't be opened that way, because they need a 'dist' or 'target/web/stage' or something in the URL. You can find out the correct URL in the [index.html](http://localhost:8080/index.html) you've opened before or take a look whether there's a customURL property under js-framework-benchmark in the [package.json](https://github.com/krausest/js-framework-benchmark/blob/master/frameworks/keyed/ember/package.json#L10) that represents the url.
102102

103-
Open the browser console and click a bit on the buttons and you should see some measurements printed on the console.
104-
![First Run](images/firstRun.png?raw=true "First run")
105-
106-
> What is printed on the console is not what is actually measured by the automated benchmark driver. The benchmark driver extracts events from chrome's timeline to calculate the duration for the operations. What get's printed on the console above is an approximation of the actual duration which is pretty close to the actual duration.
107-
108103
## Optional 3.1: Contributing a new implementation
109104

110105
For contributions it is basically sufficient to create a new directory for your framework that supports `npm install` and `npm run build-prod` and can be then opened in the browser. All other steps are optional. Let's simulate that by copying vanillajs.
@@ -125,7 +120,7 @@ In most cases you'll need `npm install` and `npm run build-prod` and then check
125120

126121
## 4. Running a single framework with the automated benchmark driver
127122

128-
As mentioned above the benchmark uses an automated benchmark driver using chromedriver to measure the duration for each operation using chrome's timeline. Here are the steps to run is for a single framework:
123+
The benchmark uses an automated benchmark driver using chromedriver to measure the duration for each operation using chrome's timeline. Here are the steps to run is for a single framework:
129124

130125
```
131126
cd ../../..

0 commit comments

Comments
 (0)