Skip to content

Commit 804271c

Browse files
committed
Migrate yew from non-keyed to keyed
1 parent 88ec1cc commit 804271c

File tree

10 files changed

+16
-15
lines changed

10 files changed

+16
-15
lines changed
File renamed without changes.

frameworks/non-keyed/yew/Cargo.toml renamed to frameworks/keyed/yew/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ crate-type = ["cdylib"]
1010
[dependencies]
1111
rand = { version = "0.7.3", features = ["wasm-bindgen", "small_rng"] }
1212
wasm-bindgen = "0.2.62"
13-
yew = "0.16.2"
13+
yew = { git = "https://github.com/totorigolo/yew", branch = "bugfix/keyed-elements-reorder" }
1414

1515
[profile.release]
1616
lto = true
File renamed without changes.

frameworks/non-keyed/yew/bundled-dist/js-framework-benchmark-yew.js renamed to frameworks/keyed/yew/bundled-dist/js-framework-benchmark-yew.js

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ function addBorrowedObject(obj) {
203203
}
204204
function __wbg_adapter_16(arg0, arg1, arg2) {
205205
try {
206-
wasm.wasm_bindgen__convert__closures__invoke1_mut_ref__h66b94e249be13806(arg0, arg1, addBorrowedObject(arg2));
206+
wasm.wasm_bindgen__convert__closures__invoke1_mut_ref__h51d4f69569056647(arg0, arg1, addBorrowedObject(arg2));
207207
} finally {
208208
heap[stack_pointer++] = undefined;
209209
}
@@ -376,21 +376,25 @@ async function init(input) {
376376
var ret = getObject(arg0).nextSibling;
377377
return isLikeNone(ret) ? 0 : addHeapObject(ret);
378378
};
379-
imports.wbg.__wbg_setnodeValue_ab4d09a5c9b583a3 = function(arg0, arg1, arg2) {
380-
getObject(arg0).nodeValue = arg1 === 0 ? undefined : getStringFromWasm0(arg1, arg2);
381-
};
382-
imports.wbg.__wbg_createTextNode_756ffaca4044be42 = function(arg0, arg1, arg2) {
383-
var ret = getObject(arg0).createTextNode(getStringFromWasm0(arg1, arg2));
384-
return addHeapObject(ret);
385-
};
386379
imports.wbg.__wbg_appendChild_3d4ec7dbf3472d31 = handleError(function(arg0, arg1) {
387380
var ret = getObject(arg0).appendChild(getObject(arg1));
388381
return addHeapObject(ret);
389382
});
383+
imports.wbg.__wbg_firstChild_cc345cf09851e11c = function(arg0) {
384+
var ret = getObject(arg0).firstChild;
385+
return isLikeNone(ret) ? 0 : addHeapObject(ret);
386+
};
390387
imports.wbg.__wbg_insertBefore_e617280513985f61 = handleError(function(arg0, arg1, arg2) {
391388
var ret = getObject(arg0).insertBefore(getObject(arg1), getObject(arg2));
392389
return addHeapObject(ret);
393390
});
391+
imports.wbg.__wbg_setnodeValue_ab4d09a5c9b583a3 = function(arg0, arg1, arg2) {
392+
getObject(arg0).nodeValue = arg1 === 0 ? undefined : getStringFromWasm0(arg1, arg2);
393+
};
394+
imports.wbg.__wbg_createTextNode_756ffaca4044be42 = function(arg0, arg1, arg2) {
395+
var ret = getObject(arg0).createTextNode(getStringFromWasm0(arg1, arg2));
396+
return addHeapObject(ret);
397+
};
394398
imports.wbg.__wbg_namespaceURI_35b1c4eab9150629 = function(arg0, arg1) {
395399
var ret = getObject(arg1).namespaceURI;
396400
var ptr0 = isLikeNone(ret) ? 0 : passStringToWasm0(ret, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
@@ -447,11 +451,8 @@ async function init(input) {
447451
imports.wbg.__wbg_addEventListener_3526086a053a131e = handleError(function(arg0, arg1, arg2, arg3, arg4) {
448452
getObject(arg0).addEventListener(getStringFromWasm0(arg1, arg2), getObject(arg3), getObject(arg4));
449453
});
450-
imports.wbg.__wbg_stopPropagation_71c3dbce6a10eea7 = function(arg0) {
451-
getObject(arg0).stopPropagation();
452-
};
453-
imports.wbg.__wbindgen_closure_wrapper1218 = function(arg0, arg1, arg2) {
454-
var ret = makeMutClosure(arg0, arg1, 25, __wbg_adapter_16);
454+
imports.wbg.__wbindgen_closure_wrapper1238 = function(arg0, arg1, arg2) {
455+
var ret = makeMutClosure(arg0, arg1, 26, __wbg_adapter_16);
455456
return addHeapObject(ret);
456457
};
457458

Binary file not shown.
File renamed without changes.

frameworks/non-keyed/yew/src/lib.rs renamed to frameworks/keyed/yew/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ impl Component for Model {
180180
{ for self.rows.iter().map(|row| {
181181
let id = row.id.clone();
182182
html! {
183-
<tr class=if self.selected_id == Some(id) { "danger" } else { "" }>
183+
<tr key={id.to_string()} class=if self.selected_id == Some(id) { "danger" } else { "" }>
184184
<td class="col-md-1">{ id.to_string() }</td>
185185
<td class="col-md-4" onclick=self.link.callback(move |_| Msg::Select(id))>
186186
<a class="lbl">{ row.label.clone() }</a>
Binary file not shown.

0 commit comments

Comments
 (0)