show open issues for implementations

krausest · krausest · commit 5e96ca45b0d4 · 2020-03-15T19:52:08.000+01:00
diff --git a/frameworks/keyed/aurelia/package.json b/frameworks/keyed/aurelia/package.json
@@ -3,7 +3,8 @@
   "version": "1.0.0",
   "description": "Benchmark for aurelia framework",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "aurelia-framework"
+    "frameworkVersionFromPackage": "aurelia-framework",
+    "issues": [694]
   },
   "keywords": [
     "aurelia"
diff --git a/frameworks/keyed/binding.scala/package.json b/frameworks/keyed/binding.scala/package.json
@@ -4,7 +4,8 @@
   "description": "Benchmark for Binding.scala",
   "js-framework-benchmark": {
     "frameworkVersion": "10.0.1",
-    "customURL": "/target/web/stage"
+    "customURL": "/target/web/stage",
+    "issues": [694]
   },
   "scripts": {
     "build-prod": "sbt web-stage"
diff --git a/frameworks/keyed/crui/package.json b/frameworks/keyed/crui/package.json
@@ -3,7 +3,8 @@
   "version": "0.1.0",
   "main": "dist/main.js",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "@crui/core"
+    "frameworkVersionFromPackage": "@crui/core",
+    "issues": [694]
   },
   "scripts": {
     "build-dev": "webpack --watch",
diff --git a/frameworks/keyed/datum/package.json b/frameworks/keyed/datum/package.json
@@ -1,9 +1,10 @@
 {
-  "name": "js-framework-benchmark-Datumjs",
+  "name": "js-framework-benchmark-datumjs",
   "version": "1.0.0",
   "description": "Benchmark for Datum v0.8",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "Datum"
+    "frameworkVersionFromPackage": "Datum",
+    "issues": [694]
   },
   "scripts": {
     "build-dev": "webpack -w -d -c webpack.config.js",
diff --git a/frameworks/keyed/dojo/package.json b/frameworks/keyed/dojo/package.json
@@ -3,7 +3,8 @@
   "version": "1.0.0",
   "js-framework-benchmark": {
     "frameworkVersionFromPackage": "@dojo/framework",
-    "customURL": "/output/dist"
+    "customURL": "/output/dist",
+    "issues": [694]
   },
   "scripts": {
     "build-prod": "./node_modules/.bin/dojo build"
diff --git a/frameworks/keyed/fidan/package.json b/frameworks/keyed/fidan/package.json
@@ -10,7 +10,8 @@
     "yalc-link": "yalc link @fidanjs/runtime"
   },
   "js-framework-benchmark": {
-    "frameworkVersion": "0.0.23"
+    "frameworkVersionFromPackage": "@fidanjs/runtime",
+    "issues": [694]
   },
   "repository": {
     "type": "git",
@@ -26,14 +27,14 @@
   },
   "homepage": "https://github.com/krausest/js-framework-benchmark#readme",
   "dependencies": {
-    "@fidanjs/jsx": "^0.0.8",
-    "@fidanjs/runtime": "^0.0.23"
+    "@fidanjs/jsx": "0.0.8",
+    "@fidanjs/runtime": "0.0.23"
   },
   "devDependencies": {
-    "@babel/preset-env": "^7.4.4",
-    "@babel/preset-typescript": "^7.3.3",
-    "babel-loader": "^8.0.6",
-    "webpack": "^4.31.0",
-    "webpack-cli": "^3.3.2"
+    "@babel/preset-env": "7.4.4",
+    "@babel/preset-typescript": "7.3.3",
+    "babel-loader": "8.0.6",
+    "webpack": "4.31.0",
+    "webpack-cli": "3.3.2"
   }
 }
diff --git a/frameworks/keyed/maquette/package.json b/frameworks/keyed/maquette/package.json
@@ -3,7 +3,8 @@
   "version": "3.0.1-keyed",
   "description": "Benchmark for maquette framework (keyed)",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "maquette"
+    "frameworkVersionFromPackage": "maquette",
+    "issues": [694]
   },
   "scripts": {
     "build-dev": "node build.js",
diff --git a/frameworks/keyed/mikado/package.json b/frameworks/keyed/mikado/package.json
@@ -5,7 +5,8 @@
   "author": "Nextapps GmbH",
   "license": "Apache-2.0",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "mikado"
+    "frameworkVersionFromPackage": "mikado",
+    "issues": [694]
   },
   "preferGlobal": false,
   "repository": {
diff --git a/frameworks/keyed/plastiq/package.json b/frameworks/keyed/plastiq/package.json
@@ -3,7 +3,8 @@
   "version": "1.0.0",
   "description": "Benchmark for plastiq framework",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "plastiq"
+    "frameworkVersionFromPackage": "plastiq",
+    "issues": [634]
   },
   "scripts": {
     "build-dev": "webpack -w -d -c webpack.config.js",
diff --git a/frameworks/keyed/rawact/package.json b/frameworks/keyed/rawact/package.json
@@ -4,7 +4,8 @@
   "description": "Rawact demo",
   "main": "index.js",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "babel-plugin-rawact"
+    "frameworkVersionFromPackage": "babel-plugin-rawact",
+    "issues": [634]
   },
   "scripts": {
     "build-dev": "webpack --watch",
diff --git a/frameworks/keyed/reflex-dom/package.json b/frameworks/keyed/reflex-dom/package.json
@@ -5,7 +5,8 @@
   "author": "Alexandre Esteves <alexandre.fmp.esteves@gmail.com>",
   "js-framework-benchmark": {
     "frameworkVersion": "0.4",
-    "customURL": "/bundled-dist"
+    "customURL": "/bundled-dist",
+    "issues": [694]
   },
   "contributors": [
     "Ryan Trinkle <ryan.trinkle@gmail.com>"
diff --git a/frameworks/keyed/san/package.json b/frameworks/keyed/san/package.json
@@ -3,7 +3,8 @@
   "version": "3.7.6",
   "description": "Benchmark for san framework",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "san"
+    "frameworkVersionFromPackage": "san",
+    "issues": [694]
   },
   "scripts": {
     "build-dev": "webpack -w -d",
diff --git a/frameworks/non-keyed/cyclejs-dom/package.json b/frameworks/non-keyed/cyclejs-dom/package.json
@@ -3,7 +3,8 @@
   "version": "1.0.0",
   "description": "Benchmark for Cycle.js framework",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "@cycle/dom"
+    "frameworkVersionFromPackage": "@cycle/dom",
+    "issues": [634]
   },
   "scripts": {
     "build-dev": "webpack -w -d",
diff --git a/frameworks/non-keyed/rawact/package.json b/frameworks/non-keyed/rawact/package.json
@@ -4,7 +4,8 @@
   "description": "Rawact demo",
   "main": "index.js",
   "js-framework-benchmark": {
-    "frameworkVersionFromPackage": "babel-plugin-rawact"
+    "frameworkVersionFromPackage": "babel-plugin-rawact",
+    "issues": [634]
   },
   "scripts": {
     "build-dev": "webpack --watch",
diff --git a/frameworks/non-keyed/stem/package.json b/frameworks/non-keyed/stem/package.json
@@ -4,7 +4,8 @@
   "description": "None",
   "main": "index.js",
   "js-framework-benchmark": {
-    "frameworkVersion": "0.2.70"
+    "frameworkVersion": "0.2.70",
+    "issues": [634]
   },
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
diff --git a/webdriver-ts-results/src/App.css b/webdriver-ts-results/src/App.css
@@ -172,4 +172,24 @@ font-size: 8px;
 }
 .sortKey {
   text-decoration: underline;
+}
+
+dl {
+    width: 100%;
+    overflow: hidden;
+    padding: 0;
+    margin-bottom: 16px;
+}
+dt {
+    float: left;
+    width: 50px;
+    padding: 0;
+    margin: 0
+}
+dd {
+    padding: 0;
+    margin: 0;
+}
+.with-issues {
+    background-color: #faa;
 }
diff --git a/webdriver-ts-results/src/App.tsx b/webdriver-ts-results/src/App.tsx
@@ -23,13 +23,19 @@ interface State {
   displayMode: IDisplayMode;
 }
 
+let knownIssues = [
+  {issue: 634, text:"The HTML structure for the implementation is not fully correct.", link: "https://github.com/krausest/js-framework-benchmark/issues/634"},
+  {issue: 694, text:"Keyed implementations must move the DOM nodes for swap rows ", link: "https://github.com/krausest/js-framework-benchmark/issues/694"},
+];
+
+
 let results : Result[] = (rawResults as RawResult[]).map(res => Object.assign(({framework: res.f, benchmark: res.b, values: res.v}),
     {mean: res.v ? jStat.mean(res.v) : Number.NaN,
     median: res.v ? jStat.median(res.v) : Number.NaN,
     standardDeviation: res.v ? jStat.stdev(res.v, true):  Number.NaN}));
 
-let allBenchmarks = () => benchmarks.reduce((set, b) => set.add(b), new Set() );
-let allFrameworks = () => frameworks.reduce((set, f) => set.add(f), new Set() );
+let allBenchmarks = () => benchmarks.reduce((set, b) => set.add(b), new Set<Benchmark>() );
+let allFrameworks = () => frameworks.reduce((set, f) => set.add(f), new Set<Framework>() );
 
 let _allBenchmarks = allBenchmarks();
 let _allFrameworks = allFrameworks();
@@ -105,7 +111,7 @@ class App extends React.Component<{}, State> {
     this.state = this.nextState;
   }
   selectBenchmark = (benchmark: Benchmark, value: boolean) => {
-    let set = new Set();
+    let set = new Set<Benchmark>();
     this.state.selectedBenchmarks.forEach(benchmark => set.add(benchmark));
     if (set.has(benchmark)) set.delete(benchmark);
     else set.add(benchmark);
@@ -117,7 +123,7 @@ class App extends React.Component<{}, State> {
     this.setState({selectedBenchmarks: set, sortKey, resultTables: this.updateResultTable()});
   }
   selectFramework = (framework: Framework, value: boolean): void => {
-    let set = new Set();
+    let set = new Set<Framework>();
     this.state.selectedFrameworks.forEach(framework => set.add(framework));
     if (set.has(framework)) set.delete(framework);
     else set.add(framework);
@@ -207,6 +213,14 @@ class App extends React.Component<{}, State> {
             The test is performed as a one sided t-test. The significance level is 10%. The darker the color the lower the p-Value.</p>
           )}
           <ResultTable currentSortKey={this.state.sortKey} data={this.state.resultTables} separateKeyedAndNonKeyed={this.state.separateKeyedAndNonKeyed} sortBy={this.sortBy} displayMode={this.state.displayMode}/>
+
+          <h3>Known Issues</h3>
+          {knownIssues.map(issue =>
+            <dl id={issue.issue.toFixed()}>
+              <dt><a target="_blank" href={issue.link}>{issue.issue.toFixed()}</a></dt>
+              <dd>{issue.text}</dd>
+            </dl>
+          )}
       </div>
     );
   }
diff --git a/webdriver-ts-results/src/Common.tsx b/webdriver-ts-results/src/Common.tsx
@@ -21,6 +21,7 @@ export const DisplayMode_BoxPlot = new DisplayModeSimple(DisplayMode.BoxPlot);
 export interface Framework {
     name: string;
     keyed: boolean;
+    issues?: number[];
 }
 
 export enum BenchmarkType { CPU, MEM, STARTUP }
diff --git a/webdriver-ts-results/src/ResultTable.tsx b/webdriver-ts-results/src/ResultTable.tsx
@@ -117,7 +117,15 @@ const CpuResultsTable = ({data, currentSortKey, sortBy, displayMode} : {data: Re
             <thead>
               <tr>
                 <th className='benchname'><a href='#' className={currentSortKey==SORT_BY_NAME ? 'sortKey' : ''} onClick={(event) => {event.preventDefault(); sortBy(SORT_BY_NAME)}}>Name</a><br/>Duration for...</th>
-                {data.frameworks.map(f => <th key={f.name}>{f.name}</th>)}
+                {data.frameworks.map(f => <th className={f.issues ? 'with-issues' : ''} key={f.name}>{f.name}</th>)}
+              </tr>
+            </thead>
+            <thead>
+              <tr>
+                  <th className='openIssues'>Issues for the implementation</th>
+                  {data.frameworks.map(f => <th key={f.name}>{
+                    f.issues && f.issues.map(i => <a href={'#'+i.toFixed()}>{i.toFixed()}</a> )
+                  }</th>)}
               </tr>
             </thead>
             <tbody>
diff --git a/webdriver-ts-results/src/results.ts b/webdriver-ts-results/src/results.ts
diff --git a/webdriver-ts-results/table.html b/webdriver-ts-results/table.html
diff --git a/webdriver-ts/results.json b/webdriver-ts/results.json
diff --git a/webdriver-ts/src/common.ts b/webdriver-ts/src/common.ts
diff --git a/webdriver-ts/src/createResultJS.ts b/webdriver-ts/src/createResultJS.ts
