Skip to content

Commit 75e602e

Browse files
authored
fix: report location in use-baseline (#314)
1 parent a5d65ce commit 75e602e

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

packages/eslint-plugin/lib/rules/use-baseline.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ module.exports = {
227227
)
228228
) {
229229
context.report({
230-
node: attribute.key,
230+
node: attribute.value,
231231
messageId: MESSAGE_IDS.NOT_BASELINE_ELEMENT_ATTRIBUTE,
232232
data: {
233233
element: `<${elementName}>`,
@@ -242,7 +242,7 @@ module.exports = {
242242
)
243243
) {
244244
context.report({
245-
node: attribute,
245+
node: attribute.value,
246246
messageId: MESSAGE_IDS.NOT_BASELINE_GLOBAL_ATTRIBUTE,
247247
data: {
248248
attr: `${attribute.key.value}="${attribute.value.value}"`,

packages/eslint-plugin/tests/rules/use-baseline.test.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ ruleTester.run("use-baseline", rule, {
121121
{
122122
message:
123123
"Attribute 'contenteditable=\"plaintext-only\"' is not a widely available baseline feature.",
124-
column: 6,
125-
endColumn: 38,
124+
column: 23,
125+
endColumn: 37,
126126
line: 1,
127127
},
128128
],
@@ -134,8 +134,8 @@ ruleTester.run("use-baseline", rule, {
134134
{
135135
message:
136136
"Attribute 'contenteditable=\"PLAINTEXT-ONLY\"' is not a widely available baseline feature.",
137-
column: 6,
138-
endColumn: 38,
137+
column: 23,
138+
endColumn: 37,
139139
line: 1,
140140
},
141141
],
@@ -147,8 +147,8 @@ ruleTester.run("use-baseline", rule, {
147147
{
148148
message:
149149
"Attribute 'contenteditable=\"PLAINTEXT-ONLY \"' is not a widely available baseline feature.",
150-
column: 6,
151-
endColumn: 39,
150+
column: 23,
151+
endColumn: 38,
152152
line: 1,
153153
},
154154
],
@@ -159,6 +159,8 @@ ruleTester.run("use-baseline", rule, {
159159
{
160160
message:
161161
"Attribute 'type=\"module\"' on '<script>' is not a 2017 available baseline feature.",
162+
column: 15,
163+
endColumn: 21,
162164
},
163165
],
164166
options: [
@@ -168,11 +170,13 @@ ruleTester.run("use-baseline", rule, {
168170
],
169171
},
170172
{
171-
code: `<style blocking="render"></script>`,
173+
code: `<style blocking="render"></style>`,
172174
errors: [
173175
{
174176
message:
175177
"Attribute 'blocking' on '<style>' is not a widely available baseline feature.",
178+
column: 8,
179+
endColumn: 16,
176180
},
177181
],
178182
options: [

0 commit comments

Comments
 (0)