Skip to content

Commit e98ac7d

Browse files
sabdenovchblinkov
authored andcommitted
Cosmetics in QL test
commit_hash:5963f3bfc09538d500fa3733677bff3be8d3dccd
1 parent 7eabcdb commit e98ac7d

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

yt/yt/client/table_client/helpers.cpp

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -164,16 +164,15 @@ void YTreeNodeToUnversionedValue(
164164
} // namespace
165165

166166
TUnversionedOwningRow YsonToSchemafulRow(
167-
const TString& yson,
167+
TStringBuf yson,
168168
const TTableSchema& tableSchema,
169169
bool treatMissingAsNull,
170170
NYson::EYsonType ysonType,
171171
bool validateValues)
172172
{
173173
auto nameTable = TNameTable::FromSchema(tableSchema);
174174

175-
auto rowParts = ConvertTo<THashMap<TString, INodePtr>>(
176-
TYsonString(yson, ysonType));
175+
auto rowParts = ConvertTo<THashMap<TString, INodePtr>>(TYsonString(yson, ysonType));
177176

178177
TUnversionedOwningRowBuilder rowBuilder;
179178
auto validateAndAddValue = [&rowBuilder, &validateValues] (const TUnversionedValue& value, const TColumnSchema& column) {
@@ -266,7 +265,7 @@ TUnversionedOwningRow YsonToSchemafulRow(
266265
return rowBuilder.FinishRow();
267266
}
268267

269-
TUnversionedOwningRow YsonToSchemalessRow(const TString& valueYson)
268+
TUnversionedOwningRow YsonToSchemalessRow(TStringBuf valueYson)
270269
{
271270
TUnversionedOwningRowBuilder builder;
272271

@@ -285,8 +284,8 @@ TUnversionedOwningRow YsonToSchemalessRow(const TString& valueYson)
285284

286285
TVersionedRow YsonToVersionedRow(
287286
const TRowBufferPtr& rowBuffer,
288-
const TString& keyYson,
289-
const TString& valueYson,
287+
TStringBuf keyYson,
288+
TStringBuf valueYson,
290289
const std::vector<TTimestamp>& deleteTimestamps,
291290
const std::vector<TTimestamp>& extraWriteTimestamps)
292291
{
@@ -349,8 +348,8 @@ TVersionedRow YsonToVersionedRow(
349348
}
350349

351350
TVersionedOwningRow YsonToVersionedRow(
352-
const TString& keyYson,
353-
const TString& valueYson,
351+
TStringBuf keyYson,
352+
TStringBuf valueYson,
354353
const std::vector<TTimestamp>& deleteTimestamps,
355354
const std::vector<TTimestamp>& extraWriteTimestamps)
356355
{
@@ -360,7 +359,7 @@ TVersionedOwningRow YsonToVersionedRow(
360359
return TVersionedOwningRow(row);
361360
}
362361

363-
TUnversionedOwningRow YsonToKey(const TString& yson)
362+
TUnversionedOwningRow YsonToKey(TStringBuf yson)
364363
{
365364
TUnversionedOwningRowBuilder keyBuilder;
366365
auto keyParts = ConvertTo<std::vector<INodePtr>>(

yt/yt/client/table_client/helpers.h

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,25 +34,24 @@ NChunkClient::EChunkFormat DefaultFormatFromOptimizeFor(
3434
// Mostly used in unittests and for debugging purposes.
3535
// Quite inefficient.
3636
TUnversionedOwningRow YsonToSchemafulRow(
37-
const TString& yson,
37+
TStringBuf yson,
3838
const TTableSchema& tableSchema,
3939
bool treatMissingAsNull,
4040
NYson::EYsonType ysonType = NYson::EYsonType::MapFragment,
4141
bool validateValues = false);
42-
TUnversionedOwningRow YsonToSchemalessRow(
43-
const TString& yson);
42+
TUnversionedOwningRow YsonToSchemalessRow(TStringBuf yson);
4443
TVersionedRow YsonToVersionedRow(
4544
const TRowBufferPtr& rowBuffer,
46-
const TString& keyYson,
47-
const TString& valueYson,
45+
TStringBuf keyYson,
46+
TStringBuf valueYson,
4847
const std::vector<TTimestamp>& deleteTimestamps = {},
4948
const std::vector<TTimestamp>& extraWriteTimestamps = {});
5049
TVersionedOwningRow YsonToVersionedRow(
51-
const TString& keyYson,
52-
const TString& valueYson,
50+
TStringBuf keyYson,
51+
TStringBuf valueYson,
5352
const std::vector<TTimestamp>& deleteTimestamps = {},
5453
const std::vector<TTimestamp>& extraWriteTimestamps = {});
55-
TUnversionedOwningRow YsonToKey(const TString& yson);
54+
TUnversionedOwningRow YsonToKey(TStringBuf yson);
5655
TString KeyToYson(TUnversionedRow row);
5756

5857
////////////////////////////////////////////////////////////////////////////////

0 commit comments

Comments
 (0)