Skip to content

Commit e30884e

Browse files
authored
Check ActorLibCollectUsageStats to reduce utils metric count (#15992)
1 parent 974186e commit e30884e

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

ydb/library/actors/core/mailbox_lockfree.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ namespace NActors {
361361
Y_DEBUG_ABORT_UNLESS(GetNextPtr(tail) == nullptr);
362362
#ifdef ACTORSLIB_COLLECT_EXEC_STATS
363363
// Mark events as enqueued when usage stats are enabled
364-
if (ActorLibCollectUsageStats) {
364+
if constexpr (ActorLibCollectUsageStats) {
365365
for (IEventHandle* ev = head; ev; ev = GetNextPtr(ev)) {
366366
if (IActor* actor = FindActor(ev->GetRecipientRewrite().LocalId())) {
367367
actor->OnEnqueueEvent(ev->SendTime);

ydb/library/actors/helpers/collector_counters.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,10 @@ void TActivityStats::Set(const TExecutorThreadStats& stats) {
7070
*ScheduledEventsByActivityBuckets[i] = scheduled;
7171
*StuckActorsByActivityBuckets[i] = stuck;
7272

73-
for (ui32 j = 0; j < 10; ++j) {
74-
*UsageByActivityBuckets[i][j] = stats.UsageByActivity[i][j];
73+
if constexpr (ActorLibCollectUsageStats) {
74+
for (ui32 j = 0; j < 10; ++j) {
75+
*UsageByActivityBuckets[i][j] = stats.UsageByActivity[i][j];
76+
}
7577
}
7678
}
7779

@@ -117,8 +119,10 @@ void TActivityStats::InitCountersForActivity(ui32 activityType) {
117119
StuckActorsByActivityBuckets[activityType] =
118120
Group->GetSubgroup("sensor", "StuckActorsByActivity")->GetNamedCounter("activity", bucketName, false);
119121

120-
for (ui32 i = 0; i < 10; ++i) {
121-
UsageByActivityBuckets[activityType][i] = Group->GetSubgroup("sensor", "UsageByActivity")->GetSubgroup("bin", ToString(i))->GetNamedCounter("activity", bucketName, false);
122+
if constexpr (ActorLibCollectUsageStats) {
123+
for (ui32 i = 0; i < 10; ++i) {
124+
UsageByActivityBuckets[activityType][i] = Group->GetSubgroup("sensor", "UsageByActivity")->GetSubgroup("bin", ToString(i))->GetNamedCounter("activity", bucketName, false);
125+
}
122126
}
123127
}
124128

0 commit comments

Comments
 (0)