File tree Expand file tree Collapse file tree 2 files changed +5
-1
lines changed
ydb/core/tx/columnshard/splitter Expand file tree Collapse file tree 2 files changed +5
-1
lines changed Original file line number Diff line number Diff line change @@ -99,6 +99,8 @@ bool TGeneralSerializedSlice::GroupBlobsImpl(const NSplitter::TGroupFeatures& fe
99
99
chunksInProgress.PopFront (i);
100
100
hasNoSplitChanges = true ;
101
101
} else {
102
+ // in this case chunksInProgress[i] size >= Max - Min for case nextPartSize >= features.GetSplitSettings().GetMaxBlobSize()
103
+ // in this case chunksInProgress[i] size >= Max - 2 * Min for case nextOtherSize < features.GetSplitSettings().GetMinBlobSize()
102
104
Y_ABORT_UNLESS ((i64 )chunksInProgress[i]->GetPackedSize () > features.GetSplitSettings ().GetMinBlobSize () - partSize);
103
105
Y_ABORT_UNLESS (otherSize - (features.GetSplitSettings ().GetMinBlobSize () - partSize) >= features.GetSplitSettings ().GetMinBlobSize ());
104
106
Original file line number Diff line number Diff line change @@ -14,8 +14,10 @@ namespace NKikimr::NOlap::NSplitter {
14
14
15
15
class TSplitSettings {
16
16
private:
17
+ // DefaultMaxBlobSize - 2 * DefaultMinBlobSize have to been enought to "guarantee" records count > 1 through blobs splitting
17
18
static const inline i64 DefaultMaxBlobSize = 8 * 1024 * 1024 ;
18
- static const inline i64 DefaultMinBlobSize = 4 * 1024 * 1024 ;
19
+ static const inline i64 DefaultMinBlobSize = 3 * 1024 * 1024 ;
20
+
19
21
static const inline i64 DefaultMinRecordsCount = 10000 ;
20
22
static const inline i64 DefaultMaxPortionSize = 6 * DefaultMaxBlobSize;
21
23
YDB_ACCESSOR (i64 , MaxBlobSize, DefaultMaxBlobSize);
You can’t perform that action at this time.
0 commit comments