Skip to content

Commit df2c912

Browse files
committed
Added verbose setting
1 parent 7ea8dd3 commit df2c912

File tree

6 files changed

+32
-11
lines changed

6 files changed

+32
-11
lines changed

ydb/tests/tools/kqprun/kqprun.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -649,6 +649,11 @@ class TMain : public TMainClassArgs {
649649
{"each-query", TAsyncQueriesSettings::EVerbose::EachQuery},
650650
{"final", TAsyncQueriesSettings::EVerbose::Final}
651651
});
652+
653+
options.AddLongOption("verbose", "Common verbose level (max level 2)")
654+
.RequiredArgument("uint")
655+
.DefaultValue(1)
656+
.StoreResult(&RunnerOptions.YdbSettings.VerboseLevel);
652657
options.AddLongOption("async-verbose", "Verbose type for async queries")
653658
.RequiredArgument("type")
654659
.DefaultValue("each-query")

ydb/tests/tools/kqprun/src/actors.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,7 @@ class TSessionHolderActor : public NActors::TActorBootstrapped<TSessionHolderAct
299299
TSessionHolderActor(TCreateSessionRequest request, NThreading::TPromise<TString> openPromise, NThreading::TPromise<void> closePromise)
300300
: TargetNode_(request.TargetNode)
301301
, TraceId_(request.Event->Record.GetTraceId())
302+
, VerboseLevel_(request.VerboseLevel)
302303
, Request_(std::move(request.Event))
303304
, OpenPromise_(openPromise)
304305
, ClosePromise_(closePromise)
@@ -317,7 +318,9 @@ class TSessionHolderActor : public NActors::TActorBootstrapped<TSessionHolderAct
317318
}
318319

319320
SessionId_ = response.GetResponse().GetSessionId();
320-
Cout << CoutColors_.Cyan() << "Created new session on node " << TargetNode_ << " with id " << SessionId_ << "\n";
321+
if (VerboseLevel_ >= 1) {
322+
Cout << CoutColors_.Cyan() << "Created new session on node " << TargetNode_ << " with id " << SessionId_ << "\n";
323+
}
321324

322325
PingSession();
323326
}
@@ -393,6 +396,7 @@ class TSessionHolderActor : public NActors::TActorBootstrapped<TSessionHolderAct
393396
private:
394397
const ui32 TargetNode_;
395398
const TString TraceId_;
399+
const ui8 VerboseLevel_;
396400
const NColorizer::TColors CoutColors_ = NColorizer::AutoColors(Cout);
397401

398402
std::unique_ptr<NKikimr::NKqp::TEvKqp::TEvCreateSessionRequest> Request_;

ydb/tests/tools/kqprun/src/actors.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ struct TQueryRequest {
2424
struct TCreateSessionRequest {
2525
std::unique_ptr<NKikimr::NKqp::TEvKqp::TEvCreateSessionRequest> Event;
2626
ui32 TargetNode;
27+
ui8 VerboseLevel;
2728
};
2829

2930
struct TEvPrivate {

ydb/tests/tools/kqprun/src/common.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ struct TYdbSetupSettings {
4646

4747
bool TraceOptEnabled = false;
4848
TString LogOutputFile;
49+
ui8 VerboseLevel = 1;
4950

5051
TString YqlToken;
5152
TIntrusivePtr<NKikimr::NMiniKQL::IMutableFunctionRegistry> FunctionRegistry;

ydb/tests/tools/kqprun/src/kqp_runner.cpp

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ class TKqpRunner::TImpl {
224224
if (Options_.ResultOutput) {
225225
Cout << CoutColors_.Yellow() << TInstant::Now().ToIsoStringLocal() << " Writing script query results..." << CoutColors_.Default() << Endl;
226226
for (size_t i = 0; i < ResultSets_.size(); ++i) {
227-
if (ResultSets_.size() > 1) {
227+
if (ResultSets_.size() > 1 && Options_.YdbSettings.VerboseLevel >= 1) {
228228
*Options_.ResultOutput << CoutColors_.Cyan() << "Result set " << i + 1 << ":" << CoutColors_.Default() << Endl;
229229
}
230230
PrintScriptResult(ResultSets_[i]);
@@ -306,14 +306,18 @@ class TKqpRunner::TImpl {
306306

307307
void PrintSchemeQueryAst(const TString& ast) const {
308308
if (Options_.SchemeQueryAstOutput) {
309-
Cout << CoutColors_.Cyan() << "Writing scheme query ast" << CoutColors_.Default() << Endl;
309+
if (Options_.YdbSettings.VerboseLevel >= 1) {
310+
Cout << CoutColors_.Cyan() << "Writing scheme query ast" << CoutColors_.Default() << Endl;
311+
}
310312
Options_.SchemeQueryAstOutput->Write(ast);
311313
}
312314
}
313315

314316
void PrintScriptAst(size_t queryId, const TString& ast) const {
315317
if (const auto output = GetValue<IOutputStream*>(queryId, Options_.ScriptQueryAstOutputs, nullptr)) {
316-
Cout << CoutColors_.Cyan() << "Writing script query ast" << CoutColors_.Default() << Endl;
318+
if (Options_.YdbSettings.VerboseLevel >= 1) {
319+
Cout << CoutColors_.Cyan() << "Writing script query ast" << CoutColors_.Default() << Endl;
320+
}
317321
output->Write(ast);
318322
}
319323
}
@@ -335,7 +339,9 @@ class TKqpRunner::TImpl {
335339

336340
void PrintScriptPlan(size_t queryId, const TString& plan) const {
337341
if (const auto output = GetValue<IOutputStream*>(queryId, Options_.ScriptQueryPlanOutputs, nullptr)) {
338-
Cout << CoutColors_.Cyan() << "Writing script query plan" << CoutColors_.Default() << Endl;
342+
if (Options_.YdbSettings.VerboseLevel >= 1) {
343+
Cout << CoutColors_.Cyan() << "Writing script query plan" << CoutColors_.Default() << Endl;
344+
}
339345
PrintPlan(plan, output);
340346
}
341347
}
@@ -419,6 +425,9 @@ class TKqpRunner::TImpl {
419425
}
420426

421427
void PrintScriptFinish(const TQueryMeta& meta, const TString& queryType) const {
428+
if (Options_.YdbSettings.VerboseLevel < 1) {
429+
return;
430+
}
422431
Cout << CoutColors_.Cyan() << queryType << " request finished.";
423432
if (meta.TotalDuration) {
424433
Cout << " Total duration: " << meta.TotalDuration;

ydb/tests/tools/kqprun/src/ydb_setup.cpp

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class TStaticSecuredCredentialsFactory : public NYql::ISecuredServiceAccountCred
6565

6666
class TSessionState {
6767
public:
68-
explicit TSessionState(NActors::TTestActorRuntime* runtime, ui32 targetNodeIndex, const TString& database, const TString& traceId)
68+
explicit TSessionState(NActors::TTestActorRuntime* runtime, ui32 targetNodeIndex, const TString& database, const TString& traceId, ui8 verboseLevel)
6969
: Runtime_(runtime)
7070
, TargetNodeIndex_(targetNodeIndex)
7171
{
@@ -78,7 +78,8 @@ class TSessionState {
7878
auto closePromise = NThreading::NewPromise<void>();
7979
SessionHolderActor_ = Runtime_->Register(CreateSessionHolderActor(TCreateSessionRequest{
8080
.Event = std::move(event),
81-
.TargetNode = Runtime_->GetNodeId(targetNodeIndex)
81+
.TargetNode = Runtime_->GetNodeId(targetNodeIndex),
82+
.VerboseLevel = verboseLevel
8283
}, openPromise, closePromise));
8384

8485
SessionId_ = openPromise.GetFuture().GetValueSync();
@@ -210,7 +211,7 @@ class TYdbSetup::TImpl {
210211
serverSettings.SetYtGateway(Settings_.YtGateway);
211212
serverSettings.S3ActorsFactory = NYql::NDq::CreateS3ActorsFactory();
212213
serverSettings.SetInitializeFederatedQuerySetupFactory(true);
213-
serverSettings.SetVerbose(false);
214+
serverSettings.SetVerbose(Settings_.VerboseLevel >= 2);
214215

215216
SetLoggerSettings(serverSettings);
216217
SetFunctionRegistry(serverSettings);
@@ -355,13 +356,13 @@ class TYdbSetup::TImpl {
355356
InitializeServer(grpcPort);
356357
WaitResourcesPublishing();
357358

358-
if (Settings_.MonitoringEnabled) {
359+
if (Settings_.MonitoringEnabled && Settings_.VerboseLevel >= 1) {
359360
for (ui32 nodeIndex = 0; nodeIndex < Settings_.NodeCount; ++nodeIndex) {
360361
Cout << CoutColors_.Cyan() << "Monitoring port" << (Settings_.NodeCount > 1 ? TStringBuilder() << " for node " << nodeIndex + 1 : TString()) << ": " << CoutColors_.Default() << Server_->GetRuntime()->GetMonPort(nodeIndex) << Endl;
361362
}
362363
}
363364

364-
if (Settings_.GrpcEnabled) {
365+
if (Settings_.GrpcEnabled && Settings_.VerboseLevel >= 1) {
365366
Cout << CoutColors_.Cyan() << "Domain gRPC port: " << CoutColors_.Default() << grpcPort << Endl;
366367
}
367368
}
@@ -516,7 +517,7 @@ class TYdbSetup::TImpl {
516517

517518
if (Settings_.SameSession) {
518519
if (!SessionState_) {
519-
SessionState_ = TSessionState(GetRuntime(), targetNodeIndex, database, query.TraceId);
520+
SessionState_ = TSessionState(GetRuntime(), targetNodeIndex, database, query.TraceId, Settings_.VerboseLevel);
520521
}
521522
request->SetSessionId(SessionState_->GetSessionId());
522523
}

0 commit comments

Comments
 (0)