Add security_tags table write hint (#6574)

Author: Vadim Averin

ydb/library/yql/providers/yt/gateway/native/yql_yt_native.cpp

@@ -2157,6 +2157,15 @@ class TYtNativeGateway : public IYtGateway {
             }
         }
 
+        NYT::TNode securityTagsNode;
+        if (strOpts.contains(EYtSettingType::SecurityTags)) {
+            securityTagsNode = NYT::NodeFromYsonString(strOpts.at(EYtSettingType::SecurityTags));
+        }
+
+        if (EYtWriteMode::Append != mode && !securityTagsNode.IsUndefined()) {
+            yqlAttrs[SecurityTagsName] = securityTagsNode;
+        }
+
         const auto userAttrsIt = strOpts.find(EYtSettingType::UserAttrs);
         if (userAttrsIt != strOpts.cend()) {
             const NYT::TNode mapNode = NYT::NodeFromYsonString(userAttrsIt->second);
@@ -2212,7 +2221,8 @@ class TYtNativeGateway : public IYtGateway {
                                     appendToSorted, initial, entry, dstPath, dstEpoch, yqlAttrs, combineChunks,
                                     dstCompressionCodec, dstErasureCodec, dstReplicationFactor, dstMedia, dstPrimaryMedium,
                                     nativeYtTypeCompatibility, publishTx, cluster,
-                                    commitCheckpoint, columnGroupsSpec = std::move(columnGroupsSpec)] (const auto& f) mutable
+                                    commitCheckpoint, columnGroupsSpec = std::move(columnGroupsSpec),
+                                    securityTagsNode] (const auto& f) mutable
             {
                 if (f.GetValue()) {
                     execCtx->QueryCacheItem.Destroy();
@@ -2245,6 +2255,12 @@ class TYtNativeGateway : public IYtGateway {
                     mergeSpec.AddInput(path);
                 }
 
+                NYT::TNode spec = execCtx->Session_->CreateSpecWithDesc();
+
+                if (EYtWriteMode::Append == mode && !securityTagsNode.IsUndefined()) {
+                    spec["additional_security_tags"] = securityTagsNode;
+                }
+
                 auto ytDst = TRichYPath(dstPath);
                 if (EYtWriteMode::Append == mode && !appendToSorted) {
                     ytDst.Append(true);
@@ -2293,7 +2309,6 @@ class TYtNativeGateway : public IYtGateway {
                     mergeSpec.Mode(MM_ORDERED);
                 }
 
-                NYT::TNode spec = execCtx->Session_->CreateSpecWithDesc();
                 EYtOpProps flags = EYtOpProp::PublishedAutoMerge;
                 if (combineChunks) {
                     flags |= EYtOpProp::PublishedChunkCombine;

ydb/library/yql/providers/yt/provider/yql_yt_datasink_type_ann.cpp

@@ -1474,6 +1474,7 @@ class TYtDataSinkTypeAnnotationTransformer : public TVisitorTransformerBase {
             | EYtSettingType::MonotonicKeys
             | EYtSettingType::MutationId
             | EYtSettingType::ColumnGroups
+            | EYtSettingType::SecurityTags
             , ctx))
         {
             return TStatus::Error;
@@ -1746,6 +1747,7 @@ class TYtDataSinkTypeAnnotationTransformer : public TVisitorTransformerBase {
             | EYtSettingType::MonotonicKeys
             | EYtSettingType::MutationId
             | EYtSettingType::ColumnGroups
+            | EYtSettingType::SecurityTags
             , ctx))
         {
             return TStatus::Error;

ydb/library/yql/providers/yt/provider/yql_yt_op_settings.cpp

@@ -869,8 +869,37 @@ bool ValidateSettings(const TExprNode& settingsNode, EYtSettingTypes accepted, T
             }
             break;
         }
+        case EYtSettingType::SecurityTags: {
+            if (!EnsureTupleSize(*setting, 2, ctx)) {
+                return false;
+            }
+            if (!EnsureAtom(setting->Tail(), ctx)) {
+                return false;
+            }
+            NYT::TNode securityTagsNode;
+            try {
+                securityTagsNode = NYT::NodeFromYsonString(setting->Tail().Content());
+            } catch (const std::exception& e) {
+                ctx.AddError(TIssue(ctx.GetPosition(setting->Tail().Pos()), TStringBuilder()
+                    << "Failed to parse Yson: " << e.what()));
+                return false;
+            }
+            if (!securityTagsNode.IsList()) {
+                ctx.AddError(TIssue(ctx.GetPosition(setting->Tail().Pos()), TStringBuilder()
+                    << "Expected YSON list of strings"));
+                return false;
+            }
+            for (const auto &child : securityTagsNode.AsList()) {
+                if (!child.IsString()) {
+                    ctx.AddError(TIssue(ctx.GetPosition(setting->Tail().Pos()), TStringBuilder()
+                        << "Expected YSON list of strings"));
+                    return false;
+                }
+            }
+            return true;
+        }
         case EYtSettingType::LAST: {
-            YQL_ENSURE(false);
+            YQL_ENSURE(false, "Unexpected EYtSettingType");
         }
         }
     }

ydb/library/yql/providers/yt/provider/yql_yt_op_settings.h

@@ -116,6 +116,7 @@ enum class EYtSettingType: ui64 {
     MonotonicKeys            /* "monotonic_keys", "monotonickeys" */,
     MutationId               /* "mutationid", "mutation_id" */,
     ColumnGroups             /* "column_groups", "columngroups" */,
+    SecurityTags             /* "security_tags", "securitytags" */,
 
     LAST
 };