YQ-3836 improved metadata objects errors (#12486)

Author: GrigoriyPA

ydb/core/external_sources/external_data_source.cpp

@@ -17,7 +17,7 @@ struct TExternalDataSource : public IExternalSource {
 
     virtual TString Pack(const NKikimrExternalSources::TSchema&,
                          const NKikimrExternalSources::TGeneral&) const override {
-        ythrow TExternalSourceException() << "Only external table supports pack operation";
+        ythrow TExternalSourceException() << "Internal error. Only external table supports pack operation";
     }
 
     virtual TString GetName() const override {
@@ -33,7 +33,7 @@ struct TExternalDataSource : public IExternalSource {
     }
 
     virtual TMap<TString, TVector<TString>> GetParameters(const TString&) const override {
-        ythrow TExternalSourceException() << "Only external table supports parameters";
+        ythrow TExternalSourceException() << "Internal error. Only external table supports parameters";
     }
 
     bool DataSourceMustHaveDataBaseName(const TProtoStringType& sourceType) const {
@@ -50,16 +50,16 @@ struct TExternalDataSource : public IExternalSource {
             if (AvailableProperties.contains(key)) {
                 continue;
             }
-            ythrow TExternalSourceException() << "Unsupported property: " << key;
+            throw TExternalSourceException() << "Unsupported property: " << key;
         }
 
         if (DataSourceMustHaveDataBaseName(proto.GetSourceType()) && !proto.GetProperties().GetProperties().contains("database_name")) {
-            ythrow TExternalSourceException() << proto.GetSourceType() << " source must provide database_name";
+            throw TExternalSourceException() << proto.GetSourceType() << " source must provide database_name";
         }
 
         // oracle must have property service_name
         if (proto.GetSourceType() == "Oracle" && !proto.GetProperties().GetProperties().contains("service_name")) {
-            ythrow TExternalSourceException() << proto.GetSourceType() << " source must provide service_name";
+            throw TExternalSourceException() << proto.GetSourceType() << " source must provide service_name";
         }
 
         ValidateHostname(HostnamePatterns, proto.GetLocation());

ydb/core/external_sources/external_source_factory.cpp

@@ -23,7 +23,7 @@ struct TExternalSourceFactory : public IExternalSourceFactory {
         if (it != Sources.end()) {
             return it->second;
         }
-        ythrow TExternalSourceException() << "External source with type " << type << " was not found";
+        throw TExternalSourceException() << "External source with type " << type << " was not found";
     }
 
 private:

ydb/core/external_sources/object_storage.cpp

@@ -70,12 +70,12 @@ struct TObjectStorageExternalSource : public IExternalSource {
             } else if (IsIn({"file_pattern"sv, "data.interval.unit"sv, "data.datetime.format_name"sv, "data.datetime.format"sv, "data.timestamp.format_name"sv, "data.timestamp.format"sv, "data.date.format"sv, "csv_delimiter"sv}, lowerKey)) {
                 objectStorage.mutable_format_setting()->insert({lowerKey, value});
             } else {
-                ythrow TExternalSourceException() << "Unknown attribute " << key;
+                throw TExternalSourceException() << "Unknown attribute " << key;
             }
         }
 
         if (auto issues = Validate(schema, objectStorage, PathsLimit, general.location())) {
-            ythrow TExternalSourceException() << issues.ToString();
+            throw TExternalSourceException() << issues.ToString();
         }
 
         return objectStorage.SerializeAsString();
@@ -136,7 +136,7 @@ struct TObjectStorageExternalSource : public IExternalSource {
         }
 
         if (!proto.GetProperties().GetProperties().empty()) {
-            ythrow TExternalSourceException() << "ObjectStorage source doesn't support any properties";
+            throw TExternalSourceException() << "ObjectStorage source doesn't support any properties";
         }
 
         ValidateHostname(HostnamePatterns, proto.GetLocation());
@@ -546,7 +546,7 @@ struct TObjectStorageExternalSource : public IExternalSource {
             if (value.Success()) {
                 return value.Metadata;
             }
-            ythrow TExternalSourceException{} << value.Issues().ToOneLineString();
+            throw TExternalSourceException{} << value.Issues().ToOneLineString();
         });
     }
 

ydb/core/external_sources/validation_functions.cpp

@@ -26,7 +26,7 @@ void ValidateHostname(const std::vector<TRegExMatch>& hostnamePatterns, const TS
         }
     }
 
-    ythrow TExternalSourceException() << "It is not allowed to access hostname '" << hostname << "'";
+    throw TExternalSourceException() << "It is not allowed to access hostname '" << hostname << "'";
 }
 
 }  // NKikimr::NExternalSource