Skip to content

Commit db669ba

Browse files
Removed S3 MaxReadSizePerQuery config (#11936) (#11944)
1 parent 00dabd8 commit db669ba

File tree

6 files changed

+0
-12
lines changed

6 files changed

+0
-12
lines changed

ydb/library/benchmarks/runner/runner/test-gateways.conf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ S3 {
120120
Name: "yq-tpc-local"
121121
Url: "file://./tpc/"
122122
}
123-
MaxReadSizePerQuery: 100000000000
124123
}
125124

126125
HttpGateway {

ydb/library/yql/providers/s3/provider/yql_s3_logical_opt.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -429,12 +429,6 @@ class TS3LogicalOptProposalTransformer : public TOptimizeTransformerBase {
429429
return TStatus::Error;
430430
}
431431

432-
const auto maxSize = State_->Configuration->MaxReadSizePerQuery;
433-
if (totalSize > maxSize) {
434-
ctx.AddError(TIssue(ctx.GetPosition(input->Pos()), TStringBuilder() << "Too large objects to read: " << totalSize << ", but limit is " << maxSize));
435-
return TStatus::Error;
436-
}
437-
438432
if (count > 0) {
439433
YQL_CLOG(INFO, ProviderS3) << "Will read from S3 " << count << " files with total size " << totalSize << " bytes";
440434
}

ydb/library/yql/providers/s3/provider/yql_s3_settings.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ void TS3Configuration::Init(const TS3GatewayConfig& config, TIntrusivePtr<TTypeA
6060
config.HasMinDesiredDirectoriesOfFilesPerQuery()
6161
? config.GetMinDesiredDirectoriesOfFilesPerQuery()
6262
: 100;
63-
MaxReadSizePerQuery =
64-
config.HasMaxReadSizePerQuery() ? config.GetMaxReadSizePerQuery() : 4_GB;
6563
MaxInflightListsPerQuery =
6664
config.HasMaxInflightListsPerQuery() ? config.GetMaxInflightListsPerQuery() : 1;
6765
ListingCallbackThreadCount = config.HasListingCallbackThreadCount()

ydb/library/yql/providers/s3/provider/yql_s3_settings.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ struct TS3Configuration : public TS3Settings, public NCommon::TSettingDispatcher
5959
ui64 MaxDiscoveryFilesPerQuery = 0;
6060
ui64 MaxDirectoriesAndFilesPerQuery = 0;
6161
ui64 MinDesiredDirectoriesOfFilesPerQuery = 0;
62-
ui64 MaxReadSizePerQuery = 0;
6362
ui64 MaxInflightListsPerQuery = 0;
6463
ui64 ListingCallbackThreadCount = 0;
6564
ui64 ListingCallbackPerThreadQueueSize = 0;

ydb/library/yql/tools/dqrun/examples/gateways.conf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ S3 {
108108
Name: "yq-tpc-local"
109109
Url: "file://./tpc/"
110110
}
111-
MaxReadSizePerQuery: 100000000000
112111
}
113112

114113
HttpGateway {

ydb/tests/tools/kqprun/configuration/app_config.conf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ QueryServiceConfig {
7171
MaxDiscoveryFilesPerQuery: 1000
7272
MaxFilesPerQuery: 500000
7373
MaxInflightListsPerQuery: 100
74-
MaxReadSizePerQuery: 1000000000000
7574
MinDesiredDirectoriesOfFilesPerQuery: 1000
7675
RegexpCacheSize: 100
7776

0 commit comments

Comments
 (0)