Skip to content

Commit d7a78d0

Browse files
authored
Fix CLI max partitions default (#8944)
1 parent ec1d588 commit d7a78d0

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

ydb/public/lib/ydb_cli/commands/ydb_service_topic.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,7 @@ namespace {
304304

305305
config.Opts->AddLongOption("auto-partitioning-max-partitions-count", "Maximum number of partitions for topic")
306306
.Optional()
307-
.StoreResult(&MaxActivePartitions_)
308-
.DefaultValue(1);
307+
.StoreResult(&MaxActivePartitions_);
309308
AddAutoPartitioning(config, false);
310309
}
311310

@@ -329,7 +328,11 @@ namespace {
329328
GetAutoPartitioningUpUtilizationPercent() ? *GetAutoPartitioningUpUtilizationPercent() : 0,
330329
GetAutoPartitioninDownUtilizationPercent() ? *GetAutoPartitioninDownUtilizationPercent() : 0);
331330

332-
settings.PartitioningSettings(MinActivePartitions_, MaxActivePartitions_, autoscaleSettings);
331+
ui32 finalMaxActivePartitions = MaxActivePartitions_.Defined() ? *MaxActivePartitions_
332+
: autoscaleSettings.GetStrategy() != NTopic::EAutoPartitioningStrategy::Disabled ? MinActivePartitions_ + 50
333+
: MinActivePartitions_;
334+
335+
settings.PartitioningSettings(MinActivePartitions_, finalMaxActivePartitions, autoscaleSettings);
333336
settings.PartitionWriteBurstBytes(PartitionWriteSpeedKbps_ * 1_KB);
334337
settings.PartitionWriteSpeedBytesPerSecond(PartitionWriteSpeedKbps_ * 1_KB);
335338

ydb/public/lib/ydb_cli/commands/ydb_service_topic.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ namespace NYdb::NConsoleClient {
7171
ui64 RetentionPeriodHours_;
7272
ui64 RetentionStorageMb_;
7373
ui32 MinActivePartitions_;
74-
ui32 MaxActivePartitions_;
75-
74+
TMaybe<ui32> MaxActivePartitions_;
7675
ui32 PartitionWriteSpeedKbps_;
7776
};
7877

0 commit comments

Comments
 (0)