Skip to content

Commit d70ac47

Browse files
authored
Enable transaction and autopartitioning for topics by default (#12674)
1 parent 5ba6c34 commit d70ac47

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

.github/config/muted_ya.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ ydb/public/sdk/cpp/client/ydb_topic/ut [*/*]+chunk+chunk
8282
ydb/services/datastreams/ut DataStreams.TestPutRecordsCornerCases
8383
ydb/services/keyvalue/ut sole chunk chunk
8484
ydb/services/keyvalue/ut sole+chunk+chunk
85+
ydb/services/persqueue_v1/ut TPersQueueCommonTest.TestLimiterLimitsWithBlobsRateLimit
86+
ydb/services/persqueue_v1/ut TPersQueueCommonTest.TestLimiterLimitsWithUserPayloadRateLimit
8587
ydb/services/ydb/sdk_sessions_pool_ut YdbSdkSessionsPool.StressTestSync1
8688
ydb/services/ydb/sdk_sessions_pool_ut YdbSdkSessionsPool.StressTestSync10
8789
ydb/services/ydb/sdk_sessions_ut [*/*] chunk chunk

ydb/core/kafka_proxy/ut/ut_protocol.cpp

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1250,10 +1250,17 @@ Y_UNIT_TEST_SUITE(KafkaProtocol) {
12501250
UNIT_ASSERT_EQUAL(upsertResult.GetStatus(), EStatus::SUCCESS);
12511251
}
12521252

1253-
{
1253+
for (size_t i = 10; i--;){
12541254
// Check CDC
12551255
std::vector<std::pair<TString, std::vector<i32>>> topics {{feedPath, {0}}};
12561256
auto msg = client.Fetch(topics);
1257+
1258+
if (msg->Responses.empty() || msg->Responses[0].Partitions.empty() || !msg->Responses[0].Partitions[0].Records.has_value()) {
1259+
UNIT_ASSERT_C(i, "Timeout");
1260+
Sleep(TDuration::Seconds(1));
1261+
continue;
1262+
}
1263+
12571264
UNIT_ASSERT_VALUES_EQUAL(msg->Responses.size(), 1);
12581265
UNIT_ASSERT_VALUES_EQUAL(msg->Responses[0].Partitions.size(), 1);
12591266
UNIT_ASSERT_VALUES_EQUAL(msg->Responses[0].Partitions[0].ErrorCode, static_cast<TKafkaInt16>(EKafkaErrors::NONE_ERROR));
@@ -1264,6 +1271,8 @@ Y_UNIT_TEST_SUITE(KafkaProtocol) {
12641271
auto data = record.Value.value();
12651272
auto dataStr = TString(data.data(), data.size());
12661273
UNIT_ASSERT_VALUES_EQUAL(dataStr, "{\"update\":{\"value\":2},\"key\":[1]}");
1274+
1275+
break;
12671276
}
12681277

12691278
} // Y_UNIT_TEST(FetchScenario)

ydb/core/protos/feature_flags.proto

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,16 @@ message TFeatureFlags {
108108
reserved 83; // EnableKqpDataQuerySourceRead
109109
optional bool EnableSmallDiskOptimization = 84 [default = true];
110110
optional bool EnableDataShardVolatileTransactions = 85 [default = true];
111-
optional bool EnableTopicServiceTx = 86 [default = false];
111+
optional bool EnableTopicServiceTx = 86 [default = true];
112112
optional bool EnableLLVMCache = 87 [default = false];
113113
optional bool EnableExternalDataSources = 88 [default = false];
114114
optional bool EnableTopicDiskSubDomainQuota = 89 [default = true, (RequireRestart) = true];
115115
optional bool EnableSeparationComputeActorsFromRead = 90 [default = true];
116-
optional bool EnablePQConfigTransactionsAtSchemeShard = 91 [default = false];
116+
optional bool EnablePQConfigTransactionsAtSchemeShard = 91 [default = true];
117117
optional bool EnableScriptExecutionOperations = 92 [default = true];
118118
optional bool EnableImplicitQueryParameterTypes = 93 [default = true];
119119
optional bool EnableForceImmediateEffectsExecution = 94 [default = false];
120-
optional bool EnableTopicSplitMerge = 95 [default = false];
120+
optional bool EnableTopicSplitMerge = 95 [default = true];
121121
optional bool EnableChangefeedDynamoDBStreamsFormat = 96 [default = true];
122122
optional bool ForceColumnTablesCompositeMarks = 97 [default = false];
123123
optional bool EnableSubscriptionsInDiscovery = 98 [default = false, (RequireRestart) = true];

0 commit comments

Comments
 (0)