Extract methods to format records with rows (#19141)

Author: kunga

ydb/core/base/table_index.cpp

@@ -1,6 +1,7 @@
 #include "table_index.h"
 
 #include <ydb/core/base/table_vector_index.h>
+#include <ydb/core/protos/tx_datashard.pb.h>
 
 namespace NKikimr::NTableIndex {
 namespace {
@@ -201,4 +202,24 @@ TClusterId SetPostingParentFlag(TClusterId parent) {
     return (parent | PostingParentFlag);
 }
 
+TString ToShortDebugString(const NKikimrTxDataShard::TEvReshuffleKMeansRequest& record) {
+    auto copy = record;
+    TStringBuilder result;
+    // clusters are not human readable and can be large like 100Kb+
+    copy.ClearClusters();
+    result << copy.ShortDebugString();
+    result << " Clusters: " << record.ClustersSize();
+    return result;
+}
+
+TString ToShortDebugString(const NKikimrTxDataShard::TEvSampleKResponse& record) {
+    auto copy = record;
+    TStringBuilder result;
+    // rows are not human readable and can be large like 100Kb+
+    copy.ClearRows();
+    result << copy.ShortDebugString();
+    result << " Rows: " << record.RowsSize();
+    return result;
+}
+
 }

ydb/core/base/table_index.h

@@ -12,6 +12,11 @@
 #include <span>
 #include <string_view>
 
+namespace NKikimrTxDataShard {
+    class TEvReshuffleKMeansRequest;
+    class TEvSampleKResponse;
+}
+
 namespace NKikimr {
 
 inline constexpr const char* SYSTEM_COLUMN_PREFIX = "__ydb_";
@@ -45,5 +50,8 @@ void EnsureNoPostingParentFlag(TClusterId parent);
 
 TClusterId SetPostingParentFlag(TClusterId parent);
 
+TString ToShortDebugString(const NKikimrTxDataShard::TEvReshuffleKMeansRequest& record);
+TString ToShortDebugString(const NKikimrTxDataShard::TEvSampleKResponse& record);
+
 }
 }

ydb/core/tx/datashard/build_index/reshuffle_kmeans.cpp

@@ -363,7 +363,7 @@ void TDataShard::HandleSafe(TEvDataShard::TEvReshuffleKMeansRequest::TPtr& ev, c
         response->Record.SetRequestSeqNoRound(seqNo.Round);
 
         LOG_N("Starting TReshuffleKMeansScan TabletId: " << TabletID() 
-            << " " << request.ShortDebugString()
+            << " " << ToShortDebugString(request)
             << " row version " << rowVersion);
 
         // Note: it's very unlikely that we have volatile txs before this snapshot
@@ -381,7 +381,7 @@ void TDataShard::HandleSafe(TEvDataShard::TEvReshuffleKMeansRequest::TPtr& ev, c
         auto trySendBadRequest = [&] {
             if (response->Record.GetStatus() == NKikimrIndexBuilder::EBuildStatus::BAD_REQUEST) {
                 LOG_E("Rejecting TReshuffleKMeansScan bad request TabletId: " << TabletID()
-                    << " " << request.ShortDebugString()
+                    << " " << ToShortDebugString(request)
                     << " with response " << response->Record.ShortDebugString());
                 ctx.Send(ev->Sender, std::move(response));
                 return true;

ydb/core/tx/datashard/build_index/sample_k.cpp

@@ -163,9 +163,9 @@ class TSampleKScan final: public TActor<TSampleKScan>, public NTable::IScan {
         NYql::IssuesToMessage(Issues, record.MutableIssues());
 
         if (Response->Record.GetStatus() == NKikimrIndexBuilder::DONE) {
-            LOG_N("Done " << Debug() << " " << Response->Record.ShortDebugString());
+            LOG_N("Done " << Debug() << " " << ToShortDebugString(Response->Record));
         } else {
-            LOG_E("Failed " << Debug() << " " << Response->Record.ShortDebugString());
+            LOG_E("Failed " << Debug() << " " << ToShortDebugString(Response->Record));
         }
         Send(ResponseActorId, Response.Release());
 
@@ -265,7 +265,7 @@ void TDataShard::HandleSafe(TEvDataShard::TEvSampleKRequest::TPtr& ev, const TAc
             if (response->Record.GetStatus() == NKikimrIndexBuilder::EBuildStatus::BAD_REQUEST) {
                 LOG_E("Rejecting TSampleKScan bad request TabletId: " << TabletID()
                     << " " << request.ShortDebugString()
-                    << " with response " << response->Record.ShortDebugString());
+                    << " with response " << ToShortDebugString(response->Record));
                 ctx.Send(ev->Sender, std::move(response));
                 return true;
             } else {

ydb/core/tx/schemeshard/schemeshard_build_index__progress.cpp

@@ -605,13 +605,7 @@ struct TSchemeShard::TIndexBuilder::TTxProgress: public TSchemeShard::TIndexBuil
         };
 
         auto shardId = CommonFillRecord(ev->Record, shardIdx, buildInfo);
-        [[maybe_unused]] auto toDebugStr = [&](const NKikimrTxDataShard::TEvReshuffleKMeansRequest& record) {
-            auto r = record;
-            // clusters are not human readable and can be large like 100Kb+
-            r.ClearClusters();
-            return r.ShortDebugString();
-        };
-        LOG_N("TTxBuildProgress: TEvReshuffleKMeansRequest: " << toDebugStr(ev->Record));
+        LOG_N("TTxBuildProgress: TEvReshuffleKMeansRequest: " << ToShortDebugString(ev->Record));
 
         ToTabletSend.emplace(shardId, std::move(ev));
     }
@@ -1566,15 +1560,9 @@ struct TSchemeShard::TIndexBuilder::TTxReplySampleK: public TSchemeShard::TIndex
             return true;
         }
         auto& buildInfo = *buildInfoPtr->Get();
-        [[maybe_unused]] auto toDebugStr = [&](const NKikimrTxDataShard::TEvSampleKResponse& record) {
-            auto r = record;
-            // rows are not human readable and can be large like 100Kb+
-            r.ClearRows();
-            return r.ShortDebugString();
-        };
         LOG_D("TTxReply : TEvSampleKResponse"
               << ", TIndexBuildInfo: " << buildInfo
-              << ", record: " << toDebugStr(record));
+              << ", record: " << ToShortDebugString(record));
 
         TTabletId shardId = TTabletId(record.GetTabletId());
         if (!Self->TabletIdToShardIdx.contains(shardId)) {