Skip to content

Commit d12d1cb

Browse files
authored
Check status of TEvPutResult (#7579)
1 parent c50a8f8 commit d12d1cb

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

ydb/core/load_test/group_write.cpp

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,8 @@ class TLogWriterLoadTestActor : public TActorBootstrapped<TLogWriterLoadTestActo
393393
TRequestDispatchingSettings WriteSettings;
394394
TMonotonic NextWriteTimestamp;
395395
ui64 TotalBytesWritten = 0;
396+
ui64 OkPutResults = 0;
397+
ui64 BadPutResults = 0;
396398
THashMap<ui64, ui64> SentTimestamp;
397399
ui64 WriteQueryId = 0;
398400
bool NextWriteInQueue = false;
@@ -641,7 +643,7 @@ class TLogWriterLoadTestActor : public TActorBootstrapped<TLogWriterLoadTestActo
641643
auto *res = dynamic_cast<TEvBlobStorage::TEvPutResult*>(event);
642644
Y_ABORT_UNLESS(res);
643645

644-
InitialAllocation.ConfirmBlob(res->Id, CheckStatus(ctx, res, {}));
646+
InitialAllocation.ConfirmBlob(res->Id, CheckStatus(ctx, res, {NKikimrProto::EReplyStatus::OK}));
645647
while (InitialAllocation.CanSendRequest()) {
646648
IssueInitialPut(ctx);
647649
}
@@ -784,6 +786,8 @@ class TLogWriterLoadTestActor : public TActorBootstrapped<TLogWriterLoadTestActo
784786
DUMP_PARAM(NextWriteTimestamp)
785787
DUMP_PARAM(WriteSettings.InFlightTracker.ToString())
786788
DUMP_PARAM_FINAL(TotalBytesWritten)
789+
DUMP_PARAM_FINAL(OkPutResults)
790+
DUMP_PARAM_FINAL(BadPutResults)
787791
DUMP_PARAM_FINAL(WriteSettings.MaxTotalBytes)
788792
DUMP_PARAM_FINAL(TotalBytesRead)
789793
DUMP_PARAM(NextReadTimestamp)
@@ -888,24 +892,25 @@ class TLogWriterLoadTestActor : public TActorBootstrapped<TLogWriterLoadTestActo
888892
Y_ABORT_UNLESS(res);
889893

890894
WriteSettings.DelayManager->CountResponse();
891-
if (!CheckStatus(ctx, res, {})) {
892-
return;
893-
}
895+
const bool ok = CheckStatus(ctx, res, {NKikimrProto::EReplyStatus::OK});
896+
++ (ok ? OkPutResults : BadPutResults);
894897

895898
const TLogoBlobID& id = res->Id;
896899
const ui32 size = id.BlobSize();
897900

898-
// this blob has been confirmed -- update set
899-
if (!ConfirmedBlobIds || id > ConfirmedBlobIds.back()) {
900-
ConfirmedBlobIds.push_back(id);
901-
} else {
902-
// most likely inserted somewhere near the end
903-
ConfirmedBlobIds.insert(std::lower_bound(ConfirmedBlobIds.begin(), ConfirmedBlobIds.end(), id), id);
901+
if (ok) {
902+
// this blob has been confirmed -- update set
903+
if (!ConfirmedBlobIds || id > ConfirmedBlobIds.back()) {
904+
ConfirmedBlobIds.push_back(id);
905+
} else {
906+
// most likely inserted somewhere near the end
907+
ConfirmedBlobIds.insert(std::lower_bound(ConfirmedBlobIds.begin(), ConfirmedBlobIds.end(), id), id);
908+
}
909+
TotalBytesWritten += size;
904910
}
905911

906912
WriteSettings.InFlightTracker.Response(size);
907913

908-
TotalBytesWritten += size;
909914

910915
auto it = SentTimestamp.find(writeQueryId);
911916
const auto sendCycles = it->second;

0 commit comments

Comments
 (0)