Fix some issues from coverity in ActorSystem (#12831)

Author: kruall

ydb/library/actors/core/executor_pool_basic.cpp

@@ -216,8 +216,8 @@ namespace NActors {
             Harmonizer->Harmonize(hpnow);
         }
 
-        TAtomic x = AtomicGet(Semaphore);
-        TSemaphore semaphore = TSemaphore::GetSemaphore(x);
+        TAtomic semaphoreRaw = AtomicGet(Semaphore);
+        TSemaphore semaphore = TSemaphore::GetSemaphore(semaphoreRaw);
         while (!StopFlag.load(std::memory_order_acquire)) {
             if (!semaphore.OldSemaphore || workerId >= 0 && semaphore.CurrentSleepThreadCount < 0) {
                 if (workerId < 0 || !wctx.IsNeededToWaitNextActivation) {
@@ -234,7 +234,7 @@ namespace NActors {
                 }
             } else {
                 TInternalActorTypeGuard<EInternalActorSystemActivity::ACTOR_SYSTEM_GET_ACTIVATION_FROM_QUEUE, false> activityGuard;
-                if (const ui32 activation = std::visit([&revolvingCounter](auto &x) {return x.Pop(++revolvingCounter);}, Activations)) {
+                if (const ui32 activation = std::visit([&revolvingCounter](auto &queue) {return queue.Pop(++revolvingCounter);}, Activations)) {
                     if (workerId >= 0) {
                         Threads[workerId].SetWork();
                     } else {
@@ -247,8 +247,8 @@ namespace NActors {
             }
 
             SpinLockPause();
-            x = AtomicGet(Semaphore);
-            semaphore = TSemaphore::GetSemaphore(x);
+            semaphoreRaw = AtomicGet(Semaphore);
+            semaphore = TSemaphore::GetSemaphore(semaphoreRaw);
         }
 
         return nullptr;

ydb/library/actors/core/executor_pool_io.cpp

@@ -34,8 +34,8 @@ namespace NActors {
         i16 workerId = wctx.WorkerId;
         Y_DEBUG_ABORT_UNLESS(workerId < PoolThreads);
 
-        const TAtomic x = AtomicDecrement(Semaphore);
-        if (x < 0) {
+        const TAtomic semaphoreRaw = AtomicDecrement(Semaphore);
+        if (semaphoreRaw < 0) {
             TExecutorThreadCtx& threadCtx = Threads[workerId];
             ThreadQueue.Push(workerId + 1, revolvingCounter);
 
@@ -54,7 +54,7 @@ namespace NActors {
         }
 
         while (!StopFlag.load(std::memory_order_acquire)) {
-            if (const ui32 activation = std::visit([&revolvingCounter](auto &x){return x.Pop(++revolvingCounter);}, Activations)) {
+            if (const ui32 activation = std::visit([&revolvingCounter](auto &queue){return queue.Pop(++revolvingCounter);}, Activations)) {
                 return MailboxTable->Get(activation);
             }
             SpinLockPause();
@@ -87,14 +87,14 @@ namespace NActors {
     }
 
     void TIOExecutorPool::ScheduleActivationEx(TMailbox* mailbox, ui64 revolvingWriteCounter) {
-        std::visit([mailbox, revolvingWriteCounter](auto &x) {
-            x.Push(mailbox->Hint, revolvingWriteCounter);
+        std::visit([mailbox, revolvingWriteCounter](auto &queue) {
+            queue.Push(mailbox->Hint, revolvingWriteCounter);
         }, Activations);
-        const TAtomic x = AtomicIncrement(Semaphore);
-        if (x <= 0) {
+        const TAtomic semaphoreRaw = AtomicIncrement(Semaphore);
+        if (semaphoreRaw <= 0) {
             for (;; ++revolvingWriteCounter) {
-                if (const ui32 x = ThreadQueue.Pop(revolvingWriteCounter)) {
-                    const ui32 threadIdx = x - 1;
+                if (const ui32 threadId = ThreadQueue.Pop(revolvingWriteCounter)) {
+                    const ui32 threadIdx = threadId - 1;
                     Threads[threadIdx].WaitingPad.Unpark();
                     return;
                 }

ydb/library/actors/core/harmonizer/cpu_consumption.cpp

@@ -38,7 +38,7 @@ namespace {
             poolConsumption->LastSecondCpu += threadLastSecondCpu;
             LWPROBE_WITH_DEBUG(HarmonizeCheckPoolByThread, pool.Pool->PoolId, pool.Pool->GetName(), threadIdx, threadElapsed, threadCpu, threadLastSecondElapsed, threadLastSecondCpu);
         }
-        for (ui32 sharedIdx = 0; sharedIdx < pool.SharedInfo.size(); ++sharedIdx) {
+        for (i16 sharedIdx = 0; sharedIdx < static_cast<i16>(pool.SharedInfo.size()); ++sharedIdx) {
             float sharedElapsed = Rescale(pool.GetSharedElapsed(sharedIdx));
             float sharedLastSecondElapsed = Rescale(pool.GetLastSecondSharedElapsed(sharedIdx));
             float sharedCpu = Rescale(pool.GetSharedCpu(sharedIdx));