Skip to content

Commit c15923e

Browse files
authored
Add chatty logging to cluster & database dump/restore (#14582)
1 parent a539b17 commit c15923e

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed

ydb/public/lib/ydb_cli/commands/ydb_admin.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ void TCommandDatabaseDump::Parse(TConfig& config) {
5454
}
5555

5656
int TCommandDatabaseDump::Run(TConfig& config) {
57-
auto log = std::make_shared<TLog>(CreateLogBackend("cerr", TConfig::VerbosityLevelToELogPriority(config.VerbosityLevel)));
57+
auto log = std::make_shared<TLog>(CreateLogBackend("cerr", TConfig::VerbosityLevelToELogPriorityChatty(config.VerbosityLevel)));
5858
log->SetFormatter(GetPrefixLogFormatter(""));
5959

6060
NDump::TClient client(CreateDriver(config), std::move(log));
@@ -87,7 +87,7 @@ void TCommandDatabaseRestore::Parse(TConfig& config) {
8787
}
8888

8989
int TCommandDatabaseRestore::Run(TConfig& config) {
90-
auto log = std::make_shared<TLog>(CreateLogBackend("cerr", TConfig::VerbosityLevelToELogPriority(config.VerbosityLevel)));
90+
auto log = std::make_shared<TLog>(CreateLogBackend("cerr", TConfig::VerbosityLevelToELogPriorityChatty(config.VerbosityLevel)));
9191
log->SetFormatter(GetPrefixLogFormatter(""));
9292

9393
auto settings = NDump::TRestoreDatabaseSettings()

ydb/public/lib/ydb_cli/commands/ydb_cluster.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ void TCommandClusterDump::Parse(TConfig& config) {
6666
}
6767

6868
int TCommandClusterDump::Run(TConfig& config) {
69-
auto log = std::make_shared<TLog>(CreateLogBackend("cerr", TConfig::VerbosityLevelToELogPriority(config.VerbosityLevel)));
69+
auto log = std::make_shared<TLog>(CreateLogBackend("cerr", TConfig::VerbosityLevelToELogPriorityChatty(config.VerbosityLevel)));
7070
log->SetFormatter(GetPrefixLogFormatter(""));
7171

7272
NDump::TClient client(CreateDriver(config), std::move(log));
@@ -99,7 +99,7 @@ void TCommandClusterRestore::Parse(TConfig& config) {
9999
}
100100

101101
int TCommandClusterRestore::Run(TConfig& config) {
102-
auto log = std::make_shared<TLog>(CreateLogBackend("cerr", TConfig::VerbosityLevelToELogPriority(config.VerbosityLevel)));
102+
auto log = std::make_shared<TLog>(CreateLogBackend("cerr", TConfig::VerbosityLevelToELogPriorityChatty(config.VerbosityLevel)));
103103
log->SetFormatter(GetPrefixLogFormatter(""));
104104

105105
auto settings = NDump::TRestoreClusterSettings()

ydb/public/lib/ydb_cli/common/command.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,18 @@ ELogPriority TClientCommand::TConfig::VerbosityLevelToELogPriority(TClientComman
4747
}
4848
}
4949

50+
ELogPriority TClientCommand::TConfig::VerbosityLevelToELogPriorityChatty(TClientCommand::TConfig::EVerbosityLevel lvl) {
51+
switch (lvl) {
52+
case TClientCommand::TConfig::EVerbosityLevel::NONE:
53+
return ELogPriority::TLOG_INFO;
54+
case TClientCommand::TConfig::EVerbosityLevel::DEBUG:
55+
case TClientCommand::TConfig::EVerbosityLevel::INFO:
56+
case TClientCommand::TConfig::EVerbosityLevel::WARN:
57+
return ELogPriority::TLOG_DEBUG;
58+
}
59+
return ELogPriority::TLOG_INFO;
60+
}
61+
5062
size_t TClientCommand::TConfig::ParseHelpCommandVerbosilty(int argc, char** argv) {
5163
size_t cnt = 0;
5264
for (int i = 0; i < argc; ++i) {

ydb/public/lib/ydb_cli/common/command.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ class TClientCommand {
9191
};
9292

9393
static ELogPriority VerbosityLevelToELogPriority(EVerbosityLevel lvl);
94+
static ELogPriority VerbosityLevelToELogPriorityChatty(EVerbosityLevel lvl);
9495

9596
int ArgC;
9697
char** ArgV;

0 commit comments

Comments
 (0)