YT-25440: Fix buffer allocation for bus

commit_hash:7a37d7700029422ce438efdb476e76f3d522f6c9

Author: don-dron

yt/yt/core/bus/tcp/client.cpp

@@ -201,7 +201,7 @@ class TTcpBusClient
             std::move(poller),
             PacketTranscoderFactory_,
             MemoryUsageTracker_,
-            DynamicConfig_.Acquire()->NeedRejectConnectionOnMemoryOvercommit);
+            DynamicConfig_.Acquire()->RejectConnectionOnMemoryOvercommit);
         connection->Start();
 
         return New<TTcpClientBusProxy>(std::move(connection));

yt/yt/core/bus/tcp/config.cpp

@@ -169,7 +169,7 @@ void TBusConfig::Register(TRegistrar registrar)
 
 void TBusDynamicConfig::Register(TRegistrar registrar)
 {
-    registrar.Parameter("need_reject_connection_on_memory_overcommit", &TThis::NeedRejectConnectionOnMemoryOvercommit)
+    registrar.Parameter("reject_connection_on_memory_overcommit", &TThis::RejectConnectionOnMemoryOvercommit)
         .Default(false);
 }
 

yt/yt/core/bus/tcp/config.h

@@ -127,7 +127,7 @@ DEFINE_REFCOUNTED_TYPE(TBusConfig)
 struct TBusDynamicConfig
     : public NYTree::TYsonStruct
 {
-    bool NeedRejectConnectionOnMemoryOvercommit;
+    bool RejectConnectionOnMemoryOvercommit;
 
     REGISTER_YSON_STRUCT(TBusDynamicConfig);
 

yt/yt/core/bus/tcp/connection.cpp

@@ -115,7 +115,7 @@ TTcpConnection::TTcpConnection(
     IPollerPtr poller,
     IPacketTranscoderFactory* packetTranscoderFactory,
     IMemoryUsageTrackerPtr memoryUsageTracker,
-    bool needRejectConnectionOnMemoryOvercommit)
+    bool rejectConnectionOnMemoryOvercommit)
     : Config_(std::move(config))
     , ConnectionType_(connectionType)
     , Id_(id)
@@ -140,7 +140,7 @@ TTcpConnection::TTcpConnection(
     , EncryptionMode_(Config_->EncryptionMode)
     , VerificationMode_(Config_->VerificationMode)
     , MemoryUsageTracker_(std::move(memoryUsageTracker))
-    , NeedRejectConnectionOnMemoryOvercommit_(needRejectConnectionOnMemoryOvercommit)
+    , RejectConnectionOnMemoryOvercommit_(rejectConnectionOnMemoryOvercommit)
 { }
 
 TTcpConnection::~TTcpConnection()
@@ -587,19 +587,26 @@ void TTcpConnection::InitBuffers()
         ConnectionType_ == EConnectionType::Server
             ? GetRefCountedTypeCookie<TTcpServerConnectionReadBufferTag>()
             : GetRefCountedTypeCookie<TTcpClientConnectionReadBufferTag>());
-    ReadBuffer_
-        .TryResize(
+
+    if (RejectConnectionOnMemoryOvercommit_) {
+        ReadBuffer_
+            .TryResize(
+                ReadBufferSize,
+                /*initializeStorage*/ false)
+            .ThrowOnError();
+    } else {
+        ReadBuffer_.Resize(
             ReadBufferSize,
-            /*initializeStorage*/ false)
-        .ThrowOnError();
+            /*initializeStorage*/ false);
+    }
 
     auto trackedBlob = TMemoryTrackedBlob::Build(
         MemoryUsageTracker_,
         ConnectionType_ == EConnectionType::Server
             ? GetRefCountedTypeCookie<TTcpServerConnectionWriteBufferTag>()
             : GetRefCountedTypeCookie<TTcpClientConnectionWriteBufferTag>());
 
-    if (NeedRejectConnectionOnMemoryOvercommit_) {
+    if (RejectConnectionOnMemoryOvercommit_) {
         trackedBlob
             .TryReserve(WriteBufferSize)
             .ThrowOnError();

yt/yt/core/bus/tcp/connection.h

@@ -89,7 +89,7 @@ class TTcpConnection
         NConcurrency::IPollerPtr poller,
         IPacketTranscoderFactory* packetTranscoderFactory,
         IMemoryUsageTrackerPtr memoryUsageTracker,
-        bool needRejectConnectionOnMemoryOvercommit);
+        bool rejectConnectionOnMemoryOvercommit);
 
     ~TTcpConnection();
 
@@ -280,7 +280,7 @@ class TTcpConnection
     const EVerificationMode VerificationMode_;
 
     const IMemoryUsageTrackerPtr MemoryUsageTracker_;
-    const bool NeedRejectConnectionOnMemoryOvercommit_;
+    const bool RejectConnectionOnMemoryOvercommit_;
 
     NYTree::IAttributeDictionaryPtr PeerAttributes_;
 

yt/yt/core/bus/tcp/server.cpp

@@ -277,7 +277,7 @@ class TTcpBusServerBase
                 std::move(poller),
                 PacketTranscoderFactory_,
                 MemoryUsageTracker_,
-                DynamicConfig_.Acquire()->NeedRejectConnectionOnMemoryOvercommit);
+                DynamicConfig_.Acquire()->RejectConnectionOnMemoryOvercommit);
 
             {
                 auto guard = WriterGuard(ConnectionsSpinLock_);