Skip to content

Commit af48ba2

Browse files
author
vadim-xd
committed
Make NMonitoring::IHistogram write methods noexcept
commit_hash:e67a69864ab541f86bd413dfa8df106a77d05b71
1 parent e2a808c commit af48ba2

File tree

6 files changed

+18
-18
lines changed

6 files changed

+18
-18
lines changed

library/cpp/monlib/metrics/fake.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,11 @@ namespace NMonitoring {
131131
{
132132
}
133133

134-
void Record(double value) override {
134+
void Record(double value) noexcept override {
135135
Y_UNUSED(value);
136136
}
137137

138-
void Record(double value, ui32 count) override {
138+
void Record(double value, ui32 count) noexcept override {
139139
Y_UNUSED(value, count);
140140
}
141141

@@ -147,7 +147,7 @@ namespace NMonitoring {
147147
Y_UNUSED(time, consumer);
148148
}
149149

150-
void Reset() override {
150+
void Reset() noexcept override {
151151
}
152152
};
153153

library/cpp/monlib/metrics/histogram_collector.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ namespace NMonitoring {
1414
/**
1515
* Store {@code count} times given {@code value} in this collector.
1616
*/
17-
virtual void Collect(double value, ui64 count) = 0;
17+
virtual void Collect(double value, ui64 count) noexcept = 0;
1818

1919
/**
2020
* Store given {@code value} in this collector.
2121
*/
22-
void Collect(double value) {
22+
void Collect(double value) noexcept {
2323
Collect(value, 1);
2424
}
2525

@@ -35,7 +35,7 @@ namespace NMonitoring {
3535
/**
3636
* Reset collector values
3737
*/
38-
virtual void Reset() = 0;
38+
virtual void Reset() noexcept = 0;
3939

4040
/**
4141
* @return snapshot of the state of this collector.

library/cpp/monlib/metrics/histogram_collector_explicit.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ namespace NMonitoring {
2121
Bounds_.push_back(Max<TBucketBound>());
2222
}
2323

24-
void Collect(double value, ui64 count) override {
24+
void Collect(double value, ui64 count) noexcept override {
2525
auto it = LowerBound(Bounds_.begin(), Bounds_.end(), value);
2626
auto index = std::distance(Bounds_.begin(), it);
2727
Values_.Add(index, count);
2828
}
2929

30-
void Reset() override {
30+
void Reset() noexcept override {
3131
Values_.Reset();
3232
}
3333

library/cpp/monlib/metrics/histogram_collector_exponential.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace NMonitoring {
2222
{
2323
}
2424

25-
void Collect(double value, ui64 count) override {
25+
void Collect(double value, ui64 count) noexcept override {
2626
ui32 index = Max<ui32>();
2727
if (value <= MinValue_) {
2828
index = 0;
@@ -35,7 +35,7 @@ namespace NMonitoring {
3535
Values_.Add(index, count);
3636
}
3737

38-
void Reset() override {
38+
void Reset() noexcept override {
3939
Values_.Reset();
4040
}
4141

library/cpp/monlib/metrics/histogram_collector_linear.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ namespace NMonitoring {
2323
{
2424
}
2525

26-
void Collect(double value, ui64 count) override {
26+
void Collect(double value, ui64 count) noexcept override {
2727
ui32 index = Max<ui32>();
2828
if (value <= StartValue_) {
2929
index = 0;
@@ -36,7 +36,7 @@ namespace NMonitoring {
3636
Values_.Add(index, count);
3737
}
3838

39-
void Reset() override {
39+
void Reset() noexcept override {
4040
Values_.Reset();
4141
}
4242

library/cpp/monlib/metrics/metric.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,10 @@ namespace NMonitoring {
131131
return IsRate_ ? EMetricType::HIST_RATE : EMetricType::HIST;
132132
}
133133

134-
virtual void Record(double value) = 0;
135-
virtual void Record(double value, ui32 count) = 0;
134+
virtual void Record(double value) noexcept = 0;
135+
virtual void Record(double value, ui32 count) noexcept = 0;
136136
virtual IHistogramSnapshotPtr TakeSnapshot() const = 0;
137-
virtual void Reset() = 0;
137+
virtual void Reset() noexcept = 0;
138138

139139
protected:
140140
const bool IsRate_;
@@ -368,11 +368,11 @@ namespace NMonitoring {
368368
{
369369
}
370370

371-
void Record(double value) override {
371+
void Record(double value) noexcept override {
372372
Collector_->Collect(value);
373373
}
374374

375-
void Record(double value, ui32 count) override {
375+
void Record(double value, ui32 count) noexcept override {
376376
Collector_->Collect(value, count);
377377
}
378378

@@ -384,7 +384,7 @@ namespace NMonitoring {
384384
return Collector_->Snapshot();
385385
}
386386

387-
void Reset() override {
387+
void Reset() noexcept override {
388388
Collector_->Reset();
389389
}
390390

0 commit comments

Comments
 (0)