Skip to content

Commit ade2b2a

Browse files
kungaazevaykin
authored andcommitted
Remove upload on page fault "optimization" (#16485)
1 parent 349fe6a commit ade2b2a

File tree

3 files changed

+0
-18
lines changed

3 files changed

+0
-18
lines changed

ydb/core/tx/datashard/build_index/local_kmeans.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -186,12 +186,6 @@ class TLocalKMeansScanBase: public TActor<TLocalKMeansScanBase>, public NTable::
186186
EScan PageFault() noexcept final
187187
{
188188
LOG_T("PageFault " << Debug());
189-
190-
if (!ReadBuf.IsEmpty() && WriteBuf.IsEmpty()) {
191-
ReadBuf.FlushTo(WriteBuf);
192-
Upload(false);
193-
}
194-
195189
return EScan::Feed;
196190
}
197191

ydb/core/tx/datashard/build_index/prefix_kmeans.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,6 @@ class TPrefixKMeansScanBase: public TActor<TPrefixKMeansScanBase>, public NTable
207207
EScan PageFault() final
208208
{
209209
LOG_T("PageFault " << Debug());
210-
211-
UploadInProgress()
212-
|| TryUpload(LevelBuf, LevelTable, LevelTypes, false)
213-
|| TryUpload(PostingBuf, PostingTable, PostingTypes, false)
214-
|| TryUpload(PrefixBuf, PrefixTable, PrefixTypes, false);
215-
216210
return EScan::Feed;
217211
}
218212

ydb/core/tx/datashard/build_index/reshuffle_kmeans.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,6 @@ class TReshuffleKMeansScanBase: public TActor<TReshuffleKMeansScanBase>, public
161161
EScan PageFault() noexcept final
162162
{
163163
LOG_T("PageFault " << Debug());
164-
165-
if (!ReadBuf.IsEmpty() && WriteBuf.IsEmpty()) {
166-
ReadBuf.FlushTo(WriteBuf);
167-
Upload(false);
168-
}
169-
170164
return EScan::Feed;
171165
}
172166

0 commit comments

Comments
 (0)