[YQ-3761] Fix RewriteAsHoppingWindow optimization (#10455) (#10547)

APozdniakov · web-flow · commit ac826cc46193 · 2024-10-21T17:35:23.000+03:00
diff --git a/ydb/library/yql/dq/opt/dq_opt_log.cpp b/ydb/library/yql/dq/opt/dq_opt_log.cpp
@@ -183,32 +183,18 @@ static void CollectSinkStages(const NNodes::TDqQuery& dqQuery, THashSet<TExprNod
 }
 
 NNodes::TExprBase DqMergeQueriesWithSinks(NNodes::TExprBase dqQueryNode, TExprContext& ctx) {
-    NNodes::TDqQuery dqQuery = dqQueryNode.Cast<NNodes::TDqQuery>();
-
-    THashSet<TExprNode::TPtr, TExprNode::TPtrHash> sinkStages;
-    CollectSinkStages(dqQuery, sinkStages);
-    TOptimizeExprSettings settings{nullptr};
-    settings.VisitLambdas = false;
-    bool deletedDqQueryChild = false;
-    TExprNode::TPtr newDqQueryNode;
-    auto status = OptimizeExpr(dqQueryNode.Ptr(), newDqQueryNode, [&sinkStages, &deletedDqQueryChild](const TExprNode::TPtr& node, TExprContext& ctx) -> TExprNode::TPtr {
-        for (ui32 childIndex = 0; childIndex < node->ChildrenSize(); ++childIndex) {
-            TExprNode* child = node->Child(childIndex);
-            if (child->IsCallable(NNodes::TDqQuery::CallableName())) {
-                NNodes::TDqQuery dqQueryChild(child);
-                CollectSinkStages(dqQueryChild, sinkStages);
-                deletedDqQueryChild = true;
-                return ctx.ChangeChild(*node, childIndex, dqQueryChild.World().Ptr());
-            }
-        }
-        return node;
-    }, ctx, settings);
-    YQL_ENSURE(status != IGraphTransformer::TStatus::Error, "Failed to merge DqQuery nodes: " << status);
-
-    if (deletedDqQueryChild) {
-        auto dqQueryBuilder = Build<TDqQuery>(ctx, dqQuery.Pos());
-        dqQueryBuilder.World(newDqQueryNode->ChildPtr(TDqQuery::idx_World));
-
+    auto maybeDqQuery = dqQueryNode.Maybe<NNodes::TDqQuery>();
+    YQL_ENSURE(maybeDqQuery, "Expected DqQuery!");
+    auto dqQuery = maybeDqQuery.Cast();
+
+    if (auto maybeDqQueryChild = dqQuery.World().Maybe<NNodes::TDqQuery>()) {
+        auto dqQueryChild = maybeDqQueryChild.Cast();
+        auto dqQueryBuilder = Build<TDqQuery>(ctx, dqQuery.Pos())
+            .World(dqQueryChild.World());
+
+        THashSet<TExprNode::TPtr, TExprNode::TPtrHash> sinkStages;
+        CollectSinkStages(dqQuery, sinkStages);
+        CollectSinkStages(maybeDqQueryChild.Cast(), sinkStages);
         auto sinkStagesBuilder = dqQueryBuilder.SinkStages();
         for (const TExprNode::TPtr& stage : sinkStages) {
             sinkStagesBuilder.Add(stage);
diff --git a/ydb/library/yql/providers/clickhouse/expr_nodes/yql_clickhouse_expr_nodes.json b/ydb/library/yql/providers/clickhouse/expr_nodes/yql_clickhouse_expr_nodes.json
@@ -41,9 +41,10 @@
             "Base": "TCallable",
             "Match": {"Type": "Callable", "Name": "ClSourceSettings"},
             "Children": [
-                {"Index": 0, "Name": "Table", "Type": "TCoAtom"},
-                {"Index": 1, "Name": "Token", "Type": "TCoSecureParam"},
-                {"Index": 2, "Name": "Columns", "Type": "TCoAtomList"}
+                {"Index": 0, "Name": "World", "Type": "TExprBase"},
+                {"Index": 1, "Name": "Table", "Type": "TCoAtom"},
+                {"Index": 2, "Name": "Token", "Type": "TCoSecureParam"},
+                {"Index": 3, "Name": "Columns", "Type": "TCoAtomList"}
             ]
         }
     ]
diff --git a/ydb/library/yql/providers/clickhouse/provider/yql_clickhouse_datasource_type_ann.cpp b/ydb/library/yql/providers/clickhouse/provider/yql_clickhouse_datasource_type_ann.cpp
@@ -25,7 +25,11 @@ class TClickHouseDataSourceTypeAnnotationTransformer : public TVisitorTransforme
     }
 
     TStatus HandleSourceSettings(const TExprNode::TPtr& input, TExprContext& ctx) {
-        if (!EnsureArgsCount(*input, 3U, ctx)) {
+        if (!EnsureArgsCount(*input, 4, ctx)) {
+            return TStatus::Error;
+        }
+
+        if (!EnsureWorldType(*input->Child(TClSourceSettings::idx_World), ctx)) {
             return TStatus::Error;
         }
 
diff --git a/ydb/library/yql/providers/clickhouse/provider/yql_clickhouse_dq_integration.cpp b/ydb/library/yql/providers/clickhouse/provider/yql_clickhouse_dq_integration.cpp
@@ -52,6 +52,7 @@ class TClickHouseDqIntegration: public TDqIntegrationBase {
 
             return Build<TDqSourceWrap>(ctx, read->Pos())
                 .Input<TClSourceSettings>()
+                    .World(clReadTable.World())
                     .Table(clReadTable.Table())
                     .Token<TCoSecureParam>()
                         .Name().Build(token)
diff --git a/ydb/library/yql/providers/generic/expr_nodes/yql_generic_expr_nodes.json b/ydb/library/yql/providers/generic/expr_nodes/yql_generic_expr_nodes.json
@@ -41,11 +41,12 @@
             "Base": "TCallable",
             "Match": {"Type": "Callable", "Name": "GenSourceSettings"},
             "Children": [
-                {"Index": 0, "Name": "Cluster", "Type": "TCoAtom"},
-                {"Index": 1, "Name": "Table", "Type": "TCoAtom"},
-                {"Index": 2, "Name": "Token", "Type": "TCoSecureParam"},
-                {"Index": 3, "Name": "Columns", "Type": "TCoAtomList"},
-                {"Index": 4, "Name": "FilterPredicate", "Type": "TCoLambda"}
+                {"Index": 0, "Name": "World", "Type": "TExprBase"},
+                {"Index": 1, "Name": "Cluster", "Type": "TCoAtom"},
+                {"Index": 2, "Name": "Table", "Type": "TCoAtom"},
+                {"Index": 3, "Name": "Token", "Type": "TCoSecureParam"},
+                {"Index": 4, "Name": "Columns", "Type": "TCoAtomList"},
+                {"Index": 5, "Name": "FilterPredicate", "Type": "TCoLambda"}
             ]
         }
     ]
diff --git a/ydb/library/yql/providers/generic/provider/yql_generic_datasource_type_ann.cpp b/ydb/library/yql/providers/generic/provider/yql_generic_datasource_type_ann.cpp
@@ -76,7 +76,11 @@ namespace NYql {
         }
 
         TStatus HandleSourceSettings(const TExprNode::TPtr& input, TExprContext& ctx) {
-            if (!EnsureArgsCount(*input, 5, ctx)) {
+            if (!EnsureArgsCount(*input, 6, ctx)) {
+                return TStatus::Error;
+            }
+
+            if (!EnsureWorldType(*input->Child(TGenSourceSettings::idx_World), ctx)) {
                 return TStatus::Error;
             }
 
diff --git a/ydb/library/yql/providers/generic/provider/yql_generic_dq_integration.cpp b/ydb/library/yql/providers/generic/provider/yql_generic_dq_integration.cpp
@@ -85,6 +85,7 @@ namespace NYql {
                     // clang-format off
                     return Build<TDqSourceWrap>(ctx, read->Pos())
                         .Input<TGenSourceSettings>()
+                            .World(genReadTable.World())
                             .Cluster(genReadTable.DataSource().Cluster())
                             .Table(genReadTable.Table())
                             .Token<TCoSecureParam>()
diff --git a/ydb/library/yql/providers/pq/expr_nodes/yql_pq_expr_nodes.json b/ydb/library/yql/providers/pq/expr_nodes/yql_pq_expr_nodes.json
@@ -67,10 +67,12 @@
             "Base": "TCallable",
             "Match": {"Type": "Callable", "Name": "DqPqTopicSource"},
             "Children": [
-                {"Index": 0, "Name": "Topic", "Type": "TPqTopic"},
-                {"Index": 1, "Name": "Columns", "Type": "TExprBase"},
-                {"Index": 2, "Name": "Settings", "Type": "TCoNameValueTupleList"},
-                {"Index": 3, "Name": "Token", "Type": "TCoSecureParam"}
+                {"Index": 0, "Name": "World", "Type": "TExprBase"},
+                {"Index": 1, "Name": "Topic", "Type": "TPqTopic"},
+                {"Index": 2, "Name": "Columns", "Type": "TExprBase"},
+                {"Index": 3, "Name": "Settings", "Type": "TCoNameValueTupleList"},
+                {"Index": 4, "Name": "Token", "Type": "TCoSecureParam"},
+                {"Index": 5, "Name": "FilterPredicate", "Type": "TCoLambda"}
             ]
         },
         {
diff --git a/ydb/library/yql/providers/pq/provider/yql_pq_datasource_type_ann.cpp b/ydb/library/yql/providers/pq/provider/yql_pq_datasource_type_ann.cpp
@@ -131,11 +131,16 @@ class TPqDataSourceTypeAnnotationTransformer : public TVisitorTransformerBase {
     }
 
     TStatus HandleDqTopicSource(TExprBase input, TExprContext& ctx) {
-        if (!EnsureArgsCount(input.Ref(), 4, ctx)) {
+        if (!EnsureArgsCount(input.Ref(), 6, ctx)) {
             return TStatus::Error;
         }
 
         TDqPqTopicSource topicSource = input.Cast<TDqPqTopicSource>();
+
+        if (!EnsureWorldType(topicSource.World().Ref(), ctx)) {
+            return TStatus::Error;
+        }
+
         TPqTopic topic = topicSource.Topic();
 
         if (!EnsureCallable(topic.Ref(), ctx)) {
diff --git a/ydb/library/yql/providers/pq/provider/yql_pq_dq_integration.cpp b/ydb/library/yql/providers/pq/provider/yql_pq_dq_integration.cpp
@@ -131,6 +131,7 @@ class TPqDqIntegration: public TDqIntegrationBase {
 
             return Build<TDqSourceWrap>(ctx, read->Pos())
                 .Input<TDqPqTopicSource>()
+                    .World(pqReadTopic.World())
                     .Topic(pqReadTopic.Topic())
                     .Columns(std::move(columns))
                     .Settings(BuildTopicReadSettings(clusterName, dqSettings, read->Pos(), ctx))
diff --git a/ydb/library/yql/providers/s3/expr_nodes/yql_s3_expr_nodes.json b/ydb/library/yql/providers/s3/expr_nodes/yql_s3_expr_nodes.json
@@ -45,31 +45,32 @@
             "Base": "TCallable",
             "Match": {"Type": "CallableBase"},
             "Children": [
-                {"Index": 0, "Name": "Paths", "Type": "TS3Paths"},
-                {"Index": 1, "Name": "Token", "Type": "TCoSecureParam"},
-                {"Index": 2, "Name": "RowsLimitHint", "Type": "TCoAtom"},
-                {"Index": 3, "Name": "Path", "Type": "TCoAtom"}
+                {"Index": 0, "Name": "World", "Type": "TExprBase"},
+                {"Index": 1, "Name": "Paths", "Type": "TS3Paths"},
+                {"Index": 2, "Name": "Token", "Type": "TCoSecureParam"},
+                {"Index": 3, "Name": "RowsLimitHint", "Type": "TCoAtom"},
+                {"Index": 4, "Name": "Path", "Type": "TCoAtom"}
             ]
         },
         {
             "Name": "TS3SourceSettings",
             "Base": "TS3SourceSettingsBase",
             "Match": {"Type": "Callable", "Name": "S3SourceSettings"},
             "Children": [
-                {"Index": 4, "Name": "SizeLimit", "Type": "TExprBase", "Optional": true},
-                {"Index": 5, "Name": "PathPattern", "Type": "TExprBase", "Optional": true},
-                {"Index": 6, "Name": "PathPatternVariant", "Type": "TExprBase", "Optional": true}
+                {"Index": 5, "Name": "SizeLimit", "Type": "TExprBase", "Optional": true},
+                {"Index": 6, "Name": "PathPattern", "Type": "TExprBase", "Optional": true},
+                {"Index": 7, "Name": "PathPatternVariant", "Type": "TExprBase", "Optional": true}
             ]
         },
         {
             "Name": "TS3ParseSettings",
             "Base": "TS3SourceSettingsBase",
             "Match": {"Type": "Callable", "Name": "S3ParseSettings"},
             "Children": [
-                {"Index": 4, "Name": "Format", "Type": "TCoAtom"},
-                {"Index": 5, "Name": "RowType", "Type": "TExprBase"},
-                {"Index": 6, "Name": "FilterPredicate", "Type": "TCoLambda"},
-                {"Index": 7, "Name": "Settings", "Type": "TExprBase", "Optional": true}
+                {"Index": 5, "Name": "Format", "Type": "TCoAtom"},
+                {"Index": 6, "Name": "RowType", "Type": "TExprBase"},
+                {"Index": 7, "Name": "FilterPredicate", "Type": "TCoLambda"},
+                {"Index": 8, "Name": "Settings", "Type": "TExprBase", "Optional": true}
             ]
         },
         {
diff --git a/ydb/library/yql/providers/s3/provider/yql_s3_datasource_type_ann.cpp b/ydb/library/yql/providers/s3/provider/yql_s3_datasource_type_ann.cpp
@@ -303,7 +303,11 @@ class TS3DataSourceTypeAnnotationTransformer : public TVisitorTransformerBase {
     }
 
     TStatus HandleS3SourceSettings(const TExprNode::TPtr& input, TExprContext& ctx) {
-        if (!EnsureMinArgsCount(*input, 4U, ctx)) {
+        if (!EnsureMinMaxArgsCount(*input, 5, 8, ctx)) {
+            return TStatus::Error;
+        }
+
+        if (!EnsureWorldType(*input->Child(TS3SourceSettings::idx_World), ctx)) {
             return TStatus::Error;
         }
 
@@ -335,7 +339,11 @@ class TS3DataSourceTypeAnnotationTransformer : public TVisitorTransformerBase {
     }
 
     TStatus HandleS3ParseSettings(const TExprNode::TPtr& input, TExprContext& ctx) {
-        if (!EnsureMinMaxArgsCount(*input, 7U, 8U, ctx)) {
+        if (!EnsureMinMaxArgsCount(*input, 8, 9, ctx)) {
+            return TStatus::Error;
+        }
+
+        if (!EnsureWorldType(*input->Child(TS3ParseSettings::idx_World), ctx)) {
             return TStatus::Error;
         }
 
diff --git a/ydb/library/yql/providers/s3/provider/yql_s3_dq_integration.cpp b/ydb/library/yql/providers/s3/provider/yql_s3_dq_integration.cpp
@@ -287,6 +287,7 @@ class TS3DqIntegration: public TDqIntegrationBase {
             if (const auto useCoro = State_->Configuration->SourceCoroActor.Get(); (!useCoro || *useCoro) && format != "raw" && format != "json_list") {
                 return Build<TDqSourceWrap>(ctx, read->Pos())
                     .Input<TS3ParseSettings>()
+                        .World(s3ReadObject.World())
                         .Paths(s3ReadObject.Object().Paths())
                         .Token<TCoSecureParam>()
                             .Name().Build(token)
@@ -332,6 +333,7 @@ class TS3DqIntegration: public TDqIntegrationBase {
                 auto emptyNode = Build<TCoVoid>(ctx, read->Pos()).Done().Ptr();
                 return Build<TDqSourceWrap>(ctx, read->Pos())
                     .Input<TS3SourceSettings>()
+                        .World(s3ReadObject.World())
                         .Paths(s3ReadObject.Object().Paths())
                         .Token<TCoSecureParam>()
                             .Name().Build(token)
diff --git a/ydb/library/yql/providers/solomon/expr_nodes/yql_solomon_expr_nodes.json b/ydb/library/yql/providers/solomon/expr_nodes/yql_solomon_expr_nodes.json
@@ -48,18 +48,19 @@
             "Base": "TCallable",
             "Match": {"Type": "Callable", "Name": "SoSourceSettings"},
             "Children": [
-                {"Index": 0, "Name": "Project", "Type": "TCoAtom"},
-                {"Index": 1, "Name": "Token", "Type": "TCoSecureParam"},
-                {"Index": 2, "Name": "RowType", "Type": "TExprBase"},
-                {"Index": 3, "Name": "SystemColumns", "Type": "TCoAtomList"},
-                {"Index": 4, "Name": "LabelNames", "Type": "TCoAtomList"},
-                {"Index": 5, "Name": "From", "Type": "TCoAtom"},
-                {"Index": 6, "Name": "To", "Type": "TCoAtom"},
-                {"Index": 7, "Name": "Program", "Type": "TCoAtom"},
-                {"Index": 8, "Name": "DownsamplingDisabled", "Type": "TCoBool"},
-                {"Index": 9, "Name": "DownsamplingAggregation", "Type": "TCoAtom"},
-                {"Index": 10, "Name": "DownsamplingFill", "Type": "TCoAtom"},
-                {"Index": 11, "Name": "DownsamplingGridSec", "Type": "TCoUint32"}
+                {"Index": 0, "Name": "World", "Type": "TExprBase"},
+                {"Index": 1, "Name": "Project", "Type": "TCoAtom"},
+                {"Index": 2, "Name": "Token", "Type": "TCoSecureParam"},
+                {"Index": 3, "Name": "RowType", "Type": "TExprBase"},
+                {"Index": 4, "Name": "SystemColumns", "Type": "TCoAtomList"},
+                {"Index": 5, "Name": "LabelNames", "Type": "TCoAtomList"},
+                {"Index": 6, "Name": "From", "Type": "TCoAtom"},
+                {"Index": 7, "Name": "To", "Type": "TCoAtom"},
+                {"Index": 8, "Name": "Program", "Type": "TCoAtom"},
+                {"Index": 9, "Name": "DownsamplingDisabled", "Type": "TCoBool"},
+                {"Index": 10, "Name": "DownsamplingAggregation", "Type": "TCoAtom"},
+                {"Index": 11, "Name": "DownsamplingFill", "Type": "TCoAtom"},
+                {"Index": 12, "Name": "DownsamplingGridSec", "Type": "TCoUint32"}
             ]
         },
         {
diff --git a/ydb/library/yql/providers/solomon/provider/yql_solomon_datasource_type_ann.cpp b/ydb/library/yql/providers/solomon/provider/yql_solomon_datasource_type_ann.cpp
@@ -34,7 +34,11 @@ class TSolomonDataSourceTypeAnnotationTransformer : public TVisitorTransformerBa
     }
 
     TStatus HandleSoSourceSettings(const TExprNode::TPtr& input, TExprContext& ctx) {
-        if (!EnsureArgsCount(*input, 12U, ctx)) {
+        if (!EnsureArgsCount(*input, 13, ctx)) {
+            return TStatus::Error;
+        }
+
+        if (!EnsureWorldType(*input->Child(TSoSourceSettings::idx_World), ctx)) {
             return TStatus::Error;
         }
 
diff --git a/ydb/library/yql/providers/solomon/provider/yql_solomon_dq_integration.cpp b/ydb/library/yql/providers/solomon/provider/yql_solomon_dq_integration.cpp
@@ -198,6 +198,7 @@ class TSolomonDqIntegration: public TDqIntegrationBase {
 
             return Build<TDqSourceWrap>(ctx, read->Pos())
                 .Input<TSoSourceSettings>()
+                    .World(soReadObject.World())
                     .Project(soReadObject.Object().Project())
                     .Token<TCoSecureParam>()
                         .Name().Build(token)
diff --git a/ydb/library/yql/providers/ydb/expr_nodes/yql_ydb_expr_nodes.json b/ydb/library/yql/providers/ydb/expr_nodes/yql_ydb_expr_nodes.json
@@ -30,9 +30,10 @@
             "Base": "TCallable",
             "Match": {"Type": "Callable", "Name": "YdbSourceSettings"},
             "Children": [
-                {"Index": 0, "Name": "Table", "Type": "TCoAtom"},
-                {"Index": 1, "Name": "Token", "Type": "TCoSecureParam"},
-                {"Index": 2, "Name": "Columns", "Type": "TCoAtomList"}
+                {"Index": 0, "Name": "World", "Type": "TExprBase"},
+                {"Index": 1, "Name": "Table", "Type": "TCoAtom"},
+                {"Index": 2, "Name": "Token", "Type": "TCoSecureParam"},
+                {"Index": 3, "Name": "Columns", "Type": "TCoAtomList"}
             ]
         },
         {
diff --git a/ydb/library/yql/providers/ydb/provider/yql_ydb_datasource_type_ann.cpp b/ydb/library/yql/providers/ydb/provider/yql_ydb_datasource_type_ann.cpp
@@ -29,7 +29,11 @@ class TYdbDataSourceTypeAnnotationTransformer : public TVisitorTransformerBase {
 
     TStatus HandleYdbSourceSettings(const TExprNode::TPtr& input, TExprNode::TPtr& output, TExprContext& ctx) {
         Y_UNUSED(output);
-        if (!EnsureArgsCount(*input, 3U, ctx)) {
+        if (!EnsureArgsCount(*input, 4, ctx)) {
+            return TStatus::Error;
+        }
+
+        if (!EnsureWorldType(*input->Child(TYdbSourceSettings::idx_World), ctx)) {
             return TStatus::Error;
         }
 
diff --git a/ydb/library/yql/providers/ydb/provider/yql_ydb_dq_integration.cpp b/ydb/library/yql/providers/ydb/provider/yql_ydb_dq_integration.cpp
@@ -101,6 +101,7 @@ class TYdbDqIntegration: public TDqIntegrationBase {
 
             return Build<TDqSourceWrap>(ctx, read->Pos())
                 .Input<TYdbSourceSettings>()
+                    .World(ydbReadTable.World())
                     .Table(ydbReadTable.Table())
                     .Token<TCoSecureParam>()
                         .Name().Build(token)
diff --git a/ydb/library/yql/tests/sql/hybrid_file/part2/canondata/result.json b/ydb/library/yql/tests/sql/hybrid_file/part2/canondata/result.json
@@ -2871,9 +2871,9 @@
     ],
     "test.test[window-full/session--Debug]": [
         {
-            "checksum": "b06da41f9a9ea38646c43487f4b8b96a",
-            "size": 13340,
-            "uri": "https://{canondata_backend}/1775319/8ac8c87858e0db34f5a3c99b3f4ca1084cccbace/resource.tar.gz#test.test_window-full_session--Debug_/opt.yql_patched"
+            "checksum": "497487e14c39e6f6eeacce4046bfb2f5",
+            "size": 14172,
+            "uri": "https://{canondata_backend}/1937367/34342462b74dcf33b334172059f34ab28ba50ba6/resource.tar.gz#test.test_window-full_session--Debug_/opt.yql_patched"
         }
     ],
     "test.test[window-full/session--Plan]": [
@@ -2885,9 +2885,9 @@
     ],
     "test.test[window-full/session_aliases--Debug]": [
         {
-            "checksum": "e021555a47e83d0b792765a8ee82be94",
-            "size": 14124,
-            "uri": "https://{canondata_backend}/1775319/8ac8c87858e0db34f5a3c99b3f4ca1084cccbace/resource.tar.gz#test.test_window-full_session_aliases--Debug_/opt.yql_patched"
+            "checksum": "cf18b79ffda288cb9cf374749f268298",
+            "size": 14969,
+            "uri": "https://{canondata_backend}/1937367/34342462b74dcf33b334172059f34ab28ba50ba6/resource.tar.gz#test.test_window-full_session_aliases--Debug_/opt.yql_patched"
         }
     ],
     "test.test[window-full/session_aliases--Plan]": [
diff --git a/ydb/library/yql/tests/sql/hybrid_file/part7/canondata/result.json b/ydb/library/yql/tests/sql/hybrid_file/part7/canondata/result.json
@@ -1763,20 +1763,6 @@
             "uri": "https://{canondata_backend}/1942671/d37704c7d0acd85d95c86ed2cbc5abdedc6da1fe/resource.tar.gz#test.test_pg-pg_like_cast-default.txt-Plan_/plan.txt"
         }
     ],
-    "test.test[pg-record_from_table_row-default.txt-Debug]": [
-        {
-            "checksum": "49833b2ef9cbe7c8eafd38f12a430fd3",
-            "size": 540,
-            "uri": "https://{canondata_backend}/1903280/6ac862756a9225bab7885d29cf2289a6202a5ff1/resource.tar.gz#test.test_pg-record_from_table_row-default.txt-Debug_/opt.yql_patched"
-        }
-    ],
-    "test.test[pg-record_from_table_row-default.txt-Plan]": [
-        {
-            "checksum": "b4dd508a329723c74293d80f0278c705",
-            "size": 505,
-            "uri": "https://{canondata_backend}/1924537/4ece22823ee95186ecb519415692146559b02395/resource.tar.gz#test.test_pg-record_from_table_row-default.txt-Plan_/plan.txt"
-        }
-    ],
     "test.test[pg-select_case-default.txt-Debug]": [
         {
             "checksum": "a451a438b947e55f02cc5c3c7da6456d",
diff --git a/ydb/library/yql/tests/sql/solomon/canondata/test.test_solomon-Basic-default.txt_/opt.yql b/ydb/library/yql/tests/sql/solomon/canondata/test.test_solomon-Basic-default.txt_/opt.yql
@@ -4,9 +4,9 @@
 (let $3 (DataType 'String))
 (let $4 (StructType '('"kind" $3) '('"labels" (DictType $3 $3)) '('"ts" (DataType 'Datetime)) '('type $3) '('"value" (DataType 'Double))))
 (let $5 '('"kind" '"labels" '"value" '"ts" 'type))
-(let $6 (SoSourceSettings '"my_project" (SecureParam '"cluster:default_local_solomon") $4 $5 '() '"2023-12-08T14:40:39Z" '"2023-12-08T14:45:39Z" '"{}" (Bool '"false") '"AVG" '"PREVIOUS" (Uint32 '"15")))
+(let $6 (SoSourceSettings world '"my_project" (SecureParam '"cluster:default_local_solomon") $4 $5 '() '"2023-12-08T14:40:39Z" '"2023-12-08T14:45:39Z" '"{}" (Bool '"false") '"AVG" '"PREVIOUS" (Uint32 '"15")))
 (let $7 (DqStage '((DqSource (DataSource '"solomon" '"local_solomon") $6)) (lambda '($10) $10) '('('"_logical_id" '199321))))
-(let $8 (DqStage '((DqCnUnionAll (TDqOutput $7 '"0"))) (lambda '($11) $11) '('('"_logical_id" '199342))))
+(let $8 (DqStage '((DqCnUnionAll (TDqOutput $7 '"0"))) (lambda '($11) $11) '('('"_logical_id" '199348))))
 (let $9 (ResPull! $1 $2 (Key) (DqCnResult (TDqOutput $8 '"0") '()) '('('type) '('autoref)) '"dq"))
 (return (Commit! (Commit! $9 $2) (DataSink '"solomon" '"local_solomon")))
 )
diff --git a/ydb/library/yql/tests/sql/solomon/canondata/test.test_solomon-Downsampling-default.txt_/opt.yql b/ydb/library/yql/tests/sql/solomon/canondata/test.test_solomon-Downsampling-default.txt_/opt.yql
diff --git a/ydb/library/yql/tests/sql/solomon/canondata/test.test_solomon-DownsamplingValidSettings-default.txt_/opt.yql b/ydb/library/yql/tests/sql/solomon/canondata/test.test_solomon-DownsamplingValidSettings-default.txt_/opt.yql
diff --git a/ydb/library/yql/tests/sql/solomon/canondata/test.test_solomon-LabelColumns-default.txt_/opt.yql b/ydb/library/yql/tests/sql/solomon/canondata/test.test_solomon-LabelColumns-default.txt_/opt.yql
diff --git a/ydb/library/yql/tests/sql/sql2yql/canondata/result.json b/ydb/library/yql/tests/sql/sql2yql/canondata/result.json
diff --git a/ydb/library/yql/tests/sql/yt_native_file/part7/canondata/test.test_match_recognize-without_order_by--Results_/extracted b/ydb/library/yql/tests/sql/yt_native_file/part7/canondata/test.test_match_recognize-without_order_by--Results_/extracted
diff --git a/ydb/library/yql/tests/sql/yt_native_file/part9/canondata/result.json b/ydb/library/yql/tests/sql/yt_native_file/part9/canondata/result.json

Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,10 @@`
`41`	`41`	`"Base": "TCallable",`
`42`	`42`	`"Match": {"Type": "Callable", "Name": "ClSourceSettings"},`
`43`	`43`	`"Children": [`
`44`		`- {"Index": 0, "Name": "Table", "Type": "TCoAtom"},`
`45`		`- {"Index": 1, "Name": "Token", "Type": "TCoSecureParam"},`
`46`		`- {"Index": 2, "Name": "Columns", "Type": "TCoAtomList"}`
	`44`	`+ {"Index": 0, "Name": "World", "Type": "TExprBase"},`
	`45`	`+ {"Index": 1, "Name": "Table", "Type": "TCoAtom"},`
	`46`	`+ {"Index": 2, "Name": "Token", "Type": "TCoSecureParam"},`
	`47`	`+ {"Index": 3, "Name": "Columns", "Type": "TCoAtomList"}`
`47`	`48`	`]`
`48`	`49`	`}`
`49`	`50`	`]`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,11 @@ class TClickHouseDataSourceTypeAnnotationTransformer : public TVisitorTransforme`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`TStatus HandleSourceSettings(const TExprNode::TPtr& input, TExprContext& ctx) {`
`28`		`- if (!EnsureArgsCount(*input, 3U, ctx)) {`
	`28`	`+ if (!EnsureArgsCount(*input, 4, ctx)) {`
	`29`	`+ return TStatus::Error;`
	`30`	`+ }`
	`31`	`+`
	`32`	`+ if (!EnsureWorldType(*input->Child(TClSourceSettings::idx_World), ctx)) {`
`29`	`33`	`return TStatus::Error;`
`30`	`34`	`}`
`31`	`35`
Original file line number	Diff line number	Diff line change
`@@ -41,11 +41,12 @@`
`41`	`41`	`"Base": "TCallable",`
`42`	`42`	`"Match": {"Type": "Callable", "Name": "GenSourceSettings"},`
`43`	`43`	`"Children": [`
`44`		`- {"Index": 0, "Name": "Cluster", "Type": "TCoAtom"},`
`45`		`- {"Index": 1, "Name": "Table", "Type": "TCoAtom"},`
`46`		`- {"Index": 2, "Name": "Token", "Type": "TCoSecureParam"},`
`47`		`- {"Index": 3, "Name": "Columns", "Type": "TCoAtomList"},`
`48`		`- {"Index": 4, "Name": "FilterPredicate", "Type": "TCoLambda"}`
	`44`	`+ {"Index": 0, "Name": "World", "Type": "TExprBase"},`
	`45`	`+ {"Index": 1, "Name": "Cluster", "Type": "TCoAtom"},`
	`46`	`+ {"Index": 2, "Name": "Table", "Type": "TCoAtom"},`
	`47`	`+ {"Index": 3, "Name": "Token", "Type": "TCoSecureParam"},`
	`48`	`+ {"Index": 4, "Name": "Columns", "Type": "TCoAtomList"},`
	`49`	`+ {"Index": 5, "Name": "FilterPredicate", "Type": "TCoLambda"}`
`49`	`50`	`]`
`50`	`51`	`}`
`51`	`52`	`]`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,11 @@ namespace NYql {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`TStatus HandleSourceSettings(const TExprNode::TPtr& input, TExprContext& ctx) {`
`79`		`- if (!EnsureArgsCount(*input, 5, ctx)) {`
	`79`	`+ if (!EnsureArgsCount(*input, 6, ctx)) {`
	`80`	`+ return TStatus::Error;`
	`81`	`+ }`
	`82`	`+`
	`83`	`+ if (!EnsureWorldType(*input->Child(TGenSourceSettings::idx_World), ctx)) {`
`80`	`84`	`return TStatus::Error;`
`81`	`85`	`}`
`82`	`86`