Make dump commands read only (#14562)

Author: pixcc

ydb/public/lib/ydb_cli/commands/ydb_admin.cpp

@@ -35,7 +35,7 @@ class TCommandDatabase : public TClientCommandTree {
 };
 
 TCommandDatabaseDump::TCommandDatabaseDump() 
-    : TYdbCommand("dump", {}, "Dump database into local directory") 
+    : TYdbReadOnlyCommand("dump", {}, "Dump database into local directory") 
 {}
 
 void TCommandDatabaseDump::Config(TConfig& config) {

ydb/public/lib/ydb_cli/commands/ydb_admin.h

@@ -12,7 +12,7 @@ class TCommandAdmin : public TClientCommandTree {
     virtual void Config(TConfig& config) override;
 };
 
-class TCommandDatabaseDump : public TYdbCommand {
+class TCommandDatabaseDump : public TYdbReadOnlyCommand {
 public:
     TCommandDatabaseDump();
     void Config(TConfig& config) override;

ydb/public/lib/ydb_cli/commands/ydb_cluster.cpp

@@ -46,7 +46,7 @@ int TCommandClusterBootstrap::Run(TConfig& config) {
 }
 
 TCommandClusterDump::TCommandClusterDump()
-    : TYdbCommand("dump", {}, "Dump cluster into local directory")
+    : TYdbReadOnlyCommand("dump", {}, "Dump cluster into local directory")
 {}
 
 void TCommandClusterDump::Config(TConfig& config) {

ydb/public/lib/ydb_cli/commands/ydb_cluster.h

@@ -22,7 +22,7 @@ class TCommandClusterBootstrap : public TYdbCommand {
     int Run(TConfig& config) override;
 };
 
-class TCommandClusterDump : public TYdbCommand {
+class TCommandClusterDump : public TYdbReadOnlyCommand {
 public:
     TCommandClusterDump();
     void Config(TConfig& config) override;

ydb/tests/functional/ydb_cli/test_ydb_backup.py

@@ -1339,7 +1339,6 @@ def create_backup(cls, command, expected_files, additional_args=[]):
             [
                 backup_bin(),
                 "--verbose",
-                "--assume-yes",
                 "--endpoint", "grpc://localhost:%d" % cls.cluster.nodes[1].grpc_port,
             ]
             + command