Move more checks to the inlined part of IsLevelEnabled

commit_hash:ad986b1f46f36765b3d80b8e527b1f25ad966d42

Author: babenko

library/cpp/yt/logging/logger-inl.h

@@ -77,17 +77,26 @@ Y_FORCE_INLINE ELogLevel TLogger::GetEffectiveLoggingLevel(ELogLevel level, cons
 
 Y_FORCE_INLINE bool TLogger::IsLevelEnabled(ELogLevel level) const
 {
-    // This is the first check which is intended to be inlined next to
-    // logging invocation point. Check below is almost zero-cost due
-    // to branch prediction (which requires inlining for proper work).
-    if (level < MinLevel_) {
+    if (!Category_) {
         return false;
     }
 
-    // Next check is heavier and requires full log manager definition which
-    // is undesirable in -inl.h header file. This is why we extract it
-    // to a separate method which is implemented in cpp file.
-    return IsLevelEnabledHeavy(level);
+    [[unlikely]] if (
+        Category_->CurrentVersion.load(std::memory_order::relaxed) !=
+        Category_->ActualVersion->load(std::memory_order::relaxed))
+    {
+        UpdateCategory();
+    }
+
+    if (level < Category_->MinPlainTextLevel) {
+        return false;
+    }
+
+    if (level < GetThreadMinLogLevel()) {
+        return false;
+    }
+
+    return true;
 }
 
 Y_FORCE_INLINE const TLogger& TLogger::operator()() const

library/cpp/yt/logging/logger.cpp

@@ -169,20 +169,9 @@ const TLoggingCategory* TLogger::GetCategory() const
     return Category_;
 }
 
-bool TLogger::IsLevelEnabledHeavy(ELogLevel level) const
+void TLogger::UpdateCategory() const
 {
-    // Note that we managed to reach this point, i.e. level >= MinLevel_,
-    // which implies that MinLevel_ != ELogLevel::Maximum, so this logger was not
-    // default constructed, thus it has non-trivial category.
-    YT_ASSERT(Category_);
-
-    if (Category_->CurrentVersion != Category_->ActualVersion->load(std::memory_order::relaxed)) {
-        LogManager_->UpdateCategory(const_cast<TLoggingCategory*>(Category_));
-    }
-
-    return
-        level >= Category_->MinPlainTextLevel &&
-        level >= ThreadMinLogLevel();
+    LogManager_->UpdateCategory(const_cast<TLoggingCategory*>(Category_));
 }
 
 bool TLogger::GetAbortOnAlert() const

library/cpp/yt/logging/logger.h

@@ -274,9 +274,7 @@ class TLogger
     void ResetCoWState();
 
 private:
-    //! This method checks level against category's min level.
-    //! Refer to comment in TLogger::IsLevelEnabled for more details.
-    bool IsLevelEnabledHeavy(ELogLevel level) const;
+    void UpdateCategory() const;
 };
 
 ////////////////////////////////////////////////////////////////////////////////