Skip to content

Commit 987134c

Browse files
authored
fix segfault in autocomplete handler when redirecting to a database (#8367)
1 parent d9565af commit 987134c

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

ydb/core/viewer/viewer_autocomplete.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ using TNavigate = NSchemeCache::TSchemeCacheNavigate;
1313
class TJsonAutocomplete : public TViewerPipeClient {
1414
using TThis = TJsonAutocomplete;
1515
using TBase = TViewerPipeClient;
16-
IViewer* Viewer;
17-
NMon::TEvHttpInfo::TPtr Event;
1816
TEvViewer::TEvViewerRequest::TPtr ViewerRequest;
1917
TJsonSettings JsonSettings;
2018
ui32 Timeout = 0;
@@ -47,9 +45,8 @@ class TJsonAutocomplete : public TViewerPipeClient {
4745
std::vector<TNodeId> TenantDynamicNodes;
4846
bool Direct = false;
4947
public:
50-
TJsonAutocomplete(IViewer* viewer, NMon::TEvHttpInfo::TPtr &ev)
51-
: Viewer(viewer)
52-
, Event(ev)
48+
TJsonAutocomplete(IViewer* viewer, NMon::TEvHttpInfo::TPtr& ev)
49+
: TBase(viewer, ev)
5350
{
5451
const auto& params(Event->Get()->Request.GetParams());
5552
InitConfig(params);
@@ -165,7 +162,7 @@ class TJsonAutocomplete : public TViewerPipeClient {
165162
// autocomplete database list via console request
166163
RequestConsoleListTenants();
167164
} else {
168-
Direct |= !Event->Get()->Request.GetHeader("X-Forwarded-From-Node").empty(); // we're already forwarding
165+
Direct |= !TBase::Event->Get()->Request.GetHeader("X-Forwarded-From-Node").empty(); // we're already forwarding
169166
Direct |= (Database == AppData()->TenantName) || Database.empty(); // we're already on the right node or don't use database filter
170167
if (Database && !Direct) {
171168
// proxy request to a dynamic node of the specified database

0 commit comments

Comments
 (0)