Skip to content

Commit 95c30d4

Browse files
authored
fix deadline logging (#19853) (#20366)
2 parents 5dcc14b + 237219f commit 95c30d4

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

ydb/core/tx/columnshard/engines/reader/actor/actor.cpp

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ void TColumnShardScan::HandleScan(TEvents::TEvWakeup::TPtr& /*ev*/) {
181181
SendScanError("ColumnShard scanner timeout: HAS_ACK=0");
182182
Finish(NColumnShard::TScanCounters::EStatusFinish::Deadline);
183183
} else {
184-
AFL_WARN(NKikimrServices::TX_COLUMNSHARD_SCAN)("event", "scan_continue")("deadline", GetComputeDeadline())("timeout", Timeout)("now", TMonotonic::Now());
184+
AFL_WARN(NKikimrServices::TX_COLUMNSHARD_SCAN)("event", "scan_continue")("deadline", GetComputeDeadlineOptional())("timeout", Timeout)("now", TMonotonic::Now());
185185
ScheduleWakeup(TMonotonic::Now() + Timeout / 5);
186186
}
187187
}
@@ -441,7 +441,15 @@ TMonotonic TColumnShardScan::GetScanDeadline() const {
441441
}
442442

443443
TMonotonic TColumnShardScan::GetComputeDeadline() const {
444-
AFL_VERIFY(!AckReceivedInstant);
444+
auto result = GetComputeDeadlineOptional();
445+
AFL_VERIFY(!!result);
446+
return *result;
447+
}
448+
449+
std::optional<TMonotonic> TColumnShardScan::GetComputeDeadlineOptional() const {
450+
if (AckReceivedInstant) {
451+
return std::nullopt;
452+
}
445453
return (LastResultInstant ? *LastResultInstant : *StartInstant) + Timeout;
446454
}
447455

ydb/core/tx/columnshard/engines/reader/actor/actor.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ class TColumnShardScan: public TActorBootstrapped<TColumnShardScan>,
115115
TMonotonic GetScanDeadline() const;
116116

117117
TMonotonic GetComputeDeadline() const;
118+
std::optional<TMonotonic> GetComputeDeadlineOptional() const;
118119

119120
private:
120121
const TActorId ColumnShardActorId;

0 commit comments

Comments
 (0)