Make Digest UDF backward compatible for incremental upgrade (#18873)

Author: igormunkin

yql/essentials/udfs/common/digest/digest_udf.cpp

@@ -1,6 +1,8 @@
 #include <yql/essentials/public/udf/udf_helpers.h>
 #include <yql/essentials/public/udf/udf_value_builder.h>
 
+#include <yql/essentials/minikql/mkql_runtime_version.h>
+
 #include <util/digest/murmur.h>
 #include <util/digest/city.h>
 #include <util/digest/numeric.h>
@@ -56,6 +58,15 @@ namespace {
                 return false;
             }
 
+            // FIXME: The condition below is required to untie the
+            // Gordian knot with the upgrade, when two MiniKQL
+            // runtimes with different versions are being used.
+            // See YQL-19967 for more info.
+            if (MKQL_RUNTIME_VERSION < 51U && typesOnly) {
+                builder.SimpleSignature<TResult(TAutoMap<char*>)>();
+                return true;
+            }
+
             auto args = builder.Args();
             args->Add(builder.SimpleType<char *>()).Flags(ICallablePayload::TArgumentFlags::AutoMap);
             args->Add(builder.Optional()->Item(builder.SimpleType<TResult>()).Build()).Name("Init");

yql/essentials/udfs/common/digest/test/canondata/result.json

@@ -3,10 +3,5 @@
         {
             "uri": "file://test.test_Basic_/results.txt"
         }
-    ],
-    "test.test[Init]": [
-        {
-            "uri": "file://test.test_Init_/results.txt"
-        }
     ]
 }

yql/essentials/udfs/common/digest/test/canondata/test.test_Basic_/results.txt

@@ -70,13 +70,6 @@
                                     "Uint64"
                                 ]
                             ];
-                            [
-                                "cityWithSeed";
-                                [
-                                    "DataType";
-                                    "Uint64"
-                                ]
-                            ];
                             [
                                 "city128";
                                 [
@@ -275,7 +268,6 @@
                         "5654386555365545660";
                         "1466639702";
                         "11413460447292444913";
-                        "684814019408231284";
                         [
                             "125830901799957853";
                             "7569582475522398857"
@@ -334,7 +326,6 @@
                         "16472888669357673283";
                         "2351653828";
                         "17472595041006102391";
-                        "8016373356242392939";
                         [
                             "13426016195983081906";
                             "17051066397148972982"
@@ -393,7 +384,6 @@
                         "6734453432295282525";
                         "2128480519";
                         "11275350073939794026";
-                        "1669883546352889947";
                         [
                             "15168680716710346397";
                             "13490672353767795293"
@@ -452,7 +442,6 @@
                         "0";
                         "0";
                         "11160318154034397263";
-                        "12607432989128692740";
                         [
                             "18085479540095642321";
                             "11079402499652051579"

yql/essentials/udfs/common/digest/test/canondata/test.test_Init_/results.txt

@@ -9,7 +9,6 @@ SELECT
     Digest::MurMurHash2A(key) AS murmur2a,
     Digest::MurMurHash2A32(key) AS murmur2a32,
     Digest::CityHash(key) AS city,
-    Digest::CityHash(key, 111) AS cityWithSeed,
     Digest::CityHash128(key) AS city128,
     Digest::NumericHash(COALESCE(CAST(key AS Uint64), 0)) AS numeric,
     Digest::Md5Hex(key) AS md5hex,