Skip to content

Commit 8e5dc48

Browse files
committed
Rename dummy signature classes to structs
- Class -> struct - Remove useless friends commit_hash:87aa0c648bf31795c35bac54d546df46611c8e1e
1 parent 3f7bb4c commit 8e5dc48

File tree

6 files changed

+14
-25
lines changed

6 files changed

+14
-25
lines changed

yt/yt/client/signature/generator.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@ TSignaturePtr ISignatureGenerator::Sign(TYsonString data)
2020

2121
////////////////////////////////////////////////////////////////////////////////
2222

23-
class TDummySignatureGenerator
23+
struct TDummySignatureGenerator
2424
: public ISignatureGenerator
2525
{
26-
public:
2726
void Sign(const TSignaturePtr& signature) override
2827
{
2928
signature->Header_ = NYson::TYsonString("DummySignature"_sb);
@@ -37,10 +36,9 @@ ISignatureGeneratorPtr CreateDummySignatureGenerator()
3736

3837
////////////////////////////////////////////////////////////////////////////////
3938

40-
class TAlwaysThrowingSignatureGenerator
39+
struct TAlwaysThrowingSignatureGenerator
4140
: public ISignatureGenerator
4241
{
43-
public:
4442
void Sign(const TSignaturePtr& /*signature*/) override
4543
{
4644
THROW_ERROR_EXCEPTION("Signature generation is unsupported");

yt/yt/client/signature/generator.h

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,14 @@ namespace NYT::NSignature {
88

99
////////////////////////////////////////////////////////////////////////////////
1010

11-
class ISignatureGenerator
11+
struct ISignatureGenerator
1212
: public TRefCounted
1313
{
14-
public:
1514
//! Fills out the Signature_ and Header_ fields in a given TSignature
1615
//! based on its payload.
1716
virtual void Sign(const TSignaturePtr& signature) = 0;
1817

1918
[[nodiscard]] TSignaturePtr Sign(NYson::TYsonString data);
20-
21-
private:
22-
friend class TSignatureGenerator;
23-
friend class TDummySignatureGenerator;
24-
friend class TAlwaysThrowingSignatureGenerator;
2519
};
2620

2721
DEFINE_REFCOUNTED_TYPE(ISignatureGenerator)

yt/yt/client/signature/public.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ DECLARE_REFCOUNTED_CLASS(TSignature)
1010

1111
///////////////////////////////////////////////////////////////////////////////
1212

13-
DECLARE_REFCOUNTED_CLASS(ISignatureGenerator)
14-
DECLARE_REFCOUNTED_CLASS(ISignatureValidator)
13+
DECLARE_REFCOUNTED_STRUCT(ISignatureGenerator)
14+
DECLARE_REFCOUNTED_STRUCT(ISignatureValidator)
1515

1616
///////////////////////////////////////////////////////////////////////////////
1717

yt/yt/client/signature/signature.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ class TSignature final
2727
NYson::TYsonString Payload_;
2828
std::vector<std::byte> Signature_;
2929

30-
friend class ISignatureGenerator;
30+
friend struct ISignatureGenerator;
31+
friend struct TDummySignatureGenerator;
32+
friend struct TAlwaysThrowingSignatureGenerator;
3133
friend class TSignatureGenerator;
32-
friend class TDummySignatureGenerator;
33-
friend class TAlwaysThrowingSignatureGenerator;
3434

35-
friend class ISignatureValidator;
35+
friend struct ISignatureValidator;
36+
friend struct TDummySignatureValidator;
37+
friend struct TAlwaysThrowingSignatureValidator;
3638
friend class TSignatureValidator;
37-
friend class TDummySignatureValidator;
38-
friend class TAlwaysThrowingSignatureValidator;
3939

4040
friend void Serialize(const TSignature& signature, NYson::IYsonConsumer* consumer);
4141
friend void Deserialize(TSignature& signature, NYTree::INodePtr node);

yt/yt/client/signature/validator.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@ namespace NYT::NSignature {
88

99
////////////////////////////////////////////////////////////////////////////////
1010

11-
class TDummySignatureValidator
11+
struct TDummySignatureValidator
1212
: public ISignatureValidator
1313
{
14-
public:
1514
TFuture<bool> Validate(const TSignaturePtr& signature) override
1615
{
1716
YT_VERIFY(signature->Header_.ToString() == "DummySignature");
@@ -26,10 +25,9 @@ ISignatureValidatorPtr CreateDummySignatureValidator()
2625

2726
////////////////////////////////////////////////////////////////////////////////
2827

29-
class TAlwaysThrowingSignatureValidator
28+
struct TAlwaysThrowingSignatureValidator
3029
: public ISignatureValidator
3130
{
32-
public:
3331
TFuture<bool> Validate(const TSignaturePtr& /*signature*/) override
3432
{
3533
THROW_ERROR_EXCEPTION("Signature validation is unsupported");

yt/yt/client/signature/validator.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,9 @@ namespace NYT::NSignature {
1010

1111
////////////////////////////////////////////////////////////////////////////////
1212

13-
class ISignatureValidator
13+
struct ISignatureValidator
1414
: public TRefCounted
1515
{
16-
public:
1716
virtual TFuture<bool> Validate(const TSignaturePtr& signature) = 0;
1817
};
1918

0 commit comments

Comments
 (0)