Skip to content

Commit 89826f0

Browse files
authored
Enable EnableUuidAsPrimaryKey for default (#7914)
1 parent cb0ca90 commit 89826f0

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1945,8 +1945,7 @@ Y_UNIT_TEST_SUITE(KqpScheme) {
19451945
}
19461946

19471947
Y_UNIT_TEST(CreateTableWithPartitionAtKeysUuid) {
1948-
TKikimrSettings kikimrSettings = TKikimrSettings()
1949-
.SetEnableUuidAsPrimaryKey(true);
1948+
TKikimrSettings kikimrSettings;
19501949
TKikimrRunner kikimr(kikimrSettings);
19511950
auto db = kikimr.GetTableClient();
19521951
auto session = db.CreateSession().GetValueSync().GetSession();
@@ -1990,8 +1989,7 @@ Y_UNIT_TEST_SUITE(KqpScheme) {
19901989
}
19911990

19921991
Y_UNIT_TEST(CreateTableWithUniformPartitionsUuid) {
1993-
TKikimrSettings kikimrSettings = TKikimrSettings()
1994-
.SetEnableUuidAsPrimaryKey(true);
1992+
TKikimrSettings kikimrSettings;
19951993
TKikimrRunner kikimr(kikimrSettings);
19961994
auto db = kikimr.GetTableClient();
19971995
auto session = db.CreateSession().GetValueSync().GetSession();

ydb/core/kqp/ut/yql/kqp_yql_ut.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -613,6 +613,7 @@ Y_UNIT_TEST_SUITE(KqpYql) {
613613
appConfig.MutableTableServiceConfig()->SetEnablePreparedDdl(true);
614614
auto setting = NKikimrKqp::TKqpSetting();
615615
auto serverSettings = TKikimrSettings()
616+
.SetEnableUuidAsPrimaryKey(false)
616617
.SetAppConfig(appConfig)
617618
.SetKqpSettings({setting});
618619
TKikimrRunner kikimr(serverSettings.SetWithSampleTables(false));
@@ -684,7 +685,6 @@ Y_UNIT_TEST_SUITE(KqpYql) {
684685
auto setting = NKikimrKqp::TKqpSetting();
685686
auto serverSettings = TKikimrSettings()
686687
.SetAppConfig(appConfig)
687-
.SetEnableUuidAsPrimaryKey(true)
688688
.SetKqpSettings({setting});
689689
TKikimrRunner kikimr(serverSettings.SetWithSampleTables(false));
690690

@@ -833,7 +833,6 @@ Y_UNIT_TEST_SUITE(KqpYql) {
833833
auto setting = NKikimrKqp::TKqpSetting();
834834
auto serverSettings = TKikimrSettings()
835835
.SetAppConfig(appConfig)
836-
.SetEnableUuidAsPrimaryKey(true)
837836
.SetKqpSettings({setting});
838837
TKikimrRunner kikimr(serverSettings.SetWithSampleTables(false));
839838

@@ -890,7 +889,6 @@ Y_UNIT_TEST_SUITE(KqpYql) {
890889
auto setting = NKikimrKqp::TKqpSetting();
891890
auto serverSettings = TKikimrSettings()
892891
.SetAppConfig(appConfig)
893-
.SetEnableUuidAsPrimaryKey(true)
894892
.SetKqpSettings({setting});
895893
TKikimrRunner kikimr(serverSettings.SetWithSampleTables(false));
896894

@@ -917,7 +915,6 @@ Y_UNIT_TEST_SUITE(KqpYql) {
917915

918916
Y_UNIT_TEST(UuidPrimaryKeyBulkUpsert) {
919917
auto settings = TKikimrSettings()
920-
.SetEnableUuidAsPrimaryKey(true)
921918
.SetWithSampleTables(false);
922919
auto kikimr = TKikimrRunner{settings};
923920
auto db = kikimr.GetTableClient();

ydb/core/protos/feature_flags.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ message TFeatureFlags {
123123
optional bool EnableUniqConstraint = 104 [default = false];
124124
optional bool EnableChangefeedDebeziumJsonFormat = 105 [default = false];
125125
optional bool EnableStatistics = 106 [default = true];
126-
optional bool EnableUuidAsPrimaryKey = 107 [default = false];
126+
optional bool EnableUuidAsPrimaryKey = 107 [default = true];
127127
optional bool EnableTablePgTypes = 108 [default = false];
128128
optional bool EnableLocalDBBtreeIndex = 109 [default = true];
129129
optional bool EnablePDiskHighHDDInFlight = 110 [default = false];

0 commit comments

Comments
 (0)