Skip to content

Commit 824cbb5

Browse files
VPolkaFloatingCrowbar
authored andcommitted
fix leak in persqueue write session actor (#18226)
1 parent f9f2c5c commit 824cbb5

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

ydb/services/persqueue_v1/actors/write_session_actor.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,8 +1189,6 @@ void TWriteSessionActor<UseMigrationProtocol>::PrepareRequest(THolder<TEvWrite>&
11891189
w->SetSourceId(NPQ::NSourceIdEncoding::EncodeSimple(SourceId));
11901190
}
11911191
w->SetSeqNo(writeRequest.sequence_numbers(messageIndex));
1192-
if (!UseDeduplication)
1193-
SeqNoInflight.push_back(w->GetSeqNo());
11941192

11951193
w->SetCreateTimeMS(writeRequest.created_at_ms(messageIndex));
11961194
w->SetUncompressedSize(writeRequest.blocks_uncompressed_sizes(messageIndex));
@@ -1211,7 +1209,6 @@ void TWriteSessionActor<UseMigrationProtocol>::PrepareRequest(THolder<TEvWrite>&
12111209
w->SetDisableDeduplication(true);
12121210
}
12131211
w->SetSeqNo(msg.seq_no());
1214-
SeqNoInflight.push_back(w->GetSeqNo());
12151212
w->SetCreateTimeMS(::google::protobuf::util::TimeUtil::TimestampToMilliseconds(msg.created_at()));
12161213
w->SetUncompressedSize(msg.uncompressed_size());
12171214
w->SetClientDC(ClientDC);

ydb/services/persqueue_v1/actors/write_session_actor.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,8 +289,6 @@ class TWriteSessionActor
289289

290290
TInitRequest InitRequest;
291291

292-
TDeque<ui64> SeqNoInflight;
293-
294292
TActorId PartitionWriterCache;
295293
TActorId PartitionChooser;
296294

0 commit comments

Comments
 (0)