Draft of TEvAnalyzeTable in ColumnShard (#7198)

Author: azevaykin

ydb/core/statistics/aggregator/ut/ut_analyze_columnshard.cpp

@@ -0,0 +1,39 @@
+#include <ydb/core/statistics/ut_common/ut_common.h>
+
+#include <ydb/library/actors/testlib/test_runtime.h>
+
+#include <thread>
+
+namespace NKikimr {
+namespace NStat {
+
+namespace {
+
+
+} // namespace
+
+Y_UNIT_TEST_SUITE(AnalyzeColumnshard) {
+
+    Y_UNIT_TEST(AnalyzeOneColumnTable) {
+        TTestEnv env(1, 1);
+        auto init = [&] () {
+            CreateDatabase(env, "Database");
+            CreateColumnStoreTable(env, "Database", "Table", 1);
+        };
+        std::thread initThread(init);
+
+        auto& runtime = *env.GetServer().GetRuntime();
+        runtime.SimulateSleep(TDuration::Seconds(30));
+        initThread.join();
+
+        auto sender = runtime.AllocateEdgeActor();
+        ui64 columnShardId = GetColumnTableShards(runtime, sender, "/Root/Database/Table").at(0);
+
+        auto pathId = ResolvePathId(runtime, "/Root/Database/Table", nullptr);
+
+        AnalyzeTable(runtime, pathId, columnShardId);
+    }
+}
+
+} // NStat
+} // NKikimr

ydb/core/statistics/aggregator/ut/ut_aggregator.cpp renamed to ydb/core/statistics/aggregator/ut/ut_analyze_datashard.cpp

@@ -17,7 +17,7 @@ namespace {
 
 } // namespace
 
-Y_UNIT_TEST_SUITE(StatisticsAggregator) {
+Y_UNIT_TEST_SUITE(AnalyzeDatashard) {
 
     Y_UNIT_TEST(ScanOneTable) {
         TTestEnv env(1, 1);
@@ -213,29 +213,6 @@ Y_UNIT_TEST_SUITE(StatisticsAggregator) {
 
         ValidateCountMinAbsense(runtime, pathId);
     }
-
-    Y_UNIT_TEST(ScanOneColumnTable) {
-        TTestEnv env(1, 1);
-        auto init = [&] () {
-            CreateDatabase(env, "Database");
-            CreateColumnStoreTable(env, "Database", "Table", 10);
-        };
-        std::thread initThread(init);
-
-        auto& runtime = *env.GetServer().GetRuntime();
-        runtime.SimulateSleep(TDuration::Seconds(30));
-        initThread.join();
-
-        auto pathId = ResolvePathId(runtime, "/Root/Database/Table");
-
-        runtime.SimulateSleep(TDuration::Seconds(30));
-
-        auto countMin = ExtractCountMin(runtime, pathId);
-
-        ui32 value = 1;
-        auto probe = countMin->Probe((const char *)&value, sizeof(value));
-        UNIT_ASSERT_VALUES_EQUAL(probe, 10);
-    }
 }
 
 } // NStat

ydb/core/statistics/aggregator/ut/ut_traverse_columnshard.cpp

@@ -0,0 +1,47 @@
+#include <ydb/core/statistics/ut_common/ut_common.h>
+
+#include <ydb/library/actors/testlib/test_runtime.h>
+
+#include <ydb/core/testlib/tablet_helpers.h>
+#include <ydb/core/tx/scheme_cache/scheme_cache.h>
+#include <ydb/core/statistics/events.h>
+#include <ydb/core/statistics/service/service.h>
+
+#include <thread>
+
+namespace NKikimr {
+namespace NStat {
+
+namespace {
+
+
+} // namespace
+
+Y_UNIT_TEST_SUITE(TraverseColumnShard) {
+
+    Y_UNIT_TEST(OneColumnTableTraversal) {
+        TTestEnv env(1, 1);
+        auto init = [&] () {
+            CreateDatabase(env, "Database");
+            CreateColumnStoreTable(env, "Database", "Table", 10);
+        };
+        std::thread initThread(init);
+
+        auto& runtime = *env.GetServer().GetRuntime();
+        runtime.SimulateSleep(TDuration::Seconds(30));
+        initThread.join();
+
+        auto pathId = ResolvePathId(runtime, "/Root/Database/Table");
+
+        runtime.SimulateSleep(TDuration::Seconds(30));
+
+        auto countMin = ExtractCountMin(runtime, pathId);
+
+        ui32 value = 1;
+        auto probe = countMin->Probe((const char *)&value, sizeof(value));
+        UNIT_ASSERT_VALUES_EQUAL(probe, 10);
+    }
+}
+
+} // NStat
+} // NKikimr

ydb/core/statistics/aggregator/ut/ya.make

@@ -21,7 +21,9 @@ PEERDIR(
 )
 
 SRCS(
-    ut_aggregator.cpp
+    ut_analyze_datashard.cpp
+    ut_analyze_columnshard.cpp
+    ut_traverse_columnshard.cpp
 )
 
 END()

ydb/core/statistics/ut_common/ut_common.cpp

@@ -323,7 +323,7 @@ void ValidateCountMinAbsense(TTestActorRuntime& runtime, TPathId pathId) {
     UNIT_ASSERT(!rsp.Success);
 }
 
-void AnalyzeTable(TTestActorRuntime& runtime, ui64 tabletId, const TPathId& pathId) {
+void AnalyzeTable(TTestActorRuntime& runtime, const TPathId& pathId, ui64 tabletId) {
     auto ev = std::make_unique<TEvStatistics::TEvAnalyzeTable>();
     auto& record = ev->Record;
     PathIdFromPathId(pathId, record.MutableTable()->MutablePathId());

ydb/core/statistics/ut_common/ut_common.h

@@ -74,7 +74,7 @@ std::shared_ptr<TCountMinSketch> ExtractCountMin(TTestActorRuntime& runtime, TPa
 void ValidateCountMin(TTestActorRuntime& runtime, TPathId pathId);
 void ValidateCountMinAbsense(TTestActorRuntime& runtime, TPathId pathId);
 
-void AnalyzeTable(TTestActorRuntime& runtime, ui64 tabletId, const TPathId& pathId);
+void AnalyzeTable(TTestActorRuntime& runtime, const TPathId& pathId, ui64 tabletId);
 
 } // namespace NStat
 } // namespace NKikimr

ydb/core/tx/columnshard/columnshard__statistics.cpp

@@ -5,6 +5,18 @@
 
 namespace NKikimr::NColumnShard {
 
+void TColumnShard::Handle(NStat::TEvStatistics::TEvAnalyzeTable::TPtr& ev, const TActorContext&) {
+
+    // TODO Start a potentially long analysis process.
+    // ...
+
+
+
+    // Return the response when the analysis is completed
+    auto response = std::make_unique<NStat::TEvStatistics::TEvAnalyzeTableResponse>();
+    Send(ev->Sender, response.release(), 0, ev->Cookie);
+}
+
 void TColumnShard::Handle(NStat::TEvStatistics::TEvStatisticsRequest::TPtr& ev, const TActorContext&) {
     auto response = std::make_unique<NStat::TEvStatistics::TEvStatisticsResponse>();
     auto& record = response->Record;

ydb/core/tx/columnshard/columnshard_impl.h

@@ -224,6 +224,7 @@ class TColumnShard
     void Handle(TEvPrivate::TEvTieringModified::TPtr& ev, const TActorContext&);
     void Handle(TEvPrivate::TEvNormalizerResult::TPtr& ev, const TActorContext&);
 
+    void Handle(NStat::TEvStatistics::TEvAnalyzeTable::TPtr& ev, const TActorContext& ctx);
     void Handle(NStat::TEvStatistics::TEvStatisticsRequest::TPtr& ev, const TActorContext& ctx);
 
     void Handle(NActors::TEvents::TEvUndelivered::TPtr& ev, const TActorContext&);
@@ -380,6 +381,7 @@ class TColumnShard
             HFunc(TEvPrivate::TEvGarbageCollectionFinished, Handle);
             HFunc(TEvPrivate::TEvTieringModified, Handle);
 
+            HFunc(NStat::TEvStatistics::TEvAnalyzeTable, Handle);
             HFunc(NStat::TEvStatistics::TEvStatisticsRequest, Handle);
 
             HFunc(NActors::TEvents::TEvUndelivered, Handle);