yt/error: optimize constructing TError from TErrorException

Here we can avoid dynamic cast and exception hazard.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@tracto.ai>

---

Pull Request resolved: ytsaurus/ytsaurus#1070
commit_hash:e0709e1fe0f2109792b20b850e0e11a6e96f846a

Author: koct9i

library/cpp/yt/error/error-inl.h

@@ -312,6 +312,11 @@ TErrorOr<T>::TErrorOr(TErrorOr<U>&& other) noexcept
     }
 }
 
+template <class T>
+TErrorOr<T>::TErrorOr(const TErrorException& errorEx) noexcept
+    : TError(errorEx)
+{ }
+
 template <class T>
 TErrorOr<T>::TErrorOr(const std::exception& ex)
     : TError(ex)

library/cpp/yt/error/error.cpp

@@ -242,6 +242,12 @@ TError::TErrorOr(TError&& other) noexcept
     : Impl_(std::move(other.Impl_))
 { }
 
+TError::TErrorOr(const TErrorException& errorEx) noexcept
+{
+    *this = errorEx.Error();
+    // NB: TErrorException verifies that error not IsOK at throwing end.
+}
+
 TError::TErrorOr(const std::exception& ex)
 {
     if (auto simpleException = dynamic_cast<const TSimpleException*>(&ex)) {

library/cpp/yt/error/error.h

@@ -56,6 +56,9 @@ void FormatValue(TStringBuilderBase* builder, TErrorCode code, TStringBuf spec);
 
 ////////////////////////////////////////////////////////////////////////////////
 
+// Forward declaration.
+class TErrorException;
+
 template <class TValue>
 concept CErrorNestable = requires (TError& error, TValue&& operand)
 {
@@ -72,6 +75,8 @@ class [[nodiscard]] TErrorOr<void>
     TErrorOr(const TError& other);
     TErrorOr(TError&& other) noexcept;
 
+    TErrorOr(const TErrorException& errorEx) noexcept;
+
     TErrorOr(const std::exception& ex);
 
     struct TDisableFormat
@@ -365,6 +370,8 @@ class [[nodiscard]] TErrorOr
     TErrorOr(const TError& other);
     TErrorOr(TError&& other) noexcept;
 
+    TErrorOr(const TErrorException& errorEx) noexcept;
+
     TErrorOr(const std::exception& ex);
 
     template <class U>