Skip to content

Commit 754220d

Browse files
ivanmorozov333ivanmorozov333
andauthored
fix memory leak (#18578)
Co-authored-by: ivanmorozov333 <imorozov333@ya.ru>
1 parent 9910131 commit 754220d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

ydb/core/tx/columnshard/engines/changes/abstract/abstract.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ class TColumnEngineChanges: public TMoveOnly {
299299
ActivityFlag = flag;
300300
}
301301

302-
std::shared_ptr<TDataAccessorsRequest> ExtractDataAccessorsRequest() const {
302+
std::shared_ptr<TDataAccessorsRequest> ExtractDataAccessorsRequest() {
303303
AFL_VERIFY(!!PortionsToAccess);
304304
return std::move(PortionsToAccess);
305305
}

ydb/core/tx/columnshard/engines/ut/ut_logs_engine.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ bool Compact(TColumnEngineForLogs& engine, TTestDbWrapper& db, TSnapshot snap, N
388388
auto request = changes->ExtractDataAccessorsRequest();
389389
request->RegisterSubscriber(
390390
std::make_shared<TTestCompactionAccessorsSubscriber>(changes, std::make_shared<NOlap::TVersionedIndex>(engine.GetVersionedIndex())));
391-
engine.FetchDataAccessors(changes->ExtractDataAccessorsRequest());
391+
engine.FetchDataAccessors(request);
392392
}
393393
changes->Blobs = std::move(blobs);
394394
NOlap::TConstructionContext context(engine.GetVersionedIndex(), NColumnShard::TIndexationCounters("Compaction"), NOlap::TSnapshot(step, 1));
@@ -478,7 +478,7 @@ bool Ttl(TColumnEngineForLogs& engine, TTestDbWrapper& db, const THashMap<TInter
478478
auto request = changes->ExtractDataAccessorsRequest();
479479
request->RegisterSubscriber(
480480
std::make_shared<TTestCompactionAccessorsSubscriber>(changes, std::make_shared<NOlap::TVersionedIndex>(engine.GetVersionedIndex())));
481-
engine.FetchDataAccessors(changes->ExtractDataAccessorsRequest());
481+
engine.FetchDataAccessors(request);
482482
}
483483
const bool result = engine.ApplyChangesOnTxCreate(changes, TSnapshot(1, 1)) && engine.ApplyChangesOnExecute(db, changes, TSnapshot(1, 1));
484484
NOlap::TWriteIndexContext contextExecute(nullptr, db, engine, TSnapshot(1, 1));

0 commit comments

Comments
 (0)