Skip to content

Commit 7015796

Browse files
committed
fix after merge
1 parent 50195e2 commit 7015796

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

ydb/core/persqueue/partition.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2100,7 +2100,7 @@ TPartition::EProcessResult TPartition::BeginTransaction(const TEvPQ::TEvTxCalcPr
21002100
bool isAffectedConsumer = AffectedUsers.contains(consumer);
21012101
TUserInfoBase& userInfo = GetOrCreatePendingUser(consumer);
21022102

2103-
if (!operation.GetReadSessionId().Empty() && operation.GetReadSessionId() != userInfo.Session) {
2103+
if (!operation.GetReadSessionId().empty() && operation.GetReadSessionId() != userInfo.Session) {
21042104
PQ_LOG_D("Partition " << Partition <<
21052105
" Consumer '" << consumer << "'" <<
21062106
" Bad request (session already dead) " <<

ydb/core/persqueue/read_balancer_app.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ TString TPersQueueReadBalancer::GenerateStat() {
7777
for (auto& [partitionId, partitionInfo] : PartitionsInfo) {
7878
const auto& stats = AggregatedStats.Stats[partitionId];
7979
const auto* node = PartitionGraph.GetPartition(partitionId);
80-
TString style = node && node->Children.empty() ? "text-success" : "text-muted";
80+
TString style = node && node->DirectChildren.empty() ? "text-success" : "text-muted";
8181

8282
TABLER() {
8383
TABLED() {
@@ -87,7 +87,7 @@ TString TPersQueueReadBalancer::GenerateStat() {
8787
}
8888
TABLED() {
8989
if (node) {
90-
str << (node->Children.empty() ? "Active" : "Inactive");
90+
str << (node->DirectChildren.empty() ? "Active" : "Inactive");
9191
if (node->IsRoot()) {
9292
str << " (root)";
9393
}
@@ -96,15 +96,15 @@ TString TPersQueueReadBalancer::GenerateStat() {
9696
TABLED() { HREF(TStringBuilder() << "?TabletID=" << partitionInfo.TabletId) { str << partitionInfo.TabletId; } }
9797
TABLED() {
9898
if (node) {
99-
for (auto* parent : node->Parents) {
99+
for (auto* parent : node->DirectParents) {
100100
HREF("#" + partitionAnchor(parent->Id)) { str << parent->Id; }
101101
str << ", ";
102102
}
103103
}
104104
}
105105
TABLED() {
106106
if (node) {
107-
for (auto* child : node->Children) {
107+
for (auto* child : node->DirectChildren) {
108108
HREF("#" + partitionAnchor(child->Id)) { str << child->Id; }
109109
str << ", ";
110110
}

ydb/services/persqueue_v1/actors/partition_actor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ TPartitionActor::TPartitionActor(
2424
const TActorId& parentId, const TString& clientId, const TString& clientPath, const ui64 cookie,
2525
const TString& session, const TPartitionId& partition, const ui32 generation, const ui32 step,
2626
const ui64 tabletID, const TTopicCounters& counters, bool commitsDisabled,
27-
const TString& clientDC, bool rangesMode, const NPersQueue::TTopicConverterPtr& topic,
27+
const TString& clientDC, bool rangesMode, const NPersQueue::TTopicConverterPtr& topic, const TString& database,
2828
bool directRead, bool useMigrationProtocol, ui32 maxTimeLagMs, ui64 readTimestampMs, std::set<NPQ::TPartitionGraph::Node*> parents,
2929
std::unordered_set<ui64> notCommitedToFinishParents
3030
)

ydb/services/persqueue_v1/actors/partition_actor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class TPartitionActor : public NActors::TActorBootstrapped<TPartitionActor> {
7575
TPartitionActor(const TActorId& parentId, const TString& clientId, const TString& clientPath, const ui64 cookie,
7676
const TString& session, const TPartitionId& partition, ui32 generation, ui32 step,
7777
const ui64 tabletID, const TTopicCounters& counters, const bool commitsDisabled,
78-
const TString& clientDC, bool rangesMode, const NPersQueue::TTopicConverterPtr& topic, bool directRead,
78+
const TString& clientDC, bool rangesMode, const NPersQueue::TTopicConverterPtr& topic, const TString& database, bool directRead,
7979
bool useMigrationProtocol, ui32 maxTimeLagMs, ui64 readTimestampMs, std::set<NPQ::TPartitionGraph::Node*> parents,
8080
std::unordered_set<ui64> notCommitedToFinishParents);
8181
~TPartitionActor();

ydb/services/persqueue_v1/actors/read_session_actor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1254,7 +1254,7 @@ void TReadSessionActor<UseMigrationProtocol>::Handle(TEvPersQueue::TEvLockPartit
12541254
const TActorId actorId = ctx.Register(new TPartitionActor(
12551255
ctx.SelfID, ClientId, ClientPath, Cookie, Session, partitionId, record.GetGeneration(),
12561256
record.GetStep(), record.GetTabletId(), it->second, CommitsDisabled, ClientDC, RangesMode,
1257-
converterIter->second, DirectRead, UseMigrationProtocol, maxLag, readTimestampMs, topic.PartitionGraph->GetPartition(partitionId.Partition)->HierarhicalParents, notCommitedToFinishParents));
1257+
converterIter->second, Request->GetDatabaseName().GetOrElse(AppData(ctx)->PQConfig.GetDatabase()), DirectRead, UseMigrationProtocol, maxLag, readTimestampMs, topic.PartitionGraph->GetPartition(partitionId.Partition)->AllParents, notCommitedToFinishParents));
12581258

12591259
if (SessionsActive) {
12601260
PartsPerSession.DecFor(Partitions.size(), 1);

0 commit comments

Comments
 (0)