Skip to content

Commit 6b0e4a4

Browse files
authored
Add node name to labels (#8237)
1 parent 727613b commit 6b0e4a4

File tree

3 files changed

+22
-5
lines changed

3 files changed

+22
-5
lines changed

ydb/core/config/init/init.cpp

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,8 @@ class TDefaultNodeBrokerClient
142142
const NYdb::NDiscovery::TNodeRegistrationResult& result,
143143
NKikimrConfig::TAppConfig& appConfig,
144144
ui32& nodeId,
145-
TKikimrScopeId& outScopeId)
145+
TKikimrScopeId& outScopeId,
146+
TString& outNodeName)
146147
{
147148
nodeId = result.GetNodeId();
148149
NActors::TScopeId scopeId;
@@ -168,6 +169,7 @@ class TDefaultNodeBrokerClient
168169
NConfig::CopyNodeLocation(nodeInfo.MutableLocation(), node.Location);
169170
if (result.HasNodeName()) {
170171
nodeInfo.SetName(result.GetNodeName());
172+
outNodeName = result.GetNodeName();
171173
}
172174
} else {
173175
auto &info = *nsConfig.AddNode();
@@ -187,8 +189,13 @@ class TDefaultNodeBrokerClient
187189
: Result(std::move(result))
188190
{}
189191

190-
void Apply(NKikimrConfig::TAppConfig& appConfig, ui32& nodeId, TKikimrScopeId& scopeId) const override {
191-
ProcessRegistrationDynamicNodeResult(Result, appConfig, nodeId, scopeId);
192+
void Apply(
193+
NKikimrConfig::TAppConfig& appConfig,
194+
ui32& nodeId,
195+
TKikimrScopeId& scopeId,
196+
TString& nodeName) const override
197+
{
198+
ProcessRegistrationDynamicNodeResult(Result, appConfig, nodeId, scopeId, nodeName);
192199
}
193200
};
194201

ydb/core/config/init/init.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,11 @@ struct TNodeRegistrationSettings {
124124
class INodeRegistrationResult {
125125
public:
126126
virtual ~INodeRegistrationResult() {}
127-
virtual void Apply(NKikimrConfig::TAppConfig& appConfig, ui32& nodeId, TKikimrScopeId& scopeId) const = 0;
127+
virtual void Apply(
128+
NKikimrConfig::TAppConfig& appConfig,
129+
ui32& nodeId,
130+
TKikimrScopeId& scopeId,
131+
TString& nodeName) const = 0;
128132
};
129133

130134
class INodeBrokerClient {

ydb/core/config/init/init_impl.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1019,6 +1019,7 @@ class TInitialConfiguratorImpl
10191019
TKikimrScopeId ScopeId;
10201020
TString TenantName;
10211021
TString ClusterName;
1022+
TString NodeName;
10221023

10231024
TMap<TString, TString> Labels;
10241025

@@ -1262,7 +1263,7 @@ class TInitialConfiguratorImpl
12621263

12631264
auto result = NodeBrokerClient.RegisterDynamicNode(cf.GrpcSslSettings, addrs, settings, Env, Logger);
12641265

1265-
result->Apply(AppConfig, NodeId, ScopeId);
1266+
result->Apply(AppConfig, NodeId, ScopeId, NodeName);
12661267
}
12671268

12681269
void ApplyConfigForNode(NKikimrConfig::TAppConfig &appConfig) {
@@ -1292,6 +1293,11 @@ class TInitialConfiguratorImpl
12921293
Labels["node_id"] = ToString(NodeId);
12931294
AddLabelToAppConfig("node_id", Labels["node_id"]);
12941295

1296+
if (!NodeName.Empty()) {
1297+
Labels["node_name"] = NodeName;
1298+
AddLabelToAppConfig("node_name", Labels["node_name"]);
1299+
}
1300+
12951301
if (CommonAppOptions.IgnoreCmsConfigs) {
12961302
return;
12971303
}

0 commit comments

Comments
 (0)