Copy table should not check feature flags for columns types (#17290)

Author: azevaykin

ydb/core/tx/schemeshard/schemeshard__operation_copy_table.cpp

@@ -578,10 +578,12 @@ class TCopyTable: public TSubOperation {
 
         const NScheme::TTypeRegistry* typeRegistry = AppData()->TypeRegistry;
         const TSchemeLimits& limits = domainInfo->GetSchemeLimits();
+        // Copy table should not check feature flags for columns types.
+        // If the types in original table are created then they should be allowed in destination table.
         const TTableInfo::TCreateAlterDataFeatureFlags featureFlags = {
-            .EnableTablePgTypes = AppData()->FeatureFlags.GetEnableTablePgTypes(),
-            .EnableTableDatetime64 = AppData()->FeatureFlags.GetEnableTableDatetime64(),
-            .EnableParameterizedDecimal = AppData()->FeatureFlags.GetEnableParameterizedDecimal(),        
+            .EnableTablePgTypes = true,
+            .EnableTableDatetime64 = true,
+            .EnableParameterizedDecimal = true,
             };
         TTableInfo::TAlterDataPtr alterData = TTableInfo::CreateAlterData(nullptr, schema, *typeRegistry,
             limits, *domainInfo, featureFlags, errStr, LocalSequences);

ydb/core/tx/schemeshard/ut_base/ut_table_decimal_types.cpp

@@ -107,6 +107,39 @@ Y_UNIT_TEST_SUITE(TSchemeShardDecimalTypesInTables) {
         });        
     }
 
+    Y_UNIT_TEST(CopyTableShouldNotFailOnDisabledFeatureFlag) {
+        TTestBasicRuntime runtime;
+        TTestEnv env(runtime, TTestEnvOptions().EnableParameterizedDecimal(true));
+        ui64 txId = 100;
+
+        AsyncCreateTable(runtime, ++txId, "/MyRoot", R"_(
+            Name: "Table1"
+            Columns { Name: "key"   Type: "Decimal(35,6)" }
+            Columns { Name: "value" Type: "Decimal(35,6)" }
+            KeyColumnNames: ["key"]
+        )_");
+        TestModificationResults(runtime, txId, {TExpectedResult(NKikimrScheme::StatusAccepted)});
+        env.TestWaitNotification(runtime, txId);
+
+        TestDescribeResult(DescribePath(runtime, "/MyRoot/Table1"), {
+            NLs::PathExist,
+            NLs::Finished,
+            NLs::CheckColumnType(0, "Decimal(35,6)")
+        });
+
+        runtime.GetAppData().FeatureFlags.SetEnableParameterizedDecimal(false);
+
+        AsyncCopyTable(runtime, ++txId, "/MyRoot", "Copy1", "/MyRoot/Table1");
+        TestModificationResults(runtime, txId, {TExpectedResult(NKikimrScheme::StatusAccepted)});
+        env.TestWaitNotification(runtime, txId);
+
+        TestDescribeResult(DescribePath(runtime, "/MyRoot/Copy1"), {
+            NLs::PathExist,
+            NLs::Finished,
+            NLs::CheckColumnType(0, "Decimal(35,6)")
+        });        
+    }    
+
     Y_UNIT_TEST(CreateWithWrongParameters) {
         TTestBasicRuntime runtime;
         TTestEnv env(runtime, TTestEnvOptions().EnableParameterizedDecimal(true));