Skip to content

Commit 669605c

Browse files
authored
increase CS read timeout (#6963)
1 parent 184bf80 commit 669605c

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

ydb/core/protos/config.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1519,6 +1519,7 @@ message TColumnShardConfig {
15191519

15201520
optional uint32 MaxInFlightIntervalsOnRequest = 16;
15211521
optional uint32 MaxInFlightMemoryOnRequest = 17;
1522+
optional uint32 MaxReadStaleness_ms = 18 [default = 300000];
15221523
}
15231524

15241525
message TSchemeShardConfig {

ydb/core/tx/columnshard/columnshard_impl.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ TColumnShard::TColumnShard(TTabletStorageInfo* info, const TActorId& tablet)
8383
, WritesMonitor(*this)
8484
, NormalizerController(StoragesManager, SubscribeCounters)
8585
, SysLocks(this)
86+
, MaxReadStaleness(TDuration::MilliSeconds(AppDataVerified().ColumnShardConfig.GetMaxReadStaleness_ms()))
8687
{
8788
TabletCountersPtr.reset(new TProtobufTabletCounters<
8889
ESimpleCounters_descriptor,
@@ -192,7 +193,7 @@ ui64 TColumnShard::GetOutdatedStep() const {
192193
}
193194

194195
ui64 TColumnShard::GetMinReadStep() const {
195-
const TDuration maxReadStaleness = NYDBTest::TControllers::GetColumnShardController()->GetReadTimeoutClean(TDuration::Minutes(5));
196+
const TDuration maxReadStaleness = NYDBTest::TControllers::GetColumnShardController()->GetReadTimeoutClean(MaxReadStaleness);
196197
ui64 delayMillisec = maxReadStaleness.MilliSeconds();
197198
ui64 passedStep = GetOutdatedStep();
198199
ui64 minReadStep = (passedStep > delayMillisec ? passedStep - delayMillisec : 0);

ydb/core/tx/columnshard/columnshard_impl.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -532,6 +532,7 @@ class TColumnShard
532532
TLimits Limits;
533533
NOlap::TNormalizationController NormalizerController;
534534
NDataShard::TSysLocks SysLocks;
535+
const TDuration MaxReadStaleness;
535536

536537
void TryRegisterMediatorTimeCast();
537538
void UnregisterMediatorTimeCast();

0 commit comments

Comments
 (0)