Skip to content

Commit 625acf6

Browse files
Backward proto compatibility fix (#18752)
1 parent 8846b9e commit 625acf6

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

ydb/library/yql/providers/solomon/common/util.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,15 @@ NProto::TDqSolomonSource FillSolomonSource(const TSolomonClusterConfig* config,
5252
source.SetProject(project);
5353
}
5454

55+
source.SetEndpoint(config->GetCluster()); // Backward compatibility
5556
source.SetHttpEndpoint(config->GetCluster());
57+
source.SetGrpcEndpoint(config->GetCluster());
5658
for (const auto& attr : config->settings()) {
5759
if (attr.name() == "grpc_location"sv) {
5860
source.SetGrpcEndpoint(attr.value());
5961
}
6062
}
6163

62-
if (source.GetGrpcEndpoint().empty()) {
63-
source.SetGrpcEndpoint(config->GetCluster());
64-
}
65-
6664
return source;
6765
}
6866

ydb/library/yql/providers/solomon/proto/dq_solomon_shard.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ message TDownsampling {
4949

5050
message TDqSolomonSource {
5151
ESolomonClusterType ClusterType = 1;
52-
reserved 2;
52+
string Endpoint = 2; // deprecated
5353
bool UseSsl = 3;
5454
string ServiceAccount = 4;
5555
TToken Token = 5;

0 commit comments

Comments
 (0)