YQL-19974 fixed handling error type in UnionAll

commit_hash:9aaecf82f8c99c7576eedbfc43572a8722ea774d

Author: vitstn

yql/essentials/core/type_ann/type_ann_list.cpp

@@ -2793,15 +2793,17 @@ namespace {
             const auto structType = itemType->Cast<TStructExprType>();
             for (const auto& item: structType->GetItems()) {
                 if (const auto res = members.insert({ item->GetName(), { item->GetItemType(), 1U } }); !res.second) {
-                    if (item->GetItemType()->GetKind() == ETypeAnnotationKind::Error) {
+                    auto& p = res.first->second;
+                    if (p.first->GetKind() == ETypeAnnotationKind::Error) {
                         continue;
                     }
 
-                    auto& p = res.first->second;
-                    if (p.first->GetKind() == ETypeAnnotationKind::Error) {
+                    if (item->GetItemType()->GetKind() == ETypeAnnotationKind::Error) {
+                        p.first = item->GetItemType();
                         continue;
                     }
 
+
                     if (const auto commonType = CommonType<false, true>(input.Pos(), p.first, item->GetItemType(), ctx.Expr)) {
                         p.first = commonType;
                         ++p.second;

yql/essentials/tests/sql/minirun/part1/canondata/result.json

@@ -1342,6 +1342,20 @@
             "uri": "https://{canondata_backend}/995452/57f8b127ed5fa9fae2dd5ebb0f5870d86a7fcd2f/resource.tar.gz#test.test_udf-trivial_udf--Results_/results.txt"
         }
     ],
+    "test.test[union_all-error_second_field-default.txt-Debug]": [
+        {
+            "checksum": "0e23b9479096e1474819855af204990f",
+            "size": 321,
+            "uri": "https://{canondata_backend}/1784117/c1c7de2cd671e324140e51d7eda942f845f3a5be/resource.tar.gz#test.test_union_all-error_second_field-default.txt-Debug_/opt.yql"
+        }
+    ],
+    "test.test[union_all-error_second_field-default.txt-Results]": [
+        {
+            "checksum": "e6fa6c1cd5fcb0365c8d37188d57098a",
+            "size": 762,
+            "uri": "https://{canondata_backend}/1784117/c1c7de2cd671e324140e51d7eda942f845f3a5be/resource.tar.gz#test.test_union_all-error_second_field-default.txt-Results_/results.txt"
+        }
+    ],
     "test.test[window-null_type-default.txt-Debug]": [
         {
             "checksum": "a9dd7e899e45fb72b95d82be22e38ede",

yql/essentials/tests/sql/sql2yql/canondata/result.json

@@ -7307,6 +7307,13 @@
             "uri": "https://{canondata_backend}/1942173/99e88108149e222741552e7e6cddef041d6a2846/resource.tar.gz#test_sql2yql.test_union-union_positional_mix_/sql.yql"
         }
     ],
+    "test_sql2yql.test[union_all-error_second_field]": [
+        {
+            "checksum": "ee8f002843aa9d876e3e84729b0332b0",
+            "size": 2331,
+            "uri": "https://{canondata_backend}/1784117/c3b861ffaf877046c3bd4b07e953f45f2a989267/resource.tar.gz#test_sql2yql.test_union_all-error_second_field_/sql.yql"
+        }
+    ],
     "test_sql2yql.test[union_all-union_all_incompatible]": [
         {
             "checksum": "0d3672847d7b84c142611d095eb38cc2",
@@ -11261,6 +11268,11 @@
             "uri": "file://test_sql_format.test_union-union_positional_mix_/formatted.sql"
         }
     ],
+    "test_sql_format.test[union_all-error_second_field]": [
+        {
+            "uri": "file://test_sql_format.test_union_all-error_second_field_/formatted.sql"
+        }
+    ],
     "test_sql_format.test[union_all-union_all_incompatible]": [
         {
             "uri": "file://test_sql_format.test_union_all-union_all_incompatible_/formatted.sql"

yql/essentials/tests/sql/sql2yql/canondata/test_sql_format.test_union_all-error_second_field_/formatted.sql

@@ -0,0 +1,13 @@
+PRAGMA warning('disable', '4510');
+
+SELECT
+    y
+FROM (
+    SELECT
+        0 AS y,
+        1 AS x
+    UNION ALL
+    SELECT
+        1 AS y,
+        Yql::Error(Yql::ErrorType(AsAtom('1'), AsAtom('2'), AsAtom(''), AsAtom('foo'))) AS x
+);

yql/essentials/tests/sql/suites/union_all/error_second_field.sql

@@ -0,0 +1,7 @@
+pragma warning("disable","4510");
+select y from (
+select 0 as y, 1 as x
+union all 
+select 1 as y, Yql::Error(Yql::ErrorType(AsAtom('1'),AsAtom('2'),AsAtom(''),AsAtom('foo'))) as x
+)
+