YT-23616: Do not rely on 4xx http codes

hiddenpath · hiddenpath · commit 5bf080f68ee2 · 2025-02-17T18:02:04.000+03:00
commit_hash:180c7545c76e0286472079ec129fd15f2e140aa9
diff --git a/yt/cpp/mapreduce/common/retry_lib.cpp b/yt/cpp/mapreduce/common/retry_lib.cpp
@@ -203,13 +203,9 @@ static bool IsRetriableChunkError(const TSet<int>& codes)
 
 static TMaybe<TDuration> TryGetBackoffDuration(const TErrorResponse& errorResponse, const TConfigPtr& config)
 {
-    int httpCode = errorResponse.GetHttpCode();
-    if (httpCode / 100 != 4 && !errorResponse.IsFromTrailers()) {
-        return config->RetryInterval;
-    }
-
     auto allCodes = errorResponse.GetError().GetAllErrorCodes();
     using namespace NClusterErrorCodes;
+
     if (allCodes.count(NSecurityClient::RequestQueueSizeLimitExceeded) ||
         allCodes.count(NRpc::RequestQueueSizeLimitExceeded))
     {

Original file line number	Diff line number	Diff line change
`@@ -203,13 +203,9 @@ static bool IsRetriableChunkError(const TSet<int>& codes)`
`203`	`203`
`204`	`204`	`static TMaybe<TDuration> TryGetBackoffDuration(const TErrorResponse& errorResponse, const TConfigPtr& config)`
`205`	`205`	`{`
`206`		`- int httpCode = errorResponse.GetHttpCode();`
`207`		`- if (httpCode / 100 != 4 && !errorResponse.IsFromTrailers()) {`
`208`		`- return config->RetryInterval;`
`209`		`- }`
`210`		`-`
`211`	`206`	`auto allCodes = errorResponse.GetError().GetAllErrorCodes();`
`212`	`207`	`using namespace NClusterErrorCodes;`
	`208`	`+`
`213`	`209`	`if (allCodes.count(NSecurityClient::RequestQueueSizeLimitExceeded) \|\|`
`214`	`210`	`allCodes.count(NRpc::RequestQueueSizeLimitExceeded))`
`215`	`211`	`{`