Skip to content

Commit 5b45c74

Browse files
authored
Added enable_antlr4_parser feature flag (#11764)
1 parent fef9bc2 commit 5b45c74

File tree

5 files changed

+5
-1
lines changed

5 files changed

+5
-1
lines changed

ydb/core/kqp/host/kqp_host.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1295,7 +1295,7 @@ class TKqpHost : public IKqpHost {
12951295
.SetQueryParameters(query.ParameterTypes)
12961296
.SetApplicationName(ApplicationName)
12971297
.SetIsEnablePgSyntax(SessionCtx->Config().FeatureFlags.GetEnablePgSyntax())
1298-
.SetIsEnableAntlr4Parser(SessionCtx->Config().EnableAntlr4Parser);
1298+
.SetIsEnableAntlr4Parser(SessionCtx->Config().FeatureFlags.GetEnableAntlr4Parser() || SessionCtx->Config().EnableAntlr4Parser);
12991299
NSQLTranslation::TTranslationSettings effectiveSettings;
13001300
auto astRes = ParseQuery(
13011301
query.Text,

ydb/core/kqp/provider/yql_kikimr_settings.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ TKikimrConfiguration::TKikimrConfiguration() {
5959
REGISTER_SETTING(*this, _KqpSlowLogNoticeThresholdMs);
6060
REGISTER_SETTING(*this, _KqpSlowLogTraceThresholdMs);
6161
REGISTER_SETTING(*this, _KqpYqlSyntaxVersion);
62+
REGISTER_SETTING(*this, _KqpYqlAntlr4Parser);
6263
REGISTER_SETTING(*this, _KqpAllowUnsafeCommit);
6364
REGISTER_SETTING(*this, _KqpMaxComputeActors);
6465
REGISTER_SETTING(*this, _KqpEnableSpilling);

ydb/core/kqp/provider/yql_kikimr_settings.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ struct TKikimrSettings {
3434
NCommon::TConfSetting<ui32, false> _KqpSlowLogNoticeThresholdMs;
3535
NCommon::TConfSetting<ui32, false> _KqpSlowLogTraceThresholdMs;
3636
NCommon::TConfSetting<ui32, false> _KqpYqlSyntaxVersion;
37+
NCommon::TConfSetting<bool, false> _KqpYqlAntlr4Parser;
3738
NCommon::TConfSetting<bool, false> _KqpAllowUnsafeCommit;
3839
NCommon::TConfSetting<ui32, false> _KqpMaxComputeActors;
3940
NCommon::TConfSetting<bool, false> _KqpEnableSpilling;

ydb/core/protos/feature_flags.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,4 +176,5 @@ message TFeatureFlags {
176176
optional bool EnableTopicAutopartitioningForReplication = 151 [default = false];
177177
optional bool EnableDriveSerialsDiscovery = 152 [default = false];
178178
optional bool EnableSeparateDiskSpaceQuotas = 153 [default = false];
179+
optional bool EnableAntlr4Parser = 154 [default = false];
179180
}

ydb/core/testlib/basics/feature_flags.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ class TTestFeatureFlagsHolder {
6565
FEATURE_FLAG_SETTER(EnableBackupService)
6666
FEATURE_FLAG_SETTER(EnableGranularTimecast)
6767
FEATURE_FLAG_SETTER(EnablePgSyntax)
68+
FEATURE_FLAG_SETTER(EnableAntlr4Parser)
6869
FEATURE_FLAG_SETTER(EnableTieringInColumnShard)
6970
FEATURE_FLAG_SETTER(EnableMetadataObjectsOnServerless)
7071
FEATURE_FLAG_SETTER(EnableOlapCompression)

0 commit comments

Comments
 (0)