fix crash in storage/groups (#11268)

Author: adameat

ydb/core/viewer/storage_groups.h

@@ -131,9 +131,13 @@ class TStorageGroups : public TViewerPipeClient {
     // BSC
     bool FallbackToWhiteboard = false;
     std::optional<TRequestResponse<NSysView::TEvSysView::TEvGetGroupsResponse>> GetGroupsResponse;
+    bool GetGroupsResponseProcessed = false;
     std::optional<TRequestResponse<NSysView::TEvSysView::TEvGetStoragePoolsResponse>> GetStoragePoolsResponse;
+    bool GetStoragePoolsResponseProcessed = false;
     std::optional<TRequestResponse<NSysView::TEvSysView::TEvGetVSlotsResponse>> GetVSlotsResponse;
+    bool GetVSlotsResponseProcessed = false;
     std::optional<TRequestResponse<NSysView::TEvSysView::TEvGetPDisksResponse>> GetPDisksResponse;
+    bool GetPDisksResponseProcessed = false;
 
     // Whiteboard
     std::optional<TRequestResponse<TEvInterconnect::TEvNodesInfo>> NodesInfo;
@@ -1270,7 +1274,10 @@ class TStorageGroups : public TViewerPipeClient {
     }
 
     bool AreBSControllerRequestsDone() const {
-        return !GetGroupsResponse && !GetStoragePoolsResponse && !GetVSlotsResponse && !GetPDisksResponse;
+        return (!GetGroupsResponse || GetGroupsResponseProcessed) &&
+               (!GetStoragePoolsResponse || GetStoragePoolsResponseProcessed) &&
+               (!GetVSlotsResponse || GetVSlotsResponseProcessed) &&
+               (!GetPDisksResponse || GetPDisksResponseProcessed);
     }
 
     bool TimeToAskWhiteboard() const {
@@ -1281,7 +1288,7 @@ class TStorageGroups : public TViewerPipeClient {
 
     void ProcessResponses() {
         AddEvent("ProcessResponses");
-        if (GetGroupsResponse && GetGroupsResponse->IsDone()) {
+        if (GetGroupsResponse && GetGroupsResponse->IsDone() && !GetGroupsResponseProcessed) {
             if (GetGroupsResponse->IsOk()) {
                 GroupData.reserve(GetGroupsResponse->Get()->Record.EntriesSize());
                 for (const NKikimrSysView::TGroupEntry& entry : GetGroupsResponse->Get()->Record.GetEntries()) {
@@ -1310,9 +1317,9 @@ class TStorageGroups : public TViewerPipeClient {
             } else {
                 AddProblem("bsc-storage-groups-no-data");
             }
-            GetGroupsResponse.reset();
+            GetGroupsResponseProcessed = true;
         }
-        if (FieldsAvailable.test(+EGroupFields::GroupId) && GetStoragePoolsResponse && GetStoragePoolsResponse->IsDone()) {
+        if (FieldsAvailable.test(+EGroupFields::GroupId) && GetStoragePoolsResponse && GetStoragePoolsResponse->IsDone() && !GetStoragePoolsResponseProcessed) {
             if (GetStoragePoolsResponse->IsOk()) {
                 std::unordered_map<std::pair<ui64, ui64>, const NKikimrSysView::TStoragePoolInfo*> indexStoragePool; // (box, id) -> pool
                 for (const NKikimrSysView::TStoragePoolEntry& entry : GetStoragePoolsResponse->Get()->Record.GetEntries()) {
@@ -1353,9 +1360,9 @@ class TStorageGroups : public TViewerPipeClient {
             } else {
                 AddProblem("bsc-storage-pools-no-data");
             }
-            GetStoragePoolsResponse.reset();
+            GetStoragePoolsResponseProcessed = true;
         }
-        if (FieldsAvailable.test(+EGroupFields::GroupId) && GetVSlotsResponse && GetVSlotsResponse->IsDone()) {
+        if (FieldsAvailable.test(+EGroupFields::GroupId) && GetVSlotsResponse && GetVSlotsResponse->IsDone() && !GetVSlotsResponseProcessed) {
             if (GetVSlotsResponse->IsOk()) {
                 if (GroupsByGroupId.empty()) {
                     RebuildGroupsByGroupId();
@@ -1386,9 +1393,9 @@ class TStorageGroups : public TViewerPipeClient {
             } else {
                 AddProblem("bsc-vslots-no-data");
             }
-            GetVSlotsResponse.reset();
+            GetVSlotsResponseProcessed = true;
         }
-        if (GetPDisksResponse && GetPDisksResponse->IsDone()) {
+        if (GetPDisksResponse && GetPDisksResponse->IsDone() && !GetPDisksResponseProcessed) {
             if (GetPDisksResponse->IsOk()) {
                 for (const NKikimrSysView::TPDiskEntry& entry : GetPDisksResponse->Get()->Record.GetEntries()) {
                     const NKikimrSysView::TPDiskKey& key = entry.GetKey();
@@ -1414,7 +1421,7 @@ class TStorageGroups : public TViewerPipeClient {
             } else {
                 AddProblem("bsc-pdisks-no-data");
             }
-            GetPDisksResponse.reset();
+            GetPDisksResponseProcessed = true;;
         }
         if (FieldsAvailable.test(+EGroupFields::VDisk)) {
             if (FieldsNeeded(FieldsGroupState)) {