Skip to content

Commit 403d37f

Browse files
authored
Drop unused flag in IsYtCompleteIsolatedLambda (#7587)
1 parent 3a7b275 commit 403d37f

14 files changed

+62
-64
lines changed

ydb/library/yql/providers/yt/provider/phy_opt/yql_yt_phy_opt_join.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::EquiJoin(TExprBase node
3131
}
3232
if (auto maybeFlatMap = list.Maybe<TCoFlatMapBase>()) {
3333
TSyncMap syncList;
34-
if (!IsYtCompleteIsolatedLambda(maybeFlatMap.Cast().Lambda().Ref(), syncList, usedCluster, true, false)) {
34+
if (!IsYtCompleteIsolatedLambda(maybeFlatMap.Cast().Lambda().Ref(), syncList, usedCluster, false)) {
3535
return node;
3636
}
3737
list = maybeFlatMap.Cast().Input();
3838
}
3939
if (!IsYtProviderInput(list)) {
4040
TSyncMap syncList;
41-
if (!IsYtCompleteIsolatedLambda(list.Ref(), syncList, usedCluster, true, false)) {
41+
if (!IsYtCompleteIsolatedLambda(list.Ref(), syncList, usedCluster, false)) {
4242
return node;
4343
}
4444
continue;
@@ -84,7 +84,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::EquiJoin(TExprBase node
8484
if (auto maybeFlatMap = listStepForward.Maybe<TCoFlatMapBase>()) {
8585
auto flatMap = maybeFlatMap.Cast();
8686
if (IsLambdaSuitableForPullingIntoEquiJoin(flatMap, joinInput.Scope().Ref(), tableKeysMap, extractedMembers.Get())) {
87-
if (!IsYtCompleteIsolatedLambda(flatMap.Lambda().Ref(), worldList, usedCluster, true, false)) {
87+
if (!IsYtCompleteIsolatedLambda(flatMap.Lambda().Ref(), worldList, usedCluster, false)) {
8888
return node;
8989
}
9090

@@ -134,7 +134,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::EquiJoin(TExprBase node
134134
}
135135
else {
136136
TSyncMap syncList;
137-
if (!IsYtCompleteIsolatedLambda(list.Ref(), syncList, usedCluster, true, false)) {
137+
if (!IsYtCompleteIsolatedLambda(list.Ref(), syncList, usedCluster, false)) {
138138
return node;
139139
}
140140

ydb/library/yql/providers/yt/provider/phy_opt/yql_yt_phy_opt_map.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::FlatMap(TExprBase node,
6262

6363
auto cluster = TString{GetClusterName(input)};
6464
TSyncMap syncList;
65-
if (!IsYtCompleteIsolatedLambda(flatMap.Lambda().Ref(), syncList, cluster, true, false)) {
65+
if (!IsYtCompleteIsolatedLambda(flatMap.Lambda().Ref(), syncList, cluster, false)) {
6666
return node;
6767
}
6868

@@ -150,7 +150,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::LMap(TExprBase node, TE
150150

151151
auto cluster = TString{GetClusterName(lmap.Input())};
152152
TSyncMap syncList;
153-
if (!IsYtCompleteIsolatedLambda(lmap.Lambda().Ref(), syncList, cluster, true, false)) {
153+
if (!IsYtCompleteIsolatedLambda(lmap.Lambda().Ref(), syncList, cluster, false)) {
154154
return node;
155155
}
156156

@@ -228,19 +228,19 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::CombineByKey(TExprBase
228228

229229
auto cluster = TString{GetClusterName(input)};
230230
TSyncMap syncList;
231-
if (!IsYtCompleteIsolatedLambda(combineByKey.PreMapLambda().Ref(), syncList, cluster, true, false)) {
231+
if (!IsYtCompleteIsolatedLambda(combineByKey.PreMapLambda().Ref(), syncList, cluster, false)) {
232232
return node;
233233
}
234-
if (!IsYtCompleteIsolatedLambda(combineByKey.KeySelectorLambda().Ref(), syncList, cluster, true, false)) {
234+
if (!IsYtCompleteIsolatedLambda(combineByKey.KeySelectorLambda().Ref(), syncList, cluster, false)) {
235235
return node;
236236
}
237-
if (!IsYtCompleteIsolatedLambda(combineByKey.InitHandlerLambda().Ref(), syncList, cluster, true, false)) {
237+
if (!IsYtCompleteIsolatedLambda(combineByKey.InitHandlerLambda().Ref(), syncList, cluster, false)) {
238238
return node;
239239
}
240-
if (!IsYtCompleteIsolatedLambda(combineByKey.UpdateHandlerLambda().Ref(), syncList, cluster, true, false)) {
240+
if (!IsYtCompleteIsolatedLambda(combineByKey.UpdateHandlerLambda().Ref(), syncList, cluster, false)) {
241241
return node;
242242
}
243-
if (!IsYtCompleteIsolatedLambda(combineByKey.FinishHandlerLambda().Ref(), syncList, cluster, true, false)) {
243+
if (!IsYtCompleteIsolatedLambda(combineByKey.FinishHandlerLambda().Ref(), syncList, cluster, false)) {
244244
return node;
245245
}
246246

ydb/library/yql/providers/yt/provider/phy_opt/yql_yt_phy_opt_misc.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::Mux(TExprBase node, TEx
244244
return node;
245245
}
246246
TSyncMap syncList;
247-
if (!IsYtCompleteIsolatedLambda(child.Ref(), syncList, resultCluster, true, false)) {
247+
if (!IsYtCompleteIsolatedLambda(child.Ref(), syncList, resultCluster, false)) {
248248
return node;
249249
}
250250

@@ -319,7 +319,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::TakeOrSkip(TExprBase no
319319

320320
auto cluster = TString{GetClusterName(input)};
321321
TSyncMap syncList;
322-
if (!IsYtCompleteIsolatedLambda(countBase.Count().Ref(), syncList, cluster, true, false)) {
322+
if (!IsYtCompleteIsolatedLambda(countBase.Count().Ref(), syncList, cluster, false)) {
323323
return node;
324324
}
325325

@@ -558,7 +558,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::Extend(TExprBase node,
558558
return node;
559559
}
560560
TSyncMap syncList;
561-
if (!IsYtCompleteIsolatedLambda(child.Ref(), syncList, resultCluster, true, false)) {
561+
if (!IsYtCompleteIsolatedLambda(child.Ref(), syncList, resultCluster, false)) {
562562
return node;
563563
}
564564

ydb/library/yql/providers/yt/provider/phy_opt/yql_yt_phy_opt_partition.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::PartitionByKey(TExprBas
3535

3636
auto cluster = TString{GetClusterName(input)};
3737
TSyncMap syncList;
38-
if (!IsYtCompleteIsolatedLambda(keySelectorLambda.Ref(), syncList, cluster, true, false)
39-
|| !IsYtCompleteIsolatedLambda(handlerLambda.Ref(), syncList, cluster, true, false)) {
38+
if (!IsYtCompleteIsolatedLambda(keySelectorLambda.Ref(), syncList, cluster, false)
39+
|| !IsYtCompleteIsolatedLambda(handlerLambda.Ref(), syncList, cluster, false)) {
4040
return node;
4141
}
4242

@@ -94,7 +94,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::PartitionByKey(TExprBas
9494
}
9595

9696
TCoLambda sortKeySelectorLambda = partByKey.SortKeySelectorLambda().Cast<TCoLambda>();
97-
if (!IsYtCompleteIsolatedLambda(sortKeySelectorLambda.Ref(), syncList, cluster, true, false)) {
97+
if (!IsYtCompleteIsolatedLambda(sortKeySelectorLambda.Ref(), syncList, cluster, false)) {
9898
return node;
9999
}
100100

ydb/library/yql/providers/yt/provider/phy_opt/yql_yt_phy_opt_push.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::PushDownKeyExtract(TExp
162162

163163
TSyncMap syncList;
164164
for (auto filter: keyFilters) {
165-
if (!IsYtCompleteIsolatedLambda(*filter, syncList, true, false)) {
165+
if (!IsYtCompleteIsolatedLambda(*filter, syncList, false)) {
166166
return node;
167167
}
168168
}

ydb/library/yql/providers/yt/provider/phy_opt/yql_yt_phy_opt_sort.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::Sort(TExprBase node, TE
7373
auto keySelectorLambda = sort.KeySelectorLambda();
7474
auto cluster = TString{GetClusterName(sort.Input())};
7575
TSyncMap syncList;
76-
if (!IsYtCompleteIsolatedLambda(keySelectorLambda.Ref(), syncList, cluster, true, false)) {
76+
if (!IsYtCompleteIsolatedLambda(keySelectorLambda.Ref(), syncList, cluster, false)) {
7777
return node;
7878
}
7979

ydb/library/yql/providers/yt/provider/phy_opt/yql_yt_phy_opt_write.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::DqWrite(TExprBase node,
4343
}
4444

4545
TSyncMap syncList;
46-
if (!IsYtCompleteIsolatedLambda(write.Content().Ref(), syncList, true, true)) {
46+
if (!IsYtCompleteIsolatedLambda(write.Content().Ref(), syncList, true)) {
4747
return node;
4848
}
4949

@@ -554,7 +554,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::ReplaceStatWriteTable(T
554554

555555
TString cluster;
556556
TSyncMap syncList;
557-
if (!IsYtCompleteIsolatedLambda(input.Ref(), syncList, cluster, true, false)) {
557+
if (!IsYtCompleteIsolatedLambda(input.Ref(), syncList, cluster, false)) {
558558
return node;
559559
}
560560

@@ -710,7 +710,7 @@ TMaybeNode<TExprBase> TYtPhysicalOptProposalTransformer::Fill(TExprBase node, TE
710710

711711
auto cluster = TString{write.DataSink().Cluster().Value()};
712712
TSyncMap syncList;
713-
if (!IsYtCompleteIsolatedLambda(write.Content().Ref(), syncList, cluster, true, false)) {
713+
if (!IsYtCompleteIsolatedLambda(write.Content().Ref(), syncList, cluster, false)) {
714714
return node;
715715
}
716716

ydb/library/yql/providers/yt/provider/yql_yt_datasource.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ class TYtDataSource : public TDataProviderBase {
270270

271271
bool CanBuildResult(const TExprNode& node, TSyncMap& syncList) override {
272272
TString usedCluster;
273-
return IsYtCompleteIsolatedLambda(node, syncList, usedCluster, true, false);
273+
return IsYtCompleteIsolatedLambda(node, syncList, usedCluster, false);
274274
}
275275

276276
bool GetExecWorld(const TExprNode::TPtr& node, TExprNode::TPtr& root) override {

ydb/library/yql/providers/yt/provider/yql_yt_datasource_exec.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ class TYtDataSourceExecTransformer : public TExecTransformerBase {
114114

115115
TString usedCluster;
116116
TSyncMap syncList;
117-
if (!IsYtIsolatedLambda(data.Ref(), syncList, usedCluster, true, false)) {
117+
if (!IsYtIsolatedLambda(data.Ref(), syncList, usedCluster, false)) {
118118
ctx.AddError(TIssue(ctx.GetPosition(data.Pos()), TStringBuilder() << "Failed to execute node due to bad graph: " << input->Content()));
119119
return SyncError();
120120
}

ydb/library/yql/providers/yt/provider/yql_yt_dq_optimize.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class TYtDqOptimizers: public TDqOptimizationBase {
9797
}
9898

9999
TSyncMap syncList;
100-
if (!IsYtCompleteIsolatedLambda(count.Count().Ref(), syncList, cluster, true, false)) {
100+
if (!IsYtCompleteIsolatedLambda(count.Count().Ref(), syncList, cluster, false)) {
101101
return read;
102102
}
103103

0 commit comments

Comments
 (0)