Skip to content

Commit 3890544

Browse files
author
babenko
committed
NB cosmetics
commit_hash:b7a2eef93e6ea33ff1d21cc269f30a5e58f9ff0f
1 parent 849c2c6 commit 3890544

39 files changed

+46
-46
lines changed

yt/yt/client/api/rpc_proxy/client_impl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ IChannelPtr TClient::CreateSequoiaAwareRetryingChannel(IChannelPtr channel, bool
101101
{
102102
const auto& config = Connection_->GetConfig();
103103
bool retrySequoiaErrorsOnly = !config->EnableRetries;
104-
// NB: even if client's retries are disabled Sequoia transient failures are
104+
// NB: Even if client's retries are disabled Sequoia transient failures are
105105
// still retriable. See IsRetriableError().
106106
return CreateRetryingChannel(
107107
config->RetryingChannel,

yt/yt/client/chunk_client/read_limit.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ class TReadLimit
170170
TReadLimit ToExactUpperCounterpart() const;
171171

172172
//! Return inverted read limit, i.e. integer selectors remain as is and key bound is inverted.
173-
//! NB: this method makes YT_VERIFY that read limit contains exactly one selector. Otherwise
173+
//! NB: This method makes YT_VERIFY that read limit contains exactly one selector. Otherwise
174174
//! semantics of such method is weird.
175175
TReadLimit Invert() const;
176176

yt/yt/client/driver/cypress_commands.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ void TListCommand::Register(TRegistrar registrar)
170170
{
171171
registrar.Parameter("path", &TThis::Path);
172172

173-
// NB: default value is an empty filter in contrast to GetCommand, for which it is the universal filter.
173+
// NB: Default value is an empty filter in contrast to GetCommand, for which it is the universal filter.
174174
// Refer to YT-5543 for details.
175175
registrar.ParameterWithUniversalAccessor<TAttributeFilter>(
176176
"attributes",

yt/yt/client/queue_client/consumer_client.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ class TGenericConsumerClient
445445
YT_ABORT();
446446
}
447447

448-
// NB: in BigRT offsets encode the last read row, while we operate with the first unread row.
448+
// NB: In BigRT offsets encode the last read row, while we operate with the first unread row.
449449
auto partitionInfo = TPartitionInfo{
450450
.PartitionIndex = FromUnversionedValue<i64>(partitionIndexValue),
451451
.NextRowIndex = offset,

yt/yt/client/table_client/columnar.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ void BuildDictionaryIndexesFromDictionaryIndexesWithZeroNull(
402402
const auto* currentInput = beginInput;
403403
auto* currentOutput = dst.Begin();
404404
while (currentInput < endInput) {
405-
// NB: null becomes FFFFFFFF.
405+
// NB: Null becomes FFFFFFFF.
406406
*currentOutput++ = (*currentInput++) - 1;
407407
}
408408
}

yt/yt/client/table_client/helpers.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ TVersionedOwningRow YsonToVersionedRow(
354354
const std::vector<TTimestamp>& deleteTimestamps,
355355
const std::vector<TTimestamp>& extraWriteTimestamps)
356356
{
357-
// NB: this implementation is extra slow, it is intended only for using in tests.
357+
// NB: This implementation is extra slow, it is intended only for using in tests.
358358
auto rowBuffer = New<TRowBuffer>();
359359
auto row = YsonToVersionedRow(rowBuffer, keyYson, valueYson, deleteTimestamps, extraWriteTimestamps);
360360
return TVersionedOwningRow(row);

yt/yt/client/table_client/key.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class TKey
2323
static TKey FromRow(TUnversionedRow row, std::optional<int> length = {});
2424

2525
//! Same as above, but does not check that row does not contain sentinels.
26-
//! NB: in debug mode value type check is still performed, but results in YT_ABORT().
26+
//! NB: In debug mode value type check is still performed, but results in YT_ABORT().
2727
static TKey FromRowUnchecked(TUnversionedRow row, std::optional<int> length = {});
2828

2929
//! Performs a deep copy of underlying values into owning row.
@@ -64,7 +64,7 @@ void Serialize(const TKey& key, NYson::IYsonConsumer* consumer);
6464
//! replacing all sentinels to <null> and by padding row with nulls or shortening it so that
6565
//! row length is exactly keyLength.
6666
//!
67-
//! NB: this method is inefficient (as it deals with owning rows), do not use it on hot path.
67+
//! NB: This method is inefficient (as it deals with owning rows), do not use it on hot path.
6868
TUnversionedOwningRow LegacyKeyToKeyFriendlyOwningRow(TUnversionedRow row, int keyLength);
6969

7070
////////////////////////////////////////////////////////////////////////////////

yt/yt/client/table_client/key_bound.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class TKeyBoundImpl
3333
static TKeyBound FromRow(TRow&& row, bool isInclusive, bool isUpper);
3434

3535
//! Construct from a given row without checking presence of types Min, Max and Bottom.
36-
//! NB: in debug mode value type check is still performed, but results in YT_ABORT().
36+
//! NB: In debug mode value type check is still performed, but results in YT_ABORT().
3737
static TKeyBound FromRowUnchecked(const TRow& row, bool isInclusive, bool isUpper);
3838

3939
//! Same as previous but for rvalue refs.
@@ -150,7 +150,7 @@ bool operator ==(const TOwningKeyBound& lhs, const TOwningKeyBound& rhs);
150150
std::pair<int, bool> GetBoundPrefixAndInclusiveness(TUnversionedRow row, bool isUpper, int keyLength);
151151

152152
//! Convert legacy key bound expressed as a row possibly containing Min/Max to owning key bound.
153-
//! NB: key length is needed to properly distinguish if K + [min] is an inclusive K or exclusive K.
153+
//! NB: Key length is needed to properly distinguish if K + [min] is an inclusive K or exclusive K.
154154
TOwningKeyBound KeyBoundFromLegacyRow(TUnversionedRow row, bool isUpper, int keyLength);
155155

156156
//! Same as previous, but non-owning variant over row buffer.

yt/yt/client/table_client/logical_type.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ i64 TOptionalLogicalType::GetMemoryUsage(i64 limit) const
394394
YT_ASSERT(limit > 0);
395395

396396
if (Element_->GetMetatype() == ELogicalMetatype::Simple) {
397-
// NB: see TOptionalLogicalType::GetMemoryUsage().
397+
// NB: See TOptionalLogicalType::GetMemoryUsage().
398398
return 0;
399399
} else if (auto sizeOfThis = static_cast<i64>(sizeof(*this)); sizeOfThis >= limit) {
400400
return sizeof(*this);

yt/yt/client/table_client/unversioned_row.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class TUnversionedOwningValue
7979
char* GetMutableString()
8080
{
8181
YT_VERIFY(IsStringLikeType(Value_.Type));
82-
// NB: it is correct to use `const_cast` here to modify the stored string
82+
// NB: It is correct to use `const_cast` here to modify the stored string
8383
// because initially it's allocated as a non-const `char*`.
8484
return const_cast<char*>(Value_.Data.String);
8585
}

0 commit comments

Comments
 (0)