Better empty table name validation (#20620)

Author: kunga

ydb/core/tx/datashard/build_index/local_kmeans.cpp

@@ -634,10 +634,10 @@ void TDataShard::HandleSafe(TEvDataShard::TEvLocalKMeansRequest::TPtr& ev, const
             lead.Until(range.To, true);
         }
 
-        if (!request.HasLevelName()) {
+        if (!request.GetLevelName()) {
             badRequest(TStringBuilder() << "Empty level table name");
         }
-        if (!request.HasOutputName()) {
+        if (!request.GetOutputName()) {
             badRequest(TStringBuilder() << "Empty output table name");
         }
 

ydb/core/tx/datashard/build_index/prefix_kmeans.cpp

@@ -606,13 +606,13 @@ void TDataShard::HandleSafe(TEvDataShard::TEvPrefixKMeansRequest::TPtr& ev, cons
             badRequest("Should be requested partition on at least two rows");
         }
 
-        if (!request.HasLevelName()) {
+        if (!request.GetLevelName()) {
             badRequest(TStringBuilder() << "Empty level table name");
         }
-        if (!request.HasOutputName()) {
+        if (!request.GetOutputName()) {
             badRequest(TStringBuilder() << "Empty output table name");
         }
-        if (!request.HasPrefixName()) {
+        if (!request.GetPrefixName()) {
             badRequest(TStringBuilder() << "Empty prefix table name");
         }
 

ydb/core/tx/datashard/build_index/reshuffle_kmeans.cpp

@@ -444,7 +444,7 @@ void TDataShard::HandleSafe(TEvDataShard::TEvReshuffleKMeansRequest::TPtr& ev, c
             lead = CreateLeadFrom(range);
         }
 
-        if (!request.HasOutputName()) {
+        if (!request.GetOutputName()) {
             badRequest(TStringBuilder() << "Empty output table name");
         }
 

ydb/core/tx/datashard/build_index/secondary_index.cpp

@@ -595,7 +595,7 @@ void TDataShard::HandleSafe(TEvDataShard::TEvBuildIndexCreateRequest::TPtr& ev,
                 << " scanRange: " << DebugPrintRange(userTable.KeyColumnTypes, scanRange, *AppData()->TypeRegistry));
         }
 
-        if (!request.HasTargetName()) {
+        if (!request.GetTargetName()) {
             badRequest(TStringBuilder() << "Empty target table name");
         }
 

ydb/core/tx/datashard/build_index/ut/ut_secondary_index.cpp

@@ -156,6 +156,9 @@ Y_UNIT_TEST_SUITE(TTxDataShardBuildIndexScan) {
         DoBadRequest(server, sender, [](NKikimrTxDataShard::TEvBuildIndexCreateRequest& request) {
             request.ClearTargetName();
         }, "{ <main>: Error: Empty target table name }");
+        DoBadRequest(server, sender, [](NKikimrTxDataShard::TEvBuildIndexCreateRequest& request) {
+            request.SetTargetName("");
+        }, "{ <main>: Error: Empty target table name }");
 
         DoBadRequest(server, sender, [](NKikimrTxDataShard::TEvBuildIndexCreateRequest& request) {
             request.AddIndexColumns("some");