Skip to content

Commit 2a57035

Browse files
authored
Fixed memory leak since CreateSystemViewResolver returned raw pointer (#20800)
1 parent b221825 commit 2a57035

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

ydb/core/sys_view/common/schema.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -411,12 +411,12 @@ class TSystemViewRewrittenResolver : public ISystemViewResolver {
411411
THashMap<TString, ESysViewType> SystemViewTypes;
412412
};
413413

414-
ISystemViewResolver* CreateSystemViewResolver() {
415-
return new TSystemViewResolver();
414+
THolder<ISystemViewResolver> CreateSystemViewResolver() {
415+
return MakeHolder<TSystemViewResolver>();
416416
}
417417

418-
ISystemViewResolver* CreateSystemViewRewrittenResolver() {
419-
return new TSystemViewRewrittenResolver();
418+
THolder<ISystemViewResolver> CreateSystemViewRewrittenResolver() {
419+
return MakeHolder<TSystemViewRewrittenResolver>();
420420
}
421421

422422
} // NSysView

ydb/core/sys_view/common/schema.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -843,9 +843,9 @@ class ISystemViewResolver {
843843
virtual const THashMap<TString, NKikimrSysView::ESysViewType>& GetSystemViewsTypes(ETarget target) const = 0;
844844
};
845845

846-
ISystemViewResolver* CreateSystemViewResolver();
846+
THolder<ISystemViewResolver> CreateSystemViewResolver();
847847

848-
ISystemViewResolver* CreateSystemViewRewrittenResolver();
848+
THolder<ISystemViewResolver> CreateSystemViewRewrittenResolver();
849849

850850
} // NSysView
851851
} // NKikimr

0 commit comments

Comments
 (0)