Add debug info to TPathChecker (#10217)

Author: Enjection

ydb/core/config/init/init.h

@@ -2,7 +2,7 @@
 
 #include <ydb/core/driver_lib/run/service_mask.h>
 #include <ydb/core/base/event_filter.h>
-#include <ydb/core/config/init/source_location.h>
+#include <ydb/core/util/source_location.h>
 #include <ydb/core/protos/config.pb.h>
 #include <ydb/library/actors/core/interconnect.h>
 #include <ydb/public/lib/deprecated/kicli/kicli.h>

ydb/core/tx/schemeshard/schemeshard_path.cpp

@@ -8,10 +8,11 @@
 
 namespace NKikimr::NSchemeShard {
 
-TPath::TChecker::TChecker(const TPath& path)
+TPath::TChecker::TChecker(const TPath& path, const NCompat::TSourceLocation location)
     : Path(path)
     , Failed(false)
     , Status(EStatus::StatusSuccess)
+    , Location(location)
 {
 }
 
@@ -32,7 +33,14 @@ const TPath::TChecker& TPath::TChecker::Fail(EStatus status, const TString& erro
     Status = status;
     Error = TStringBuilder() << "Check failed"
         << ": path: '" << Path.PathString() << "'"
-        << ", error: " << error;
+        << ", error: " << error
+    // this line included only in debug error
+    // because we do not want to forward information
+    // about our sources to db user
+#ifndef NDEBUG
+        << ", source_location: " << NUtil::TrimSourceFileName(Location.file_name()) << ":" << Location.line()
+#endif
+        ;
 
     return *this;
 }
@@ -1102,8 +1110,8 @@ TPath::TPath(TVector<TPathElement::TPtr>&& elements, TSchemeShard* ss)
     Y_ABORT_UNLESS(IsResolved());
 }
 
-TPath::TChecker TPath::Check() const {
-    return TChecker(*this);
+TPath::TChecker TPath::Check(const NCompat::TSourceLocation location) const {
+    return TChecker(*this, location);
 }
 
 bool TPath::IsEmpty() const {

ydb/core/tx/schemeshard/schemeshard_path.h

@@ -4,6 +4,7 @@
 #include "schemeshard_info_types.h"
 
 #include <ydb/core/protos/flat_tx_scheme.pb.h>
+#include <ydb/core/util/source_location.h>
 
 #include <util/generic/maybe.h>
 
@@ -19,18 +20,18 @@ class TPath {
 public:
     class TChecker {
         using EStatus = NKikimrScheme::EStatus;
-
         const TPath& Path;
         mutable bool Failed;
         mutable EStatus Status;
         mutable TString Error;
+        NCompat::TSourceLocation Location;
 
     private:
         TString BasicPathInfo(TPathElement::TPtr element) const;
         const TChecker& Fail(EStatus status, const TString& error) const;
 
     public:
-        explicit TChecker(const TPath& path);
+        explicit TChecker(const TPath& path, const NCompat::TSourceLocation location = NCompat::TSourceLocation::current());
 
         explicit operator bool() const;
         EStatus GetStatus() const;
@@ -122,8 +123,7 @@ class TPath {
     static TPath ResolveWithInactive(TOperationId opId, const TString path, TSchemeShard* ss);
 
     static TPath Init(const TPathId pathId, TSchemeShard* ss);
-
-    TChecker Check() const;
+    TChecker Check(const NCompat::TSourceLocation location = NCompat::TSourceLocation::current()) const;
     bool IsEmpty() const;
     bool IsResolved() const;
 

ydb/core/util/source_location.cpp

@@ -0,0 +1,26 @@
+#include "source_location.h"
+
+#include <string_view>
+
+namespace NKikimr::NUtil {
+
+constexpr inline auto ThisFileLocation = NCompat::TSourceLocation::current();
+constexpr inline ui64 ThisFileSuffixLength = 33; // length of "ydb/core/util/source_location.cpp"
+constexpr inline ui64 ThisFileLength = std::string_view(ThisFileLocation.file_name()).length();
+constexpr inline ui64 PrefixLength = ThisFileLength - ThisFileSuffixLength;
+
+TString TrimSourceFileName(const char* fileName) {
+    if constexpr (NCompat::HasSourceLocation) {
+        static_assert(std::string_view(ThisFileLocation.file_name()).substr(PrefixLength) == std::string_view("ydb/core/util/source_location.cpp"));
+
+        if (!std::string_view(fileName).starts_with(std::string_view(ThisFileLocation.file_name()).substr(0, PrefixLength))) {
+            return fileName;
+        }
+
+        return TString(fileName + PrefixLength);
+    }
+
+    return fileName;
+}
+
+} // namespace NKikimr::NUtil

ydb/core/config/init/source_location.h renamed to ydb/core/util/source_location.h

@@ -1,12 +1,16 @@
 #pragma once
 
+#include <util/generic/string.h>
+
 #if __has_builtin(__builtin_source_location)
 #include <source_location>
 
 namespace NKikimr::NCompat {
 
 using TSourceLocation = std::source_location;
 
+constexpr inline bool HasSourceLocation = true;
+
 } // namespace NCompat
 #else
 namespace NKikimr::NCompat {
@@ -28,5 +32,13 @@ struct TSourceLocation {
     }
 };
 
+constexpr inline bool HasSourceLocation = false;
+
 } // namespace NCompat
 #endif
+
+namespace NKikimr::NUtil {
+
+TString TrimSourceFileName(const char* fileName);
+
+} // namespace NKikimrNUtil

ydb/core/util/ya.make

@@ -44,6 +44,7 @@ SRCS(
     simple_cache.h
     single_thread_ic_mock.cpp
     single_thread_ic_mock.h
+    source_location.cpp
     stlog.cpp
     stlog.h
     testactorsys.cpp