add debug details to troubleshoot scan data ack failure (#9518)

Author: gridnevvvit

ydb/core/kqp/compute_actor/kqp_scan_compute_manager.h

@@ -71,6 +71,18 @@ class TShardScannerInfo {
             new TEvPipeCache::TEvForward(ev.release(), TabletId, !subscribed), IEventHandle::FlagTrackDelivery);
     }
 
+    TString ToString() const {
+        TStringBuilder builder;
+
+        if (ActorId) {
+            builder << "ActorId: " << *ActorId;
+        }
+
+        builder << "TabletId: " << TabletId << ", ScanId: " << ScanId;
+
+        return builder;
+    }
+
     void Stop(const bool finalFlag, const TString& message) {
         AFL_DEBUG(NKikimrServices::KQP_COMPUTE)("event", "stop_scanner")("actor_id", ActorId)("message", message)("final_flag", finalFlag);
         if (ActorId) {

ydb/core/kqp/compute_actor/kqp_scan_fetcher_actor.cpp

@@ -84,7 +84,7 @@ void TKqpScanFetcherActor::Bootstrap() {
 }
 
 void TKqpScanFetcherActor::HandleExecute(TEvScanExchange::TEvAckData::TPtr& ev) {
-    Y_ABORT_UNLESS(ev->Get()->GetFreeSpace());
+    AFL_ENSURE(ev->Get()->GetFreeSpace());
     AFL_DEBUG(NKikimrServices::KQP_COMPUTE)("event", "AckDataFromCompute")("self_id", SelfId())("scan_id", ScanId)
         ("packs_to_send", InFlightComputes.GetPacksToSendCount())
         ("from", ev->Sender)("shards remain", PendingShards.size())
@@ -237,7 +237,7 @@ void TKqpScanFetcherActor::HandleExecute(TEvTxProxySchemeCache::TEvResolveKeySet
     PendingResolveShards.pop_front();
     ResolveNextShard();
 
-    Y_ABORT_UNLESS(!InFlightShards.GetShardScanner(state.TabletId));
+    AFL_ENSURE(!InFlightShards.GetShardScanner(state.TabletId));
 
     AFL_ENSURE(state.State == EShardState::Resolving);
     CA_LOG_D("Received TEvResolveKeySetResult update for table '" << ScanDataMeta.TablePath << "'");
@@ -364,13 +364,19 @@ void TKqpScanFetcherActor::HandleExecute(TEvents::TEvUndelivered::TPtr& ev) {
         case TEvDataShard::TEvKqpScan::EventType:
             // Handled by TEvPipeCache::TEvDeliveryProblem event.
             return;
-        case TEvKqpCompute::TEvScanDataAck::EventType:
-            if (!!InFlightShards.GetShardScanner(ev->Cookie)) {
-                SendGlobalFail(NDqProto::StatusIds::UNAVAILABLE, TIssuesIds::DEFAULT_ERROR, "Delivery problem: EvScanDataAck lost.");
+        case TEvKqpCompute::TEvScanDataAck::EventType: {
+            auto info = InFlightShards.GetShardScanner(ev->Cookie);
+            if (!!info) {
+                TStringBuilder builder;
+                builder << "Delivery problem: EvScanDataAck lost, NodeId: "
+                    << SelfId().NodeId() << ", Details: " << info->ToString() << ".";
+
+                SendGlobalFail(NDqProto::StatusIds::UNAVAILABLE, TIssuesIds::DEFAULT_ERROR, TString(builder));
             }
             return;
+        }
     }
-    Y_ABORT("UNEXPECTED EVENT TYPE");
+    AFL_ENSURE("Unexpected event type ")("source_type", ev->Get()->SourceType);
 }
 
 void TKqpScanFetcherActor::HandleExecute(TEvInterconnect::TEvNodeDisconnected::TPtr& ev) {